On Wed, 23 Apr 2025 00:56:18 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
On Tue, 22 Apr 2025 23:29:02 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
On Thu, 17 Apr 2025 20:51:10 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Fri, 11 Apr 2025 22:45:55 GMT, Chen Liang wrote:
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance i
On Fri, 4 Apr 2025 15:59:47 GMT, Henry Jen wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 99:
>>
>>> 97: if (!entryNames.contains(entryName)) {
>>> 98: missingEntryNames.add(entryName);
>>> 99:
On Fri, 4 Apr 2025 12:39:47 GMT, Lance Andersen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> src/jdk.jartool/sha
This PR check the jar file to ensure entries are consistent from the central
directory and local file header. Also check there is no duplicate entry names
that could override the desired content by accident.
-
Commit messages:
- 8345431: Detect duplicate entries in jar files with j
On Tue, 1 Apr 2025 17:33:43 GMT, Alan Bateman wrote:
> `jmod create` maps the contents of the module to a set of packages. This
> mapping derives illegal package names when class resources are located in
> non-package locations, e.g. in the META-INF tree. `jlink` also has an issue
> in this ar
On Sat, 8 Mar 2025 00:28:15 GMT, Henry Jen wrote:
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
This pull request has now been integrated.
Changeset: 0ff1c083
Author: Henry Jen
URL:
https://git.openjdk.org/jdk/com
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Address review feedbacks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23954/files
-
On Sun, 9 Mar 2025 18:11:07 GMT, Chen Liang wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java line 794:
>>
>>> 792: log.format("%-40s %s%n",
>>> 793:"-".repeat(internalApiTitle.length()),
>>> 794:
> JDK-8349989: jlink can use String.replace instead of String.replaceAll
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23954/files
- new: ht
JDK-8349989: jlink can use String.replace instead of String.replaceAll
-
Commit messages:
- JDK-8349989: jlink can use String.replace instead of String.replaceAll
- JDK-8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll
Changes: https://git.openjdk.org/jdk/pu
On Wed, 15 Jan 2025 05:14:51 GMT, Henry Jen wrote:
> jimage use the same code to parse command line options, the resource bundle
> for jimage also need update.
This pull request has now been integrated.
Changeset: a3be97e2
Author: Henry Jen
URL:
https://git.openjdk.org/jdk/
jimage use the same code to parse command line options, the resource bundle for
jimage also need update.
-
Commit messages:
- 8347761: Test tools/jimage/JImageExtractTest.java fails after JDK-8303884
Changes: https://git.openjdk.org/jdk/pull/23123/files
Webrev: https://webrevs.op
On Wed, 8 Jan 2025 09:08:11 GMT, Per Minborg wrote:
> > Do we have a sense on how easy would it be, moving forward, to preserve the
> > "correct" order of imports? E.g. if I add a new one using IntelliJ
> > autocompletion, where would it end up? Has this patch been generated using
> > the IDE'
On Tue, 3 Dec 2024 19:59:56 GMT, Henry Jen wrote:
> Improving option value handling to support passing argument value starts with
> "--".
>
> Before the fix, in following example, --add-modules will be considered as
> another option for JLink instead of argumen
On Tue, 14 Jan 2025 09:06:21 GMT, Yasumasa Suenaga wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use different error message for ambiguous gnu-style options as value
>
> It's b
On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
erly handled as
> argument value
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22526/file
On Mon, 13 Jan 2025 21:58:43 GMT, Henry Jen wrote:
> Sort services provided by a module to ensure reproduce same result.
This pull request has now been integrated.
Changeset: dfd215b7
Author: Henry Jen
URL:
https://git.openjdk.org/jdk/commit/dfd215b7e9e40526006448369c8847aadfe09
Sort services provided by a module to ensure reproduce same result.
-
Commit messages:
- 8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and
PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413
Changes: https://git.openjdk.org/jdk/pull/23088/files
Web
erly handled as
> argument value
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Use different error message for ambiguous gnu-style options as value
-
Changes:
- al
On Wed, 8 Jan 2025 00:40:04 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink ins
On Thu, 9 Jan 2025 18:25:16 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
>
On Thu, 9 Jan 2025 17:32:39 GMT, Severin Gehwolf wrote:
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
>
On Mon, 16 Sep 2024 17:50:52 GMT, Henry Jen wrote:
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
On Thu, 2 Jan 2025 18:43:35 GMT, Henry Jen wrote:
>> I would expect the next token would be parsed as the value. I suggest to
>> explore that and see how complex it would be.
>>
>> It seems awkward if the following are accepted:
>>
>> --add-options &qu
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Sun, 22 Sep 2024 15:38:19 GMT, Alan Bateman wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the cl
handled as
> argument value. Also using "" with multiple values will be recognized
> properly. So following form should work
> --add-options "--add-modules jdk.incubator.concurrent"
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated the
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Thu, 5 Dec 2024 17:45:32 GMT, Mandy Chung wrote:
>> --style argument still could be a real jlink argument, better check would be
>> to see if that's a valid jlink option rather than just "--".
>> The other alternative would be like what proposed by @YaSuenag, simply take
>> the next token a
On Fri, 20 Dec 2024 22:32:00 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 16
On Fri, 13 Dec 2024 23:29:23 GMT, Henry Jen wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 584:
>>
>>> 582: private void dedups(ModuleDescriptor md) {
>>> 583: // exports
>>
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 20 Dec 2024 22:20:16 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 16
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 13 Dec 2024 23:24:33 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move up Snippet setup as a builder
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/i
On Fri, 13 Dec 2024 22:42:47 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move up Snippet setup as a builder
>
> src/jdk.jlink/share/classes/jd
On Fri, 13 Dec 2024 23:06:47 GMT, Mandy Chung wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 1136:
>>
>>> 1134: /*
>>> 1135: * SetReference count references to the set, and use
>>> LoadableSet under the hood to
>
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 6 Dec 2024 00:43:29 GMT, Damon Nguyen wrote:
>> That's because the English source file had an update to introduce those
>> double single quotes. (See
>> https://cr.openjdk.org/~jlu/output/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.html).
>> It's just being updat
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
> correctnes
On Tue, 3 Dec 2024 22:43:17 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix style
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskH
handled as
> argument value. Also using "" with multiple values will be recognized
> properly. So following form should work
> --add-options "--add-modules jdk.incubator.concurrent"
> --add-options=--add-modules=jdk.incubator.concurrent
Henry Jen has updated t
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in officia
On Wed, 4 Dec 2024 18:27:45 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>>
>>> 126:
>>> 127: // In case VM is not yet set this property
>>> 128: props.putIfAbsent("java.vm.vendor", VENDOR_VM);
>>
>> Can this system prope
On Wed, 4 Dec 2024 18:03:42 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up adapting review comments
>
> make/autoconf/spec.gmk.template line 276:
>
>&
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in officia
On Wed, 4 Dec 2024 06:15:56 GMT, Henry Jen wrote:
>> Or are you assuming/expecting the VersionProps value is null unless being
>> overridden? You could initialize the VersionProps value to be the same as
>> what VENDOR is at build time and always use it to set the
>> A
On Wed, 4 Dec 2024 06:04:09 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/abstract_vm_version.cpp line 132:
>>
>>> 130:
>>> 131: static const char vm_vendor_string[sizeof(VENDOR) < VENDOR_PADDING ?
>>> VENDOR_PADDING : sizeof(VENDOR)] = VENDOR;
>>> 132: const char* Abstract_VM_Version:
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property va
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property va
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in officia
ild time, and then later be replaced with value from
> VersionProps.
>
> To keep current behavior, we treat 'N/A' value as no-op to mimic current
> build behavior. Perhaps we don't really need this, as proper value should be
> set with `branding.conf` in official bui
On Tue, 2 Jul 2024 12:20:17 GMT, Yasumasa Suenaga wrote:
> We cannot pass GNU style options like `--enable-preview` to `jlink
> --add-option`. It is hard to use for complex application.
>
> We have workaround for this issue (see JBS), but I think it is better to fix
> on JDK side.
The propose
Improving plugin option value handling to support passing argument value starts
with "--".
Before the fix, in following example, --add-modules will be considered as
another option for JLink instead of argument value for --add-options.
--add-options --add-modules=jdk.incubator.concurrent
--add-op
On Tue, 3 Dec 2024 17:01:06 GMT, Severin Gehwolf wrote:
>> I think the issue is not the default value, but the special treatment with
>> default value. Is there a reason we didn't set COMPANY_NAME to "N/A" as in
>> branding.conf?
>> https://github.com/openjdk/jdk/blame/master/make/autoconf/spec
On Tue, 3 Dec 2024 14:28:22 GMT, Magnus Ihse Bursie wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 131:
>>
>>> 129: // Default branding.conf value is "N/A", which did not affect
>>> java.vm.vendor
>>> 130: if (! VENDOR_VM.equals("N/A")) {
>>> 131
On Mon, 2 Dec 2024 19:59:51 GMT, David Holmes wrote:
>> I agree. This is to minimize change on behavior.
>>
>> Not sure what kind of requirement is there for java.vm.vendor, would it be
>> OK for VM not the set this value and wait until loading of VersionProps
>> class?
>>
>> The update is n
On Mon, 2 Dec 2024 19:52:36 GMT, David Holmes wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was i
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java
On Mon, 2 Dec 2024 18:34:49 GMT, Alan Bateman wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was i
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 15 Nov 2024 06:37:26 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help meth
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Wed, 13 Nov 2024 16:08:44 GMT, Christian Stein wrote:
>> Please review this change for the `jar` tool to gracefully handle the case
>> where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and
>> `--validate` expected to
Add jlink plugins to allow branding change for java.vendor, java.vm.vendor and
java.vendor.url.
The jlink plugin will change the value in java.lang.VersionProps, which will
set those property values. The `java.vm.vendor` was initialized by VM with
value set at build time, and then later be repl
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Tue, 29 Oct 2024 20:14:27 GMT, Severin Gehwolf wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix regression failed to setup helper methods properly
>
> src/jdk.jlink/share/cl
On Mon, 28 Oct 2024 05:15:18 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help meth
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Fri, 25 Oct 2024 15:24:47 GMT, Lance Andersen wrote:
>> Check output for including values rather than exact match.
>> Also include the manpage change and revert the problem list.
>
> test/jdk/tools/jar/ExtractFilesTest.java line 185:
>
>> 183: Assertions.assertTrue(baos.toString().co
On Fri, 25 Oct 2024 01:38:55 GMT, Henry Jen wrote:
> Check output for including values rather than exact match.
> Also include the manpage change and revert the problem list.
This pull request has now been integrated.
Changeset: 5cbd578f
Author: Henry Jen
URL:
On Fri, 25 Oct 2024 04:35:18 GMT, Jaikiran Pai wrote:
>> test/jdk/tools/jar/MultipleManifestTest.java line 203:
>>
>>> 201:
>>> 202: private void assertOutputContains(String expected) {
>>> 203: Assertions.assertTrue(baos.toString().contains(expected));
>>
>> The linked JBS issue n
Check output for including values rather than exact match.
Also include the manpage change and revert the problem list.
-
Commit messages:
- 8342930: New tests from JDK-8335912 are failing
Changes: https://git.openjdk.org/jdk/pull/21697/files
Webrev: https://webrevs.openjdk.org/?
On Mon, 23 Sep 2024 17:32:10 GMT, Henry Jen wrote:
> This PR support a -k, --keep options like tar that allows jar to avoid
> override existing files.
This pull request has now been integrated.
Changeset: 158b93d1
Author: Henry Jen
URL:
https://git.openjdk.org/jdk/
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
> This PR support a -k, --keep options like tar that allows jar to avoid
> override existing files.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Adapt review suggestion
-
Changes:
- all: https://git.openjdk.o
On Wed, 2 Oct 2024 00:20:32 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing from last commit
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/Sy
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Mon, 30 Sep 2024 15:26:07 GMT, Henry Jen wrote:
>> Hello Henry, I think this `-k` option help text would need a slight
>> modification. Right now it states that if a file appears more than once in
>> an archive, then this setting this flag will not overwrite the earl
> This PR support a -k, --keep options like tar that allows jar to avoid
> override existing files.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
More review comments
-
Changes:
- all: https://git.openjdk.org/jd
On Mon, 30 Sep 2024 11:38:20 GMT, Lance Andersen wrote:
>> I follow existing pattern with short status update. Open to suggestions.
>
> Perhaps something like:
>
> ` \ \ file: {0} exists, skipped`
Use this for now to be more close to current style,
`\ \ skipped: {0} exists`
Was thinki
On Tue, 1 Oct 2024 07:15:13 GMT, Eirik Bjørsnøs wrote:
> Is `compiler` label needed? The `jar` tool belongs in `core-libs`, right?
> This PR does not seem to touch anything in the compiler area?
Automatically added by the bot. I agree it's not related to compiler at all.
I'll manually remove i
On Mon, 30 Sep 2024 15:51:43 GMT, Lance Andersen wrote:
>> I considered that, but didn't implement it after confirmed other similar
>> options didn't display any warning.
>> I do think it make sense to show a warning when using an option not valid in
>> specific mode.
>
>> I considered that, bu
On Sat, 28 Sep 2024 13:53:03 GMT, Jaikiran Pai wrote:
>> Updated.
>
> Hello Henry, I think this `-k` option help text would need a slight
> modification. Right now it states that if a file appears more than once in an
> archive, then this setting this flag will not overwrite the earlier copies.
On Sat, 28 Sep 2024 14:32:31 GMT, Jaikiran Pai wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review feedbacks
>
> test/jdk/tools/jar/ExtractFilesTest.java line 241:
>
>
On Mon, 30 Sep 2024 11:23:33 GMT, Lance Andersen wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review feedbacks
>
> src/jdk.jartool/share/classes/sun/tools/jar
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
> This PR support a -k, --keep options like tar that allows jar to avoid
> override existing files.
Henry Jen has updated the pull request incrementally with one additional commit
since the last revision:
Address review feedbacks
-
Changes:
- all: https://git.openjdk.o
On Tue, 24 Sep 2024 19:16:17 GMT, Lance Andersen wrote:
>> Henry Jen has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains one commit:
>>
>> 8335912: Add an operation mode to the jar command when extractin
er is captured in advance, this count could mismatch as built
> time and run time.
>
> So we make this build in advance, and use a static array for values referred
> more than once.
>
> All the codegen instead of giving index to be loaded, the builder snippet now
> load the wa
On Thu, 26 Sep 2024 00:05:13 GMT, Chen Liang wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the clas
On Wed, 25 Sep 2024 23:49:18 GMT, Chen Liang wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the clas
> This PR support a -k, --keep options like tar that allows jar to avoid
> override existing files.
Henry Jen has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains one commit:
8335912: Add an operation mode to the jar comman
1 - 100 of 110 matches
Mail list logo
