On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> During code review of >> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments >> were made after the PR integrated. This follow-up patch cleans this up and >> adds a unit test for the `JimageDiffGenerator` class. >> >> Testing: >> - [x] GHA >> - [x] tools/jlink tests (including the new one). >> >> Thoughts? > > Severin Gehwolf has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'master' into jdk-8347334-jimage-diff-gen-cleanup > - Further simplification > - Review feedback > - 8347334: JimageDiffGenerator code clean-ups Marked as reviewed by henryjen (Committer). I am not a JDK reviewer, so you will need someone else. ------------- PR Review: https://git.openjdk.org/jdk/pull/23014#pullrequestreview-2550554318 PR Comment: https://git.openjdk.org/jdk/pull/23014#issuecomment-2590681168
