On Mon, 2 Dec 2024 19:59:51 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> I agree. This is to minimize change on behavior. >> >> Not sure what kind of requirement is there for java.vm.vendor, would it be >> OK for VM not the set this value and wait until loading of VersionProps >> class? >> >> The update is needed for the assertion in statSampler, I don't see other >> reference to the property in the repo. So the question is when we need the >> property to be available and exposure scope. > > I'm a little lost in the sequence of events here as well. Why do we call > `override_vm_vendor` in `initialize_java_lang_classes` and then > `update_vm_vendor` here? I can do it together, override_vm_vendor read the value from the VersionProps class and set the value in VM. update_vm_vendor update the java.vm.vendor system property with the override value. So I think override is part of the initialize class, and the replace the system property after initialize of VersionProps. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1866747941
