On Tue, 29 Oct 2024 20:14:27 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix regression failed to setup helper methods properly > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippets.java line 69: > >> 67: >> 68: /** >> 69: * The type of the reference be loaded onto the operatnd stack. > > Suggestion: > > * The type of the reference be loaded onto the operand stack. Thanks, fixed locally, will wait for more feedback and accumulate fixes with next commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21022#discussion_r1821594985
