On Fri, 25 Oct 2024 15:24:47 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Check output for including values rather than exact match. >> Also include the manpage change and revert the problem list. > > test/jdk/tools/jar/ExtractFilesTest.java line 185: > >> 183: Assertions.assertTrue(baos.toString().contains(expected)); >> 184: } >> 185: > > Is this really needed vs just including the Assertions.assertTrue where you > are replacing the existing Assertions.assertArrayEquals? > > I only ask as there is no additional validation in the method being added so > outside of the change in methods. Valid points. A separate ticket is certainly better, or perhaps I should change the ticket title. In a sense, I consider the man page change a missing part, and follow up work of the origin ticket, just like test failure. The extra method is so that we if we need to change the verification again. The method could be better named as `verifyOutput` or else to reveal the intention better. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21697#discussion_r1817011375
