On Tue, 3 Dec 2024 17:01:06 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> I think the issue is not the default value, but the special treatment with >> default value. Is there a reason we didn't set COMPANY_NAME to "N/A" as in >> branding.conf? >> https://github.com/openjdk/jdk/blame/master/make/autoconf/spec.gmk.template#L276-L285 >> >> Instead of default to "N/A", personally I think "OpenJDK" as an organization >> can be used? > >> Instead of default to "N/A", personally I think "OpenJDK" as an organization >> can be used? > > OpenJDK is a source only distribution. As such vendor being set to OpenJDK > for the binary doesn't make sense. It's the downstream distro shipping the > binary that should set it. "N/A" is OK. I don't know if the empty string is a > good one. Point taken. I would imagine downstream vendor would modify branding.conf to proper value instead of using the default. "N/A" is fine to me, question is whether COMPANY_NAME should be derived from branding.conf regardless. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1868138657
