On Wed, 4 Dec 2024 06:15:56 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> Or are you assuming/expecting the VersionProps value is null unless being >> overridden? You could initialize the VersionProps value to be the same as >> what VENDOR is at build time and always use it to set the >> Abstract_VM_Version field ... though I'm not sure if we really need it in >> Abstract_VM_Version ... > > We can, if we don't care original value. The origin build of the image would > have same value in VersionProps and VM. However, VersionProps value can be > altered with JLink plugin when create a new image from the built image. never mind, the built value is still in vm_vendor_string. Since we should only call set_vm_vendor once, we don't worry about free. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1868794281
