On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen <henry...@openjdk.org> wrote:

> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor 
> and java.vendor.url.
> 
> The jlink plugin will change the value in java.lang.VersionProps, which will 
> set those property values. The `java.vm.vendor` was initialized by VM with 
> value set at build time, and then later be replaced with value from 
> VersionProps.
> 
> To keep current behavior, we treat 'N/A' value as no-op to mimic current 
> build behavior. Perhaps we don't really need this, as proper value should be 
> set with `branding.conf` in official build.

If we don't need java.vm.vendor to be set before loading VersionProps, it would 
be nice to leave that out and simply let VersionProps set the properties.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21964#pullrequestreview-2474129016

Reply via email to