On Mon, 30 Sep 2024 11:23:33 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review feedbacks > > src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 587: > >> 585: break; >> 586: case 'k': >> 587: kflag = true; > > I am wondering if a warning should be displayed if this options is specified > with any option other than 'x' I considered that, but didn't implement it after confirmed other similar options didn't display any warning. I do think it make sense to show a warning when using an option not valid in specific mode. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21141#discussion_r1781320078
