On Wed, 8 Jan 2025 00:40:04 GMT, Henry Jen <[email protected]> wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
>> --add-options --add-modules=jdk.incubator.concurrent
>> --add-options=--add-modules=jdk.incubator.concurrent
>>
>> will cause JLink to report
>> Error: no value given for --add-options
>> as --add-modules is considered another option for JLink.
>>
>> After the fix, by using = will ensure the value is properly handled as
>> argument value
>> --add-options=--add-modules=jdk.incubator.concurrent
>
> Henry Jen has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains five additional commits since
> the last revision:
>
> - Merge remote-tracking branch 'openjdk/master' into JDK-8303884
> - Use opt=value format when value is starting with --
> - Fix style
> - add test
> - 8303884: jlink --add-options plugin does not allow GNU style options to be
> provided
I prefer to have a better error message which tell users what to do. Would
something like following work?
$ jlink --add-modules java.base --add-options --help
Error: value for option --add-options starts with "--" should use
--add-options=<value> format
$ jlink --add-modules --help --add-options --help
Error: value for option --add-modules starts with "--" should use
--add-modules=<value> format
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22526#issuecomment-2585031849
