On Thu, 9 Jan 2025 18:25:16 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> During code review of >> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments >> were made after the PR integrated. This follow-up patch cleans this up and >> adds a unit test for the `JimageDiffGenerator` class. >> >> Testing: >> - [ ] GHA >> - [x] tools/jlink tests (including the new one). >> >> Thoughts? > > Severin Gehwolf has updated the pull request incrementally with one > additional commit since the last revision: > > Review feedback Marked as reviewed by henryjen (Committer). src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/JimageDiffGenerator.java line 135: > 133: bytesRead2 = is2.readNBytes(buf2, 0, buf2.length); > 134: if (bytesRead1 == 0 || bytesRead2 == 0) { > 135: break; // no more bytes for a stream break after test same amount of bytes can remove the test exit the while loop. ------------- PR Review: https://git.openjdk.org/jdk/pull/23014#pullrequestreview-2540700499 PR Review Comment: https://git.openjdk.org/jdk/pull/23014#discussion_r1909295648
