Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff closed pull request #4821: IGNITE-23304 URL: https://github.com/apache/ignite-3/pull/4821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1901529939 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode(

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899686724 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode( // Th

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899366906 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899365933 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899363340 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode(

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899328977 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterator> it

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899328977 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterator> it

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899327370 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode( // Th

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1899325767 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898489346 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898489346 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898475251 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898472228 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode(

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898471783 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898305868 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHandler

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898302027 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterator> it

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898297760 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode( // Th

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898296919 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1897235503 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode(

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896785945 ## modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java: ## @@ -232,11 +203,11 @@ public boolean isEmpty() { re

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896785354 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896784799 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicasSafeTimePropagationTest.java: ## @@ -86,6 +83,8 @@ public class ReplicasSafeTimePr

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896783781 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/RpcRequests.java: ## @@ -121,6 +119,8 @@ public interface TimeoutNowRequest extends Message {

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896737952 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896737952 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

rpuch commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1892167623 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -1956,15 +1935,13 @@ private CompletableFutu

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896739590 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -3733,6 +3750,11 @@ public Message handleTimeoutNowRequest(final TimeoutNowR

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896737952 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896734396 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896695742 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896665963 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896665963 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896600757 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

denis-chudov commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895857123 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -1956,15 +1935,13 @@ private Completa

Re: [PR] IGNITE-23304 [ignite-3]

denis-chudov commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895857123 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -1956,15 +1935,13 @@ private Completa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895799597 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895721421 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895776801 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895776801 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895721421 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895721421 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895721421 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1895721421 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891263758 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893911683 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterator> it

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893908283 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicasSafeTimePropagationTest.java: ## @@ -86,6 +83,8 @@ public class ReplicasSafeTimePropagat

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893899922 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/CommandApplicationResult.java: ## @@ -19,24 +19,25 @@ import java.util.concurrent.Completab

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893898622 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -3733,6 +3750,11 @@ public Message handleTimeoutNowRequest(final TimeoutNowRequest

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893847419 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893847419 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893838148 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893838148 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893836341 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHandler

Re: [PR] IGNITE-23304 [ignite-3]

sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893830196 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterator> it

Re: [PR] IGNITE-23304 [ignite-3]

rpuch commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1892285243 ## modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java: ## @@ -232,11 +203,11 @@ public boolean isEmpty() { return va

Re: [PR] IGNITE-23304 [ignite-3]

rpuch commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1892167623 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -1956,15 +1935,13 @@ private CompletableFutu

Re: [PR] IGNITE-23304 [ignite-3]

rpuch commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1892145355 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/RpcRequests.java: ## @@ -121,6 +119,8 @@ public interface TimeoutNowRequest extends Message { Str

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891937945 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891937945 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891949432 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891937945 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891906336 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java: ## @@ -734,14 +733,6 @@ private void handleErrorResponse(CompletableFutur

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891853838 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode(

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891825169 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -3733,6 +3750,11 @@ public Message handleTimeoutNowRequest(final TimeoutNowR

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891803478 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/command/SafeTimePropagatingCommand.java: ## @@ -26,7 +27,11 @@ * Common interface for

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891734295 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891732182 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -202,19 +189,6 @@ private void onWriteBusy(Iterato

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891729631 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicasSafeTimePropagationTest.java: ## @@ -86,6 +83,8 @@ public class ReplicasSafeTimePr

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891703680 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/CommandApplicationResult.java: ## @@ -19,24 +19,25 @@ import java.util.concurrent.Com

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891430804 ## modules/metastorage/build.gradle: ## @@ -28,6 +28,7 @@ dependencies { implementation project(':ignite-configuration-system') implementation project('

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891424333 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClock.java: ## @@ -44,7 +51,16 @@ public interface HybridClock { HybridTimestamp now();

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891382789 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/UpdateCommandResult.java: ## @@ -94,6 +99,10 @@ public boolean isPrimaryInPeersAndLearners() {

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891381396 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/command/PartitionRaftCommandsSerializationTest.java: ## @@ -256,14 +266,19 @@ private

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891362237 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/command/PartitionRaftCommandsSerializationTest.java: ## @@ -151,6 +154,8 @@ public voi

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891360791 ## modules/table/src/test/java/org/apache/ignite/internal/table/distributed/command/PartitionRaftCommandsSerializationTest.java: ## @@ -119,6 +120,8 @@ public voi

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891358805 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/PartitionCommandsMarshallerImpl.java: ## @@ -31,28 +32,40 @@ public PartitionC

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891357003 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -1956,15 +1935,13 @@ private Completa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891319471 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -627,19 +592,29 @@ public MvPartitionStorage getMvS

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891319471 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -627,19 +592,29 @@ public MvPartitionStorage getMvS

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891319471 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -627,19 +592,29 @@ public MvPartitionStorage getMvS

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891317239 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891309887 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -300,10 +279,10 @@ private void onWriteBusy(Iterat

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891307190 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -1131,7 +1131,6 @@ private void sendSafeTimeSyncIfReplicaRea

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891275744 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -836,7 +836,7 @@ private RaftGroupOptions groupOptionsForPart

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891274327 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/RpcRequests.java: ## @@ -121,6 +119,8 @@ public interface TimeoutNowRequest extends Message {

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891267978 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -889,7 +905,7 @@ public boolean bootstrap(final BootstrapOptions opts) throw

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891263758 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHa

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891250999 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -296,6 +302,23 @@ public void onEvent(final LogEntryAndClosure event, final

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891249139 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -72,31 +63,40 @@ public final long nowLong() { } @Override -

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1888676769 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.a

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1890361179 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode(

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1890335348 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/RaftGroupOptions.java: ## @@ -58,6 +58,11 @@ public class RaftGroupOptions { */ pr

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1890143738 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/marshaller/PartitionCommandsMarshallerImpl.java: ## @@ -31,39 +32,51

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1890138440 ## modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java: ## @@ -110,6 +110,35 @@ public void update(T newValue, @Nullabl

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1890137650 ## modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java: ## @@ -110,6 +110,35 @@ public void update(T newValue, @Nullabl

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1889927669 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -72,31 +63,40 @@ public final long nowLong() { } @Override -

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1889935951 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/PartitionCommandsMarshaller.java: ## @@ -37,4 +37,6 @@ public interface Partiti

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1889934366 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/CheckCatalogVersionOnAppendEntries.java: ## @@ -59,7 +60,8 @@ public CheckCatal

Re: [PR] IGNITE-23304 [ignite-3]

ascherbakoff commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1889933358 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterat

  1   2   >