sanpwc commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1893908283


##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicasSafeTimePropagationTest.java:
##########
@@ -86,6 +83,8 @@ public class ReplicasSafeTimePropagationTest extends 
IgniteAbstractTest {
     @InjectConfiguration("mock: { fsync: false }")
     private RaftConfiguration raftConfiguration;
 
+    private static final int MAX_CLOCK_SKEW = 500;

Review Comment:
   I'm not sure that you got my point 
   I'm suggesting to add something like
   ```
       @InjectConfiguration("mock: { maxClockSkew: 500 }")
       private SchemaSynchronizationConfiguration 
schemaSynchronizationConfiguration;
   ```
   instead `private static final int MAX_CLOCK_SKEW = 500;`
   and using it 
   ```
       RaftGroupOptions.defaults()
               .maxClockSkew(schemaSynchronizationConfiguration.maxClockSkew())
   ```
   Please be aware that I didn't check that `"mock: { maxClockSkew: 500 }"` is 
correct syntax. Please consider it as a presudocode. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to