rpuch commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1892145355


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/RpcRequests.java:
##########
@@ -121,6 +119,8 @@ public interface TimeoutNowRequest extends Message {
         String peerId();
 
         long term();
+
+        @Nullable HybridTimestamp timestamp();

Review Comment:
   Should the tests be fixed to always pass something? This will allow the 
production code be safer (nullability will go away)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to