ascherbakoff commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891732182
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -202,19 +189,6 @@ private void
onWriteBusy(Iterator<CommandClosure<WriteCommand>> iterator) {
iterator.forEachRemaining((CommandClosure<? extends WriteCommand> clo)
-> {
Command command = clo.command();
- if (command instanceof SafeTimePropagatingCommand) {
- SafeTimePropagatingCommand cmd = (SafeTimePropagatingCommand)
command;
- long proposedSafeTime = cmd.safeTime().longValue();
-
- // Because of clock.tick it's guaranteed that two different
commands will have different safe timestamps.
- // maxObservableSafeTime may match proposedSafeTime only if it
is the command that was previously validated and then retried
- // by raft client because of either TimeoutException or inner
raft server recoverable exception.
- assert proposedSafeTime >= maxObservableSafeTimeVerifier :
"Safe time reordering detected [current="
Review Comment:
This assert is moved to SafeTimeValuesTracker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
