ascherbakoff commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891803478


##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/command/SafeTimePropagatingCommand.java:
##########
@@ -26,7 +27,11 @@
  * Common interface for commands carrying safe time.
  */
 public interface SafeTimePropagatingCommand extends WriteCommand {
-    /** Safe time. */
+    @Override
+    HybridTimestamp initiatorTime();

Review Comment:
   Yes, safe time mechanics is fully managed inside raft.
   initiatorTime is required to establish ordering between primary replica and 
replication group.
   For example, for full transaction safe timestamp (which is equal to commit 
timestamp) must be greater than start timestamp.
   Metastorage already has the same concept: 
MetaStorageWriteCommand#initiatorTime



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to