sanpwc commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898296919
##########
modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java:
##########
@@ -17,10 +17,27 @@
package org.apache.ignite.internal.raft;
+import org.apache.ignite.internal.hlc.HybridTimestamp;
import org.apache.ignite.internal.network.NetworkMessage;
+import org.jetbrains.annotations.Nullable;
/**
* A marker interface for replication group command.
*/
public interface Command extends NetworkMessage {
+ /**
+ * This is called before a command is submitted to replication pipeline.
+ *
+ * @param safeTs Safe timestamp.
+ */
+ default void patch(HybridTimestamp safeTs) {}
+
+ /**
+ * Holds request's initiator timestamp.
+ *
+ * @return The timestamp.
+ */
+ default @Nullable HybridTimestamp initiatorTime() {
Review Comment:
As far as I understand SafeTimePropagatingCommand should always have
initiatorTime and any other commands should never have initiatorTime, is that
correct? If true, adding @Nullable initiatorTime to WriteCommand seems like a
bad design to me. I do understand that it's likely because of patching code in
NodeImpl
```
// Patch the command.
if (event.done instanceof WriteCommandClosure) {
WriteCommandClosure clo = (WriteCommandClosure) event.done;
WriteCommand command = clo.command();
HybridTimestamp timestamp = command.initiatorTime();
```
I guess that since you move safe time logic into raft you should also move
`SafeTimePropagatingCommand` from
`package org.apache.ignite.internal.replicator.command;`
to
`package org.apache.ignite.internal.raft;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
