ascherbakoff commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1891357003
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1956,15 +1935,13 @@ private
CompletableFuture<WriteIntentSwitchReplicatedInfo> applyWriteIntentSwitc
indexIdsAtRwTxBeginTs(transactionId)
);
- CompletableFuture<Object> resultFuture = new CompletableFuture<>();
-
- applyCmdWithRetryOnSafeTimeReorderException(wiSwitchCmd, resultFuture);
-
- return resultFuture
+ return applyCmdWithExceptionHandling(wiSwitchCmd)
.exceptionally(e -> {
LOG.warn("Failed to complete transaction cleanup command
[txId=" + transactionId + ']', e);
- return nullCompletedFuture();
+ ExceptionUtils.sneakyThrow(e);
Review Comment:
Probably because the exception is lost if not re-thrown here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
