ascherbakoff commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1896737952
##########
modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java:
##########
@@ -17,10 +17,27 @@
package org.apache.ignite.internal.raft;
+import org.apache.ignite.internal.hlc.HybridTimestamp;
import org.apache.ignite.internal.network.NetworkMessage;
+import org.jetbrains.annotations.Nullable;
/**
* A marker interface for replication group command.
*/
public interface Command extends NetworkMessage {
+ /**
+ * This is called before a command is submitted to replication pipeline.
+ *
+ * @param safeTs Safe timestamp.
+ */
+ default void patch(HybridTimestamp safeTs) {}
+
+ /**
+ * Holds request's initiator timestamp.
+ *
+ * @return The timestamp.
+ */
+ default @Nullable HybridTimestamp initiatorTime() {
Review Comment:
1. No. I've moved initiatorTime to WriteCommand.
2. It's valid. It can be null for CMG for example and any other group not
requring mvcc extensions.
So it's not possible to remove @nullable.
Correctness is ensured by SafeTimestampPropagatingCommand, where this
annotation is removed, so it's not possible to create
SafeTimestampPropagatingCommand without initialTime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
