Patches 1,3,4
Reviewed-by: Tapani Pälli
On 07/27/2015 04:22 PM, Marta Lofstedt wrote:
From: Marta Lofstedt
Signed-off-by: Marta Lofstedt
---
src/mesa/main/get.c | 6 ++
src/mesa/main/get_hash_params.py | 17 +++--
2 files changed, 17 insertions(+), 6
Change function to get all gl_constants for inspection, this is used
by follow-up patch.
v2: rebase, update function documentation
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/src/glsl
Same check is made for glBindFragDataLocationIndexed but it was missing
when using layout qualifiers.
Fixes following Piglit test:
arb_blend_func_extended-output-location
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 19 +++
1 file changed, 19 insertions
Reviewed-by: Tapani Pälli
On 07/29/2015 02:48 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_blit.c | 6 +++---
src/mesa/drivers/dri/i915/i915_texstate.c | 2 +-
src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 2
Reviewed-by: Tapani Pälli
On 07/29/2015 02:45 AM, Anuj Phogat wrote:
brw_cs.cpp:386:27: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_cs.cpp | 2 +-
1 file changed, 1 insertion(+), 1
Reviewed-by: Tapani Pälli
On 07/29/2015 04:48 AM, Kenneth Graunke wrote:
Other stages can be miserably slow too!
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_shader.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965
I had sightly different fix for this but on same lines;
Reviewed-by: Tapani Pälli
On 07/29/2015 04:56 PM, Timothy Arceri wrote:
This fixes the remaining failing tests in:
ES31-CTS.program_interface_query.uniform-types
Reviewed-by: Samuel Iglesias Gonsálvez
---
src/glsl/linker.cpp | 16
niform_location() removal into their own patch.
Cc: Tapani Pälli
---
src/mesa/main/program_resource.c | 14 ++--
src/mesa/main/shader_query.cpp | 174 +--
src/mesa/main/shaderapi.c| 2 +-
src/mesa/main/shaderapi.h| 3 +-
src/mesa/main/u
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I have a 1 line fix to
valid_program_resource_index_name() that together with your patch
"glsl: set stag
On 07/30/2015 08:50 AM, Timothy Arceri wrote:
On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli" wrote:
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
currently going through failing PIQ tests and I ha
Hi;
This together with Timothy's "set stage flag for structs and arrays
in resource list" fixes following failing conformance test:
ES31-CTS.program_interface_query.uniform-types
Tapani Pälli (1):
mesa: support arrays of structures in GetProgramResourceIndex
This fixes a lot of failing tests in:
ES31-CTS.program_interface_query.uniform-types
Signed-off-by: Tapani Pälli
---
src/mesa/main/program_resource.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c
On 07/30/2015 08:56 AM, Tapani Pälli wrote:
On 07/30/2015 08:50 AM, Timothy Arceri wrote:
On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli"
wrote:
On 07/30/2015 08:25 AM, Tapani Pälli wrote:
Hi Timothy;
Would it be OK for you to wait a bit with these 3 first patches? I'm
On 07/30/2015 12:48 PM, Timothy Arceri wrote:
On Thu, 2015-07-30 at 19:40 +1000, Timothy Arceri wrote:
On Thu, 2015-07-30 at 09:44 +0300, Tapani Pälli wrote:
This fixes a lot of failing tests in:
ES31-CTS.program_interface_query.uniform-types
Signed-off-by: Tapani Pälli
---
src/mesa
patches 1,2,3
and patches for AoA size calculation 11,12,16
Reviewed-by: Tapani Pälli
(will review some more later)
On 07/29/2015 04:56 PM, Timothy Arceri wrote:
If useful the series is in the 'gles8' branch of the repo here:
https://github.com/tarceri/Mesa_arrays_of_arrays.git
On 07/30/2015 12:26 PM, Timothy Arceri wrote:
On Thu, 2015-07-30 at 11:07 +0300, Tapani Pälli wrote:
On 07/30/2015 08:56 AM, Tapani Pälli wrote:
On 07/30/2015 08:50 AM, Timothy Arceri wrote:
On 30 July 2015 3:27:41 pm AEST, "Tapani Pälli"
wrote:
On 07/30/2015 08:25 AM, Tapani P
On 07/14/2015 10:46 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez
Including TOP_LEVEL_ARRAY_SIZE and TOP_LEVEL_ARRAY_STRIDE queries.
Signed-off-by: Samuel Iglesias Gonsalvez
---
src/glsl/ir_uniform.h| 5 +
src/glsl/link_uniforms.cpp | 17 ++-
src/glsl
On 07/24/2015 08:30 AM, Samuel Iglesias Gonsálvez wrote:
On 23/07/15 08:42, Samuel Iglesias Gonsalvez wrote:
v2:
- Add tessellation shader constants support
Signed-off-by: Samuel Iglesias Gonsalvez
---
src/mesa/main/get.c | 1 +
src/mesa/main/get_hash_params.py | 14 +++
On 07/31/2015 10:31 AM, Samuel Iglesias Gonsálvez wrote:
On Fri, 2015-07-31 at 09:26 +0300, Tapani Pälli wrote:
On 07/24/2015 08:30 AM, Samuel Iglesias Gonsálvez wrote:
On 23/07/15 08:42, Samuel Iglesias Gonsalvez wrote:
v2:
- Add tessellation shader constants support
Signed-off-by
I've gone through this set (and using them regularly to be able to run
3.1es conformance tests);
Patches 1,2,3,4,5,7,8
Reviewed-by: Tapani Pälli
I believe with 6 and 9 there are changes required.
On 05/11/2015 04:03 PM, Marta Löfstedt wrote:
From: Marta Lofstedt
Signed-off-by:
-locations
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index a16dab4..e2da0af 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -3110,7 +3110,8
Fixes rest of the failures with
ES31-CTS.program_interface_query.no-locations
Signed-off-by: Tapani Pälli
---
src/mesa/main/shader_query.cpp | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp
index
Reviewed-by: Tapani Pälli
On 08/02/2015 04:47 AM, Timothy Arceri wrote:
parse_program_resource_name returns -1 when the index is invalid this needs to
be tested before assigning the value to the unsigned array_index.
In link_varyings.cpp (the other place parse_program_resource_name is used
Sorry, this is not right, forget about this patch :/
On 08/03/2015 09:02 AM, Tapani Pälli wrote:
Fixes rest of the failures with
ES31-CTS.program_interface_query.no-locations
Signed-off-by: Tapani Pälli
---
src/mesa/main/shader_query.cpp | 7 +--
1 file changed, 5 insertions(+), 2
Fixes rest of the failures with
ES31-CTS.program_interface_query.no-locations
v2: make additional check only for GS inputs
Signed-off-by: Tapani Pälli
---
src/mesa/main/shader_query.cpp | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main
_mesa_get_program_resource_name has logic to append '[0]' in name
if variable is an array, this should be skipped for XFB varyings
that have array index already appended.
Fixes:
ES31-CTS.program_interface_query.transform-feedback-types
Signed-off-by: Tapani Pälli
---
src
Reviewed-by: Tapani Pälli
On 08/02/2015 08:04 AM, Timothy Arceri wrote:
The only values allowed are 0 and 1, and the value is checked before
assigning.
This is a copy of 8eeca7a56c that seems to have been made to the glsl
ir type after it was copied for use in nir but before nir landed
On 08/03/2015 01:48 PM, Martin Peres wrote:
On 03/08/15 11:10, Tapani Pälli wrote:
_mesa_get_program_resource_name has logic to append '[0]' in name
if variable is an array, this should be skipped for XFB varyings
that have array index already appended.
Fixes
On 08/03/2015 01:57 PM, Martin Peres wrote:
On 03/08/15 13:50, Tapani Pälli wrote:
On 08/03/2015 01:48 PM, Martin Peres wrote:
On 03/08/15 11:10, Tapani Pälli wrote:
_mesa_get_program_resource_name has logic to append '[0]' in name
if variable is an array, this should be skipp
On 08/04/2015 01:27 AM, Timothy Arceri wrote:
On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote:
On Mon, 2015-08-03 at 09:02 +0300, Tapani Pälli wrote:
Currently stage reference mask is built using the variable name
only. However it can happen that input of one stage has same name
as
On 07/31/2015 12:37 PM, Samuel Iglesias Gonsálvez wrote:
On Fri, 2015-07-31 at 09:32 +0200, Samuel Iglesias Gonsálvez wrote:
On Fri, 2015-07-31 at 09:09 +0300, Tapani Pälli wrote:
On 07/14/2015 10:46 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez
Including
On 08/03/2015 02:47 PM, Martin Peres wrote:
On 03/08/15 14:35, Tapani Pälli wrote:
On 08/03/2015 01:57 PM, Martin Peres wrote:
On 03/08/15 13:50, Tapani Pälli wrote:
On 08/03/2015 01:48 PM, Martin Peres wrote:
On 03/08/15 11:10, Tapani Pälli wrote:
_mesa_get_program_resource_name
s:
ES31-CTS.program_interface_query.transform-feedback-types
Signed-off-by: Tapani Pälli
Reviewed-by: Martin Peres
---
src/mesa/main/shader_query.cpp | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp
index a85e4c4..ee73
Original purpose of these lines was to be more friendly against
GUI tools using the extension. However conformance suite explicitly
checks that buffers are not modified in error conditions.
Fixes:
ES31-CTS.program_interface_query.buff-length
Signed-off-by: Tapani Pälli
---
src/mesa/main
Hi;
I've tried to understand more about AoA to review the linker changes.
Now I'm testing your patches (and taking currently closer look at 9/20).
Overall it looks fine, calling itself recursively for each array level.
However, with fs-initializer-const-index.shader_test it seems to set
bindi
On 08/05/2015 09:01 AM, Timothy Arceri wrote:
On Tue, 2015-08-04 at 21:20 +1000, Timothy Arceri wrote:
On Tue, 2015-08-04 at 08:24 +0300, Tapani Pälli wrote:
On 08/04/2015 01:27 AM, Timothy Arceri wrote:
On Mon, 2015-08-03 at 23:16 +1000, Timothy Arceri wrote:
On Mon, 2015-08-03 at 09:02
On 08/04/2015 05:10 PM, Timothy Arceri wrote:
On Tue, 2015-08-04 at 14:54 +0300, Tapani Pälli wrote:
Hi;
I've tried to understand more about AoA to review the linker changes.
Now I'm testing your patches (and taking currently closer look at 9/20).
Overall it looks fine, call
Reviewed-by: Tapani Pälli
On 08/05/2015 11:30 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez
v2:
- Add tessellation shader constants support
v3:
- Add GLES 3.1 support.
Signed-off-by: Samuel Iglesias Gonsalvez
---
src/mesa/main/get.c | 7 +++
src/mesa
Reviewed-by: Tapani Pälli
On 08/05/2015 11:30 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez
Signed-off-by: Samuel Iglesias Gonsalvez
---
src/glsl/glsl_parser_extras.cpp | 1 +
src/glsl/glsl_parser_extras.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff
Reviewed-by: Tapani Pälli
On 08/05/2015 11:30 AM, Iago Toral Quiroga wrote:
From: Samuel Iglesias Gonsalvez
According to ARB_uniform_buffer_object spec:
"If the parameter (starting offset or size) was not specified when the
buffer object was bound (e.g. if bound with BindBufferBase
Reviewed-by: Tapani Pälli
On 08/05/2015 04:13 PM, Timothy Arceri wrote:
Stage ref cannot be queried for transform feedback.
Also simplify the build_stageref function by passing the
correct mode for uniforms.
Cc: Tapani Pälli
---
No piglit regressions, no program_interface_query CTS
On 07/31/2015 04:18 PM, Lofstedt, Marta wrote:
Thanks Tapani,
However,
For patch 9 there is a V3 for which I can't see any new objections:
http://patchwork.freedesktop.org/patch/51879/
This looks good to me.
If you have any new ones could you please clarify.
My interpretation o
Super, I've verified that this makes
ES31-CTS.shader_image_load_store.basic-api-barrier-byRegion pass with
one of Curro's branches.
Reviewed-by: Tapani Pälli
On 08/04/2015 11:22 AM, Marta Lofstedt wrote:
From: Marta Lofstedt
Signed-off-by: Marta Lofstedt
---
src/mapi
This is done so that following patch can use it to verify dimenstions
for multisample variants of glTex*Storage.
Signed-off-by: Tapani Pälli
---
src/mesa/main/texstorage.c | 22 +-
src/mesa/main/texstorage.h | 3 +++
2 files changed, 24 insertions(+), 1 deletion(-)
diff
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 3ea7b2a..c6fd0be 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -5639,9
,
sorry if I did!
Thanks;
Tapani Pälli (4):
mesa: expose dimension check for glTex*Storage functions
mesa: validate size parameters for glTexStorage*Multisample
mesa: set correct error for non-renderable multisample textures
mesa: allow multisampled integer texture formats for ES 3.1
src
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 28
1 file changed, 28 insertions(+)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index fc69387..3ea7b2a 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -5782,6
Signed-off-by: Tapani Pälli
---
src/mesa/main/multisample.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c
index 490bad5..aac5a15 100644
--- a/src/mesa/main/multisample.c
+++ b/src/mesa/main/multisample.c
On 08/10/2015 12:04 PM, Timothy Arceri wrote:
On Mon, 2015-08-10 at 11:06 +0300, Tapani Pälli wrote:
This is done so that following patch can use it to verify dimenstions
for multisample variants of glTex*Storage.
Signed-off-by: Tapani Pälli
---
src/mesa/main/texstorage.c | 22
On 08/10/2015 11:06 AM, Tapani Pälli wrote:
Hello;
Here's bunch of changes to texture storage. I have a branch to enable
GL_OES_texture_storage_multisample_2d_array and I extracted changes not
directly related to extension itself and I see generic to OpenGL ES 3.1.
Hopefully I ha
item and is going to finish it soon?
However if others don't mind then I guess it's ok. Extension list looks
correct for me, for the series:
Reviewed-by: Tapani Pälli
+
+
Additional functions not covered above:
glMemoryBarrierByRegion
glGetTexLevelParameter[fi]v -
Reviewed-by: Tapani Pälli
On 08/12/2015 03:09 AM, Nanley Chery wrote:
From: Nanley Chery
This function would always report that a dimension or size error occurred
in glTexImage even when it was called from glCompressedTexImage. Replace
the static string with the dynamically determined caller
Hi Ilia;
Some comments below;
On 08/12/2015 04:51 AM, Ilia Mirkin wrote:
---
src/glsl/builtin_functions.cpp | 32 +-
src/glsl/glcpp/glcpp-parse.y | 3 +++
src/glsl/glsl_parser_extras.cpp| 1 +
src/glsl/glsl_parser_extras.h
Extension spec originally required 2^24 but 2^27 is the minimum value
required by OpenGL 4.5 and OpenGL ES 3.1 specifications.
Fixes:
ES31-CTS.shader_storage_buffer_object.basic-max
Signed-off-by: Tapani Pälli
---
src/mesa/main/context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 08/12/2015 03:00 PM, Ilia Mirkin wrote:
On Wed, Aug 12, 2015 at 2:34 AM, Tapani Pälli wrote:
Hi Ilia;
Some comments below;
On 08/12/2015 04:51 AM, Ilia Mirkin wrote:
---
src/glsl/builtin_functions.cpp | 32
+-
src/glsl/glcpp/glcpp-parse.y
On 08/10/2015 07:50 PM, Brian Paul wrote:
On 08/10/2015 02:06 AM, Tapani Pälli wrote:
This is done so that following patch can use it to verify dimenstions
for multisample variants of glTex*Storage.
Signed-off-by: Tapani Pälli
---
src/mesa/main/texstorage.c | 22
Reviewed-by: Tapani Palli
On 08/10/2015 07:31 PM, Neil Roberts wrote:
Since 4d7e0fa8c731776 this file is generated by the configure script.
---
src/gallium/targets/opencl/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 src/gallium/targets/opencl/.gitignore
diff --git
This is done so that following patch can use it to verify dimensions
for multisample variants of glTex*Storage.
v2: move function to header, use bool instead GLboolean
Signed-off-by: Tapani Pälli
---
src/mesa/main/texstorage.c | 2 +-
src/mesa/main/texstorage.h | 21 +
2
Here's bunch of changes to texture storage with the fixes from review.
Thanks;
Tapani Pälli (3):
mesa: expose dimension check for glTex*Storage functions
mesa: validate size parameters for glTexStorage*Multisample
mesa: set correct error for non-renderable multisample textures
src
v2: same common error on gles31 and desktop OpenGL
(spotted by Erik Faye-Lund)
Signed-off-by: Marta Lofstedt
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main
v2: code cleanup
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index d35dc12..add7438 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
Hi;
I believe something more needs to be done here, it may be generic
changes to the memory qualifier parsing. I wrote a Piglit test that
fails with these changes (I tested against
itoral-ARB_shader_storage_buffer_object-v4.1 branch), here:
http://lists.freedesktop.org/archives/piglit/2015-A
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I notice when reviewing this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
v2: code cleanup
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 24
1
On 08/13/2015 12:14 PM, Tapani Pälli wrote:
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I notice when reviewing this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
v2: code cleanup
Signed-off-by: Tapani Pälli
---
src/mesa
Reviewed-by: Tapani Pälli
On 08/13/2015 11:53 AM, Timothy Arceri wrote:
---
src/mesa/main/teximage.c | 2 +-
src/mesa/main/teximage.h | 9 -
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index fc69387..55cbb37
created already with a proper target value.
Fixes failures in:
ES31-CTS.texture_storage_multisample.APIGLGetTexLevelParameterifv.*
Signed-off-by: Tapani Pälli
---
src/mesa/main/texparam.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/src/mesa
On 08/13/2015 02:51 PM, Timothy Arceri wrote:
On Thu, 2015-08-13 at 14:05 +0300, Tapani Pälli wrote:
With non-dsa functions we need to do target error checking before
_mesa_get_current_tex_object which would just call _mesa_problem without
raising GL_INVALID_ENUM error. In other places of
On 08/13/2015 03:47 PM, Timothy Arceri wrote:
On Thu, 2015-08-13 at 15:01 +0300, Tapani Pälli wrote:
On 08/13/2015 02:51 PM, Timothy Arceri wrote:
On Thu, 2015-08-13 at 14:05 +0300, Tapani Pälli wrote:
With non-dsa functions we need to do target error checking before
-CTS.texture_storage_multisample.APIGLGetTexLevelParameterifv.*
v2: do the check also for dsa functions (Timothy)
Signed-off-by: Tapani Pälli
---
src/mesa/main/texparam.c | 32 +---
1 file changed, 25 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c
index
On 08/07/2015 12:56 PM, Tapani Pälli wrote:
Super, I've verified that this makes
ES31-CTS.shader_image_load_store.basic-api-barrier-byRegion pass with
one of Curro's branches.
Reviewed-by: Tapani Pälli
Urgh should've tested this before but now I noticed that 'make c
On 08/14/2015 08:21 AM, Tapani Pälli wrote:
On 08/07/2015 12:56 PM, Tapani Pälli wrote:
Super, I've verified that this makes
ES31-CTS.shader_image_load_store.basic-api-barrier-byRegion pass with
one of Curro's branches.
Reviewed-by: Tapani Pälli
Urgh should've tested this
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I notice when reviewing this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
v2: code cleanup
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 24
1
Signed-off-by: Tapani Pälli
---
src/glsl/builtin_types.cpp | 6 +++---
src/glsl/glsl_lexer.ll | 7 ---
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/glsl/builtin_types.cpp b/src/glsl/builtin_types.cpp
index ffbc5e6..b0156a1 100644
--- a/src/glsl/builtin_types.cpp
Reviewed-by: Tapani Pälli
On 08/14/2015 02:30 PM, Marta Lofstedt wrote:
From: Marta Lofstedt
The function glMemoryBarrierByRegion is part of
OpenGL ES 3.1 and OpenGL 4.5 core and compatibility
profiles.
Signed-off-by: Marta Lofstedt
---
src/mapi/glapi/gen/GL4x.xml | 6
On 08/14/2015 04:01 PM, Timothy Arceri wrote:
On Fri, 2015-08-14 at 08:55 +0300, Tapani Pälli wrote:
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I notice when reviewing
this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
v2: code cl
Patch separates array samplers from the texture_multisample check so that we
can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported.
Signed-off-by: Tapani Pälli
---
src/glsl/builtin_functions.cpp | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff
On 08/17/2015 01:58 PM, Timothy Arceri wrote:
On Mon, 2015-08-17 at 12:25 +0300, Tapani Pälli wrote:
Patch separates array samplers from the texture_multisample check so that we
can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported.
Signed-off-by: Tapani Pälli
---
src
Reviewed-by: Tapani Pälli
On 08/17/2015 07:45 PM, Francisco Jerez wrote:
---
src/mesa/main/shaderimage.c | 67 +++--
1 file changed, 65 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c
index 67f1716
with image unit state other
than the texture object in that case -- In any case it shouldn't make
FWIW this seems to be specified in the desktop GL (and ES 3.1) spec in
section "Automatic Unbinding of Deleted Objects".
Reviewed-by: Tapani Pälli
any practical difference bec
I find it strange that 7.10 Images does not mention this difference to
desktop GL (when mentioning that locations can be queried with
GetUniformLocation), one can only learn this by checking that all
references to 'image' have been removed from the Uniform* calls.
Reviewed-by: Ta
patches 14,15,16:
Reviewed-by: Tapani Pälli
On 08/17/2015 07:45 PM, Francisco Jerez wrote:
---
src/glsl/builtin_functions.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
index 482cae2..c53858e 100644
On 08/18/2015 12:30 AM, Timothy Arceri wrote:
On Mon, 2015-08-17 at 08:12 +0300, Tapani Pälli wrote:
On 08/14/2015 04:01 PM, Timothy Arceri wrote:
On Fri, 2015-08-14 at 08:55 +0300, Tapani Pälli wrote:
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up pa
Patch refactors existing parameters check to first check common enums
between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image
to be compatible with enums specified in 3.1.
Signed-off-by: Tapani Pälli
---
src/mesa/main/texparam.c | 34 +++---
1 file
On 08/18/2015 11:11 AM, Timothy Arceri wrote:
On Tue, 2015-08-18 at 10:16 +0300, Tapani Pälli wrote:
On 08/18/2015 12:30 AM, Timothy Arceri wrote:
On Mon, 2015-08-17 at 08:12 +0300, Tapani Pälli wrote:
On 08/14/2015 04:01 PM, Timothy Arceri wrote:
On Fri, 2015-08-14 at 08:55 +0300
patches 17,18,19,20:
Reviewed-by: Tapani Pälli
On 08/17/2015 07:45 PM, Francisco Jerez wrote:
These seem to have been re-added at some point during the
ARB_tessellation_shader implementation work. AFAICT the second
(correct) definition of each constant would have had no effect because
the
Reviewed-by: Tapani Palli
On 08/19/2015 02:50 PM, Francisco Jerez wrote:
I'll mark the OES_shader_image_atomic extension entry with this tag to
make sure that we don't expose it on earlier GLES API versions
accidentally, because according to the extension:
"OpenGL ES 3.1 a
Patches 11,12,13:
Reviewed-by: Tapani Pälli
On 08/17/2015 07:45 PM, Francisco Jerez wrote:
---
src/glsl/ast_to_hir.cpp | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 4d279f6..ff57ec3 100644
--- a/src/glsl
We have to re-validate FBOs rendering to the texture like is done
with TexImage and CopyTexImage.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91673
Cc: "10.6"
---
src/mesa/main/texstorage.c | 15 +++
1 file changed, 15 insertion
ely equivalent to
ARB_shader_image_load_store but with the additional atomic built-in
required for OES_shader_image_atomic support.
I vote for keeping the boolean, this is part of ES32 and extension on
3.1, I think we might have some more of similar cases when enabling 32.
Reviewed-by: Tapani Pal
On 08/21/2015 02:20 AM, Anuj Phogat wrote:
On Thu, Aug 20, 2015 at 12:52 AM, Tapani Pälli wrote:
We have to re-validate FBOs rendering to the texture like is done
with TexImage and CopyTexImage.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91673
Cc
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index 4365b71..3a47b85 100644
--- a/src/mesa/drivers/dri/i965
Signed-off-by: Tapani Pälli
---
src/mesa/main/extensions.c | 1 +
src/mesa/main/mtypes.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 4a3c231..d3f43cc 100644
--- a/src/mesa/main/extensions.c
+++ b/src/mesa/main
Patch refactors existing parameters check to first check common enums
between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image
to be compatible with enums specified in 3.1.
Signed-off-by: Tapani Pälli
---
src/mesa/main/texparam.c | 34 +++---
1 file
Signed-off-by: Tapani Pälli
---
src/mapi/glapi/gen/es_EXT.xml | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/mapi/glapi/gen/es_EXT.xml b/src/mapi/glapi/gen/es_EXT.xml
index 642e3b3..cfca5a9 100644
--- a/src/mapi/glapi/gen/es_EXT.xml
+++ b/src/mapi/glapi/gen
Patch adds extension enable bit and enables required keywords
and builtin functions for the extension.
Signed-off-by: Tapani Pälli
---
src/glsl/builtin_functions.cpp | 5 +++--
src/glsl/builtin_types.cpp | 3 ++-
src/glsl/glcpp/glcpp-parse.y| 2 ++
src/glsl/glsl_lexer.ll | 6
base patches on top of that cleanup.
Thanks;
Tapani Pälli (6):
mesa: GetTexLevelParameter{if}v changes for OpenGL ES 3.1
glapi: add GL_OES_texture_storage_multisample_2d_array extension
mesa: Add extension enable for
OES_texture_storage_multisample_2d_array
glsl: add suppor
Signed-off-by: Tapani Pälli
---
src/mesa/main/get_hash_params.py | 6 +++---
src/mesa/main/texobj.c | 6 --
src/mesa/main/texparam.c | 2 +-
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
suggestions or opinions appreciated!
Thanks;
Tapani Pälli (1):
mesa: debug facility to replace shaders when running apps
src/glsl/glsl_parser_extras.cpp | 76 +
src/mesa/main/mtypes.h | 2 +-
2 files changed, 77 insertions(+), 1 deletion(-)
--
2.4.3
MESA_SHADER_READ - path where replacement shaders are read
Signed-off-by: Tapani Pälli
Suggested-by: Eero Tamminen
---
src/glsl/glsl_parser_extras.cpp | 76 +
src/mesa/main/mtypes.h | 2 +-
2 files changed, 77 insertions(+), 1 deletion(-)
diff --git a/src
On 08/21/2015 05:14 PM, Ilia Mirkin wrote:
On Fri, Aug 21, 2015 at 3:22 AM, Tapani Pälli wrote:
Patch refactors existing parameters check to first check common enums
between desktop GL and GLES 3.1 and modifies get_tex_level_parameter_image
to be compatible with enums specified in 3.1
201 - 300 of 2200 matches
Mail list logo
