Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: > In some cases, we need to emit ALU instructions with a certain stride > due to a HW limitation. When splitting that instruction, we need to > respect the original stride when creating the temporaries we load from > and store into. Oth

Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

On Mon, Aug 17, 2015 at 10:09:21AM +0300, Pohjolainen, Topi wrote: > On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: > > In some cases, we need to emit ALU instructions with a certain stride > > due to a HW limitation. When splitting that instruction, we need to > > respect the origi

[Mesa-dev] [Bug 91646] dlopen'ing libudev.so.1 from static library initializer corrupts TLS state

https://bugs.freedesktop.org/show_bug.cgi?id=91646 Eero Tamminen changed: What|Removed |Added CC||eero.t.tammi...@intel.com -- You are re

[Mesa-dev] [Bug 91646] dlopen'ing libudev.so.1 from static library initializer corrupts TLS state

https://bugs.freedesktop.org/show_bug.cgi?id=91646 --- Comment #7 from Eero Tamminen --- latrace tool could tell something useful: http://people.redhat.com/jolsa/latrace/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. __

Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi wrote: > On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: >> In some cases, we need to emit ALU instructions with a certain stride >> due to a HW limitation. When splitting that instruction, we need to >> respect the original stride

Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

On Mon, Aug 17, 2015 at 1:27 AM, Connor Abbott wrote: > On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi > wrote: >> On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: >>> In some cases, we need to emit ALU instructions with a certain stride >>> due to a HW limitation. When splitti

[Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

Patch separates array samplers from the texture_multisample check so that we can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported. Signed-off-by: Tapani Pälli --- src/glsl/builtin_functions.cpp | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --

Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

Connor Abbott writes: > On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi > wrote: >> On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: >>> In some cases, we need to emit ALU instructions with a certain stride >>> due to a HW limitation. When splitting that instruction, we need to

Re: [Mesa-dev] [PATCH] [RFC] mesa/st: create a front buffer renderbuffer

Gallium does create the front buffer (with DRI2 at least), but it's created only when it's used. glDrawBuffer(GL_FRONT) creates it usually. Marek On Mon, Aug 17, 2015 at 5:23 AM, Dave Airlie wrote: > From: Dave Airlie > > It appears CTS does a lot of > > glGetFrameBufferAttachmentParameteriv wi

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

https://bugs.freedesktop.org/show_bug.cgi?id=90346 --- Comment #3 from Tapani Pälli --- Seems like this is fixed now? I could not reproduce using current Mesa (1af0641) and configuring like done in comment #2. -- You are receiving this mail because: You are the QA Contact for the bug. _

[Mesa-dev] [PATCH v2 0/2] mesa: Use the effective internal format instead for validation

Hi, This is a new version of the patch that accounts for extensions that allow new combinations of format, type and internal format; where the internal format is in base (unsized) form. I also moved the check to glformats's _mesa_es3_error_check_format_and_type(), because this is really part of t

[Mesa-dev] [PATCH v2 2/2] mesa: Use the effective internal format instead for validation

When validating format+type+internalFormat for texture pixel operations on GLES3, the effective internal format should be used if the one specified is an unsized internal format. Page 127, section "3.8 Texturing" of the GLES 3.0.4 spec says: "if internalformat is a base internal format, the ef

[Mesa-dev] [PATCH v2 1/2] mesa: Move _mesa_base_tex_format() from teximage to glformats files

This function will be needed as part of validating the combination of format, type and internal format of texture pixel operations, which happens in glformats files. Specifically, we want to be able to obtain the base format of a resolved effective internal format, to compare it with the original i

Re: [Mesa-dev] [PATCH v2 2/2] mesa: Use the effective internal format instead for validation

On 08/17/2015 12:35 PM, Eduardo Lima Mitev wrote: > > + if (error_check_subtexture_dimensions(ctx, dimensions, > + texImage, xoffset, yoffset, zoffset, > + width, height, depth, callerName)) { > + return GL_TRU

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

On Mon, 2015-08-17 at 12:25 +0300, Tapani Pälli wrote: > Patch separates array samplers from the texture_multisample check so that we > can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported. > > Signed-off-by: Tapani Pälli > --- > src/glsl/builtin_functions.cpp | 19 +++

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

On 08/17/2015 01:58 PM, Timothy Arceri wrote: On Mon, 2015-08-17 at 12:25 +0300, Tapani Pälli wrote: Patch separates array samplers from the texture_multisample check so that we can enable only [iu]sampler2DMS, [iu]sampler2DMSArray are not supported. Signed-off-by: Tapani Pälli --- src/gls

[Mesa-dev] [PATCH 1/2] mesa: check samples > 0 for glTex*Multisample

The GL 4.5 spec says its an GL_INVALID_VALUE error if samples equals 0 for glTexImage*Multisample and an GL_INVALID_VALUE error if samples < 1 for glTexStorage*Multisample. The spec says its undefined what happens if glTexImage*Multisample is passed a samples value < 0 but we currently already pro

[Mesa-dev] [PATCH 2/2] mesa: move non-generic samples validation

The previous patch replaces the other use case. V2: remove the validation from it old location. Cc: Tapani Pälli --- src/mesa/main/fbobject.c| 10 ++ src/mesa/main/multisample.c | 9 - 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/fbobject.c

Re: [Mesa-dev] [PATCH] glsl: enable textureSize and texelFetch on GLSL ES 3.10 with MS samplers

On Mon, 2015-08-17 at 14:23 +0300, Tapani Pälli wrote: > > On 08/17/2015 01:58 PM, Timothy Arceri wrote: > > On Mon, 2015-08-17 at 12:25 +0300, Tapani Pälli wrote: > > > Patch separates array samplers from the texture_multisample check so > > > that we > > > can enable only [iu]sampler2DMS, [iu]s

Re: [Mesa-dev] [RFC 2/2] i965: add support for image AoA

On Sun, 2015-08-16 at 13:15 +0300, Francisco Jerez wrote: > Timothy Arceri writes: > > > On Sat, 2015-08-15 at 17:33 +0300, Francisco Jerez wrote: > > > Timothy Arceri writes: > > > > > > > On Wed, 2015-08-12 at 19:39 +1000, Timothy Arceri wrote: > > > > > Cc: Francisco Jerez > > > > > --- > >

Re: [Mesa-dev] [RFC 2/2] i965: add support for image AoA

Timothy Arceri writes: > On Sun, 2015-08-16 at 13:15 +0300, Francisco Jerez wrote: >> Timothy Arceri writes: >> >> > On Sat, 2015-08-15 at 17:33 +0300, Francisco Jerez wrote: >> > > Timothy Arceri writes: >> > > >> > > > On Wed, 2015-08-12 at 19:39 +1000, Timothy Arceri wrote: >> > > > > Cc:

Re: [Mesa-dev] Mesa 11.0.0 release plan

On 17 August 2015 at 01:24, Rob Clark wrote: > On Tue, Aug 11, 2015 at 1:45 PM, Emil Velikov > wrote: >> On 29/07/15 19:20, Emil Velikov wrote: >>> Hi all, >>> >>> Below is the preliminary release schedule for Mesa 11.0.0 >>> >>> August 21st 2015 - Feature freeze/Release candidate 1 >>> August 2

Re: [Mesa-dev] [PATCH 1/2][RFC] docs: Update with GLES3.2 entries and status

On 08/11/2015 10:48 AM, Thomas Helland wrote: > Signed-off-by: Thomas Helland > --- > These are listed to the best of my knowledge, looking > at the nvidia driver dropped yesterday, and a glance at the > "what changed according to the ARB variant" > section of each extension spec. Hopefully it sho

[Mesa-dev] [PATCH 01/25] mesa: Rename MaxCombinedImageUnitsAndFragmentOutputs to MaxCombinedShaderOutputResources.

The name of both the GLSL built-in variable and the glGetInteger param with the same value changed in GLSL ES 3.1 and GL 4.5. Its semantics also changed slightly, since the limit now also takes into account the number of SSBs in use. Switch our internal data structures to the up-to-date name. ---

[Mesa-dev] Implement GLES 3.1 image load/store and OES_shader_image_atomic.

This series implements a number of differences I've found while comparing the GLES 3.1 and desktop GL shader image APIs. Most of it is about taking into account additional restrictions for the GLES API, but there's also some new functionality (see PATCH 09 and 23). Together with Igalia's SSBO bra

[Mesa-dev] [PATCH 08/25] glsl: Forbid non-constant image array indexing in GLSL ES 3.1.

--- src/glsl/ast_array_index.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 27e84d1..ae399f0 100644 --- a/src/glsl/ast_array_index.cpp +++ b/src/glsl/ast_array_index.cpp @@ -290,6 +290,21 @@ _mesa_ast_array

[Mesa-dev] [PATCH 11/25] glsl: Implement GLSL ES restriction on images being either readonly or writeonly.

--- src/glsl/ast_to_hir.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 4d279f6..ff57ec3 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2469,6 +2469,24 @@ apply_image_qualifier_to_variable(c

[Mesa-dev] [PATCH 05/25] mesa: Initialize image unit state to different defaults in GLES.

There is no GL_R8 image format in GLES, according to the state table 20.32 of the GLES 3.1 spec the default value should be GL_R32UI. --- src/mesa/main/shaderimage.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c i

[Mesa-dev] [PATCH 04/25] mesa: Reset image unit state to the default values when a bound image is deleted.

The ES31-CTS.shader_image_load_store.basic-api-bind conformance test expects the whole image unit state to be reset when the bound texture object is deleted. The ARB_shader_image_load_store extension is rather vague regarding what should happen with image unit state other than the texture object i

[Mesa-dev] [PATCH 03/25] mesa: Reject image formats not supported by GLES.

--- src/mesa/main/shaderimage.c | 67 +++-- 1 file changed, 65 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index 67f1716..2d86931 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderima

[Mesa-dev] [PATCH 20/25] glsl: Parse the allowed image format qualifiers in GLSL ES 3.1.

This includes the minimum required desktop/ES GLSL version in the format qualifier table in anticipation of new GLSL versions extending the set of supported image formats. According to section 4.4.7 of the GLSL ES 3.1 spec: "The format layout qualifier identifiers for image variable declarations

[Mesa-dev] [PATCH 15/25] glsl: Accept supported image types in GLSL ES 3.1.

These are a subset of the image types supported by desktop GL, excluding 1D, 1D array, rectangle, buffer, cube array, 2D MS and 2D MS array texture targets. --- src/glsl/builtin_types.cpp | 24 src/glsl/glsl_lexer.ll | 24 2 files changed, 24 i

[Mesa-dev] [PATCH 16/25] glsl: Accept atomic_uint type in GLSL ES 3.1.

--- src/glsl/builtin_types.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_types.cpp b/src/glsl/builtin_types.cpp index c777f6e..9cf198f 100644 --- a/src/glsl/builtin_types.cpp +++ b/src/glsl/builtin_types.cpp @@ -253,7 +253,7 @@ const static struct builtin

[Mesa-dev] [PATCH 18/25] glsl: Define image-related built-in constants required by GLSL ES 3.1.

--- src/glsl/builtin_variables.cpp | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 4966ba3..dd7804f 100644 --- a/src/glsl/builtin_variables.cpp +++ b/src/glsl/builtin_variables.cpp @@

[Mesa-dev] [PATCH 13/25] glsl: Use a separate availability class for image atomic built-ins.

These are not part of unextended GLSL ES 3.1. --- src/glsl/builtin_functions.cpp | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 2175c66..482cae2 100644 --- a/src/glsl/bui

[Mesa-dev] [PATCH 17/25] glsl: Remove duplicate definition of gl_MaxTess*ImageUniforms built-in constants.

These seem to have been re-added at some point during the ARB_tessellation_shader implementation work. AFAICT the second (correct) definition of each constant would have had no effect because the symbols were already defined. --- src/glsl/builtin_variables.cpp | 2 -- 1 file changed, 2 deletions(

[Mesa-dev] [PATCH 12/25] glsl: Allow precision qualifiers on general opaque types.

From the GLSL ES 3.1 spec, section 4.7.3: "Any floating point, integer, opaque type declaration can have the type preceded by one of these precision qualifiers: [...] highp [...], mediump [...], lowp [...]." --- src/glsl/ast_to_hir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 delet

[Mesa-dev] [PATCH 23/25] glsl: Implement the required built-in functions when OES_shader_image_atomic is enabled.

This is basically just the same atomic functions exposed by ARB_shader_image_load_store, with one exception: "highp float imageAtomicExchange( coherent IMAGE_PARAMS, float data);" There's no float atomic exchange overload in the original ARB_shader_image_load_store or GL 4.2

[Mesa-dev] [PATCH 07/25] mesa: Refuse to bind image uniforms using glUniform in GLES.

The GLES 3.1 spec removed support for updating the image unit bound to an image uniform using glUniform1i() calls. --- src/mesa/main/uniform_query.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 0365

[Mesa-dev] [PATCH 09/25] glsl: Add support for image binding qualifiers.

Support for binding an image to an image unit explicitly in the shader source is required by both GLSL 4.2 and GLSL ES 3.1, but not by the original ARB_shader_image_load_store extension. --- src/glsl/ast_to_hir.cpp| 12 +++- src/glsl/link_uniform_initializers.cpp | 24 +

[Mesa-dev] [PATCH 02/25] mesa: Don't lose track of the shader image layer originally specified by the user.

The spec requires that all layers of the image starting from the 0-th are bound to the image unit regardless of the Layer parameter when Layered is true, so I was setting gl_image_unit::Layer to zero in that case for the convenience of the driver back-end. However the ES31-CTS.shader_image_load_st

[Mesa-dev] [PATCH 24/25] i965/fs: Return result of image atomic in a register of the expected type.

So the result is of float type if we're implementing the float overload of imageAtomicExchange. This is the only back-end change required to support OES_shader_image_atomic AFAICT. --- src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 10/25] glsl: Require that all image uniforms have a format qualifier in GLSL ES.

Note that this is slightly more permissive than the spec language requires: "Any image variable must specify a format layout qualifier." The GLSL ES spec seems really sketchy regarding format layout qualifiers on function formal parameters -- On the one hand they are required, but on the other han

[Mesa-dev] [PATCH 22/25] glsl: Add usual extension boilerplate for OES_shader_image_atomic.

--- src/glsl/glcpp/glcpp-parse.y| 2 ++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 3 files changed, 5 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index dd5ec2a..4bd4f17 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++

[Mesa-dev] [PATCH 06/25] mesa: Refuse to bind a mutable texture object to an image unit in GLES.

--- src/mesa/main/shaderimage.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index 5a3c47a..6f7d1c9 100644 --- a/src/mesa/main/shaderimage.c +++ b/src/mesa/main/shaderimage.c @@ -546,6 +546,17 @@ _mesa_BindImageTexture(G

[Mesa-dev] [PATCH 25/25] i965: Expose OES_shader_image_atomic.

--- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 0da528b..0ae24cb 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++ b/src/mesa/drivers/

[Mesa-dev] [PATCH 19/25] glsl: Recognise image memory qualifiers in GLSL ES 3.1.

--- src/glsl/glsl_lexer.ll | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index de6855f..24998c1 100644 --- a/src/glsl/glsl_lexer.ll +++ b/src/glsl/glsl_lexer.ll @@ -406,11 +406,11 @@ image2DShadow KEYWORD(13

[Mesa-dev] [PATCH 14/25] glsl: Expose image load and store built-ins in GLSL ES 3.1.

--- src/glsl/builtin_functions.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 482cae2..c53858e 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cpp @@ -394,7 +394,7 @@ shader_

[Mesa-dev] [PATCH 21/25] mesa: Add extension enable and table entry for OES_shader_image_atomic.

--- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index d934d19..38c7bc8 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -319,6 +319,7 @@ static

Re: [Mesa-dev] [PATCH 09/12] i965/fs: make SIMD-splitting respect the original stride/offset

On Mon, Aug 17, 2015 at 2:41 AM, Francisco Jerez wrote: > Connor Abbott writes: > >> On Mon, Aug 17, 2015 at 12:09 AM, Pohjolainen, Topi >> wrote: >>> On Fri, Aug 14, 2015 at 03:30:18PM -0700, Connor Abbott wrote: In some cases, we need to emit ALU instructions with a certain stride du

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glsl: avoid compiler's segfault when processing operators with void arguments

On 08/10/2015 11:32 AM, Mark Janes wrote: > Should this patch be cc'd to stable branches? > > Without it, the compiler crashes on invalid inputs, instead of > generating an error. > > This patch applies cleanly to 10.5 and 10.6. I don't care too much either. I submitted the original bug repor

Re: [Mesa-dev] [PATCH 21/25] mesa: Add extension enable and table entry for OES_shader_image_atomic.

On Mon, Aug 17, 2015 at 12:46 PM, Francisco Jerez wrote: > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c > index d934d19..38c7bc8 100644 > --- a/src/mesa/main/

Re: [Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

On 08/10/2015 09:15 AM, Rob Clark wrote: > From: Rob Clark > > Punch it through mesa and gallium, plus implementation in freedreno to > serve as an example. Radeon should be able to do a similar thing with > no-op packets. Not sure about other drivers. The idea behind this extension (and the w

Re: [Mesa-dev] [PATCH 1/3] mesa: add GREMEDY_string_marker

Two comments below. On 08/10/2015 09:15 AM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/mapi/glapi/gen/GREMEDY_string_marker.xml | 18 ++ > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml| 2 +

Re: [Mesa-dev] [PATCH 23/25] glsl: Implement the required built-in functions when OES_shader_image_atomic is enabled.

On Mon, Aug 17, 2015 at 9:46 AM, Francisco Jerez wrote: > This is basically just the same atomic functions exposed by > ARB_shader_image_load_store, with one exception: > > "highp float imageAtomicExchange( > coherent IMAGE_PARAMS, > float data);" > > There's no float atomic

Re: [Mesa-dev] [PATCH 23/25] glsl: Implement the required built-in functions when OES_shader_image_atomic is enabled.

On Mon, Aug 17, 2015 at 1:14 PM, Matt Turner wrote: > On Mon, Aug 17, 2015 at 9:46 AM, Francisco Jerez > wrote: >> This is basically just the same atomic functions exposed by >> ARB_shader_image_load_store, with one exception: >> >> "highp float imageAtomicExchange( >> coherent IMAG

Re: [Mesa-dev] [PATCH 02/71] target/d3dadapter9: Return Windows like card names

Hello, Where does this mapping list come from ? Is this an official map (Vendor or Windows drivers) ? Is that used just for information ? Because many of them are not really precise, if not completely wrong at all (eg. the Radeon R400/R500 series names). Regards. -- Benjamin 2015-08-16 17:27 GM

Re: [Mesa-dev] [PATCH 1/8] i965: Change the parameters passed to intel_miptree_get_tile_masks()

On Fri, Aug 14, 2015 at 04:51:52PM -0700, Anuj Phogat wrote: > This change is required by the later patches. > > Cc: Ben Widawsky > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 ++- > src/mesa/drivers/dri/i965/brw_misc_state.c| 8 +--- > src/mesa/

Re: [Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

On Mon, Aug 17, 2015 at 1:12 PM, Ian Romanick wrote: > On 08/10/2015 09:15 AM, Rob Clark wrote: >> From: Rob Clark >> >> Punch it through mesa and gallium, plus implementation in freedreno to >> serve as an example. Radeon should be able to do a similar thing with >> no-op packets. Not sure abo

Re: [Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

On Fri 14 Aug 2015, Chris Wilson wrote: > On Thu, Aug 13, 2015 at 09:58:52PM -0700, Kenneth Graunke wrote: > > On Thursday, August 13, 2015 02:57:20 PM Martin Peres wrote: > > > On 07/08/15 23:13, Chris Wilson wrote: > > > > intel_update_winsys_renderbuffer_miptree() will release the existing > > >

Re: [Mesa-dev] [PATCH 1/8] i965: Change the parameters passed to intel_miptree_get_tile_masks()

On Sun, Aug 16, 2015 at 11:48 PM, Pohjolainen, Topi wrote: > On Fri, Aug 14, 2015 at 04:51:52PM -0700, Anuj Phogat wrote: >> This change is required by the later patches. >> >> Cc: Ben Widawsky >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 ++- >> src

Re: [Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

On Mon, Aug 17, 2015 at 2:06 PM, Rob Clark wrote: > On Mon, Aug 17, 2015 at 1:12 PM, Ian Romanick wrote: >> On 08/10/2015 09:15 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Punch it through mesa and gallium, plus implementation in freedreno to >>> serve as an example. Radeon should be able

Re: [Mesa-dev] [PATCH 1/8] i965: Change the parameters passed to intel_miptree_get_tile_masks()

On Mon, Aug 17, 2015 at 11:03 AM, Ben Widawsky wrote: > On Fri, Aug 14, 2015 at 04:51:52PM -0700, Anuj Phogat wrote: >> This change is required by the later patches. >> >> Cc: Ben Widawsky >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 ++- >> src/mesa

Re: [Mesa-dev] [PATCH 0/3] GREMEDY_string_marker support

On 08/17/2015 11:06 AM, Rob Clark wrote: > On Mon, Aug 17, 2015 at 1:12 PM, Ian Romanick wrote: >> On 08/10/2015 09:15 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Punch it through mesa and gallium, plus implementation in freedreno to >>> serve as an example. Radeon should be able to do a si

Re: [Mesa-dev] [PATCH 2/8] i965/gen9: Add code to compute yf/ys tile masks

On Fri, Aug 14, 2015 at 04:51:53PM -0700, Anuj Phogat wrote: > A later patch in this series uses it to compute tile dimensions. > > Cc: Ben Widawsky > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 ++- > src/mesa/drivers/dri/i965/brw_misc_state.c| 10

Re: [Mesa-dev] [PATCH v3] mesa: don't enable online compression for ASTC formats

On Tue 11 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > In agreement with the ASTC spec, this makes calls to TexImage*D unsuccessful. > Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D calls > must be unsuccessful as well. > > v2. actually force attempts to compress

Re: [Mesa-dev] [PATCH 05/25] mesa: Initialize image unit state to different defaults in GLES.

On 08/17/2015 09:45 AM, Francisco Jerez wrote: > There is no GL_R8 image format in GLES, according to the state table > 20.32 of the GLES 3.1 spec the default value should be GL_R32UI. Was any conformance test affected by this change? > --- > src/mesa/main/shaderimage.c | 5 +++-- > 1 file chang

Re: [Mesa-dev] [PATCH 21/25] mesa: Add extension enable and table entry for OES_shader_image_atomic.

On 08/17/2015 09:56 AM, Ilia Mirkin wrote: > On Mon, Aug 17, 2015 at 12:46 PM, Francisco Jerez > wrote: >> --- >> src/mesa/main/extensions.c | 1 + >> src/mesa/main/mtypes.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c

Re: [Mesa-dev] [PATCH 1/2] mesa/texformat: enable ASTC formats for TexStorage

On Tue 28 Jul 2015, Nanley Chery wrote: > From: Nanley Chery > > According to the spec, Tex*Storage* commands are supported if the GL > implementation has support for immutable textures. > > Signed-off-by: Nanley Chery > --- > src/mesa/main/texformat.c | 56 > +

Re: [Mesa-dev] [PATCH 21/25] mesa: Add extension enable and table entry for OES_shader_image_atomic.

On Mon, Aug 17, 2015 at 9:46 AM, Francisco Jerez wrote: > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c > index d934d19..38c7bc8 100644 > --- a/src/mesa/main/e

Re: [Mesa-dev] [PATCH 3/8] i965: Add a helper function intel_miptree_get_tile_dimensions()

On Fri, Aug 14, 2015 at 04:51:54PM -0700, Anuj Phogat wrote: > Cc: Ben Widawsky > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 67 > ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++ > 2 files changed, 50 insertions(+), 22

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

https://bugs.freedesktop.org/show_bug.cgi?id=90346 --- Comment #4 from Vinson Lee --- (In reply to Tapani Pälli from comment #3) > Seems like this is fixed now? I could not reproduce using current Mesa > (1af0641) and configuring like done in comment #2. mesa: 5af71fb5ac4dafed3ecc4b849922208cab7

Re: [Mesa-dev] [PATCH 4/8] i965: Use helper function intel_miptree_get_tile_dimensions() in surface setup

On Fri, Aug 14, 2015 at 04:51:55PM -0700, Anuj Phogat wrote: > It takes care of using the correct tile width if we later use other tiling > patterns (e.g. Yf) for aux miptree. > > Cc: Ben Widawsky > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/gen8_surface_state.c | 14 +

Re: [Mesa-dev] [PATCH v4] mesa/teximage: accept ASTC formats for 3D texture specification

On Thu 13 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > The ASTC spec was revised as follows: > >Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to >commands accepting ASTC format tokens in the New Tokens section [...]. > > Support only exists in the HDR submode: > >

Re: [Mesa-dev] [PATCH 7/8] i965: Fix {src, dst}_pitch alignment check for XY_SRC_COPY_BLT

On Fri, Aug 14, 2015 at 04:51:58PM -0700, Anuj Phogat wrote: > Current code checks the alignment restrictions only for Y tiling. > From Broadwell PRM vol 10: > > "pitch is of 512Byte granularity for Tile-X: This means the tiled-x > surface pitch can be (512, 1024, 1536, 2048...)/4 (in Dwords)."

Re: [Mesa-dev] [PATCH 1/2] mesa: check samples > 0 for glTex*Multisample

On Mon, Aug 17, 2015 at 4:53 AM, Timothy Arceri wrote: > The GL 4.5 spec says its an GL_INVALID_VALUE error if samples equals 0 for > glTexImage*Multisample and an GL_INVALID_VALUE error if samples < 1 for > glTexStorage*Multisample. > > The spec says its undefined what happens if glTexImage*Multi

Re: [Mesa-dev] [RFC 2/3] mesa: hook up DiscardTexture for InvalidateFramebuffer and friends

Rob Clark writes: > From: Rob Clark > > We can use same Driver hook for these, in addition to > DiscardFramebufferEXT() > > Signed-off-by: Rob Clark > --- > src/mesa/main/fbobject.c | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/mai

Re: [Mesa-dev] [PATCH] nir: Add a value range propagation pass

To ease review I'll try to write up a small introduction and review-guide for the pass. The special thing about the pass, and what makes it hard to grasp, is that it is an "optimistic" pass. This means that it assumes that all variables are undefined until proven otherwise. A pessimistic pass woul

Re: [Mesa-dev] [PATCH v2 2/3] mesa: validate size parameters for glTexStorage*Multisample

On Mon, 2015-08-17 at 08:12 +0300, Tapani Pälli wrote: > > On 08/14/2015 04:01 PM, Timothy Arceri wrote: > > On Fri, 2015-08-14 at 08:55 +0300, Tapani Pälli wrote: > > > > > > On 08/13/2015 11:54 AM, Timothy Arceri wrote: > > > > I've sent a couple of follow-up patches I notice when reviewing > >

Re: [Mesa-dev] [PATCH] [RFC] mesa/st: create a front buffer renderbuffer

On 17 August 2015 at 20:25, Marek Olšák wrote: > Gallium does create the front buffer (with DRI2 at least), but it's > created only when it's used. glDrawBuffer(GL_FRONT) creates it > usually. So the problem is OpenGL conformance seems to assume the front buffer will exist for querying even if it

Re: [Mesa-dev] [PATCH v2 2/3] mesa: validate size parameters for glTexStorage*Multisample

On 08/13/2015 02:28 AM, Tapani Pälli wrote: > On 08/13/2015 12:14 PM, Tapani Pälli wrote: >> On 08/13/2015 11:54 AM, Timothy Arceri wrote: >>> I've sent a couple of follow-up patches I notice when reviewing this. >>> >>> >>> On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote: v2: code clean

[Mesa-dev] [PATCH] mesa: undo split out of create shader code

This code was split out into a separate function to be used also by GL_EXT_separate_shader_objects which has since been removed from Mesa, so move it back. --- src/mesa/main/shaderapi.c | 109 +- 1 file changed, 50 insertions(+), 59 deletions(-) diff --

Re: [Mesa-dev] [PATCH] [RFC] mesa/st: create a front buffer renderbuffer

I don't see why FRONT and BACK should be any different, so this is probably okay. The Mesa front buffer thing is an optimization. There is no point in allocating the front buffer by default if almost no apps use it. Marek On Mon, Aug 17, 2015 at 11:34 PM, Dave Airlie wrote: > On 17 August 2015

Re: [Mesa-dev] [PATCH 08/25] glsl: Forbid non-constant image array indexing in GLSL ES 3.1.

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 2/3] mesa: hook up DiscardTexture for InvalidateFramebuffer and friends

On Mon, Aug 17, 2015 at 3:38 PM, Eric Anholt wrote: > Rob Clark writes: > >> From: Rob Clark >> >> We can use same Driver hook for these, in addition to >> DiscardFramebufferEXT() >> >> Signed-off-by: Rob Clark >> --- >> src/mesa/main/fbobject.c | 25 ++--- >> 1 file change

Re: [Mesa-dev] [PATCH] mesa: undo split out of create shader code

Easy enough. I probably should have done this when I removed EXT_sso. Reviewed-by: Ian Romanick On 08/17/2015 02:42 PM, Timothy Arceri wrote: > This code was split out into a separate function to be used also > by GL_EXT_separate_shader_objects which has since been removed from > Mesa, so move

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

Chris Wilson writes: > "X rendering calls made prior to glXWaitX are guaranteed to be > executed before GL rendering calls made after glXWaitX." > > The goal is to implement that without adding a round-trip to the > Xserver. Adding one using XSync() is easy, but we can piggy-back > another, the D

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace wrote: > On Tue 11 Aug 2015, Nanley Chery wrote: > > From: Nanley Chery > > > > Only uncompressed formats have a non-void type and actual components per > pixel. > > Rename _mesa_format_to_type_and_comps to > > _mesa_uncompressed_format_to_type_and_c

Re: [Mesa-dev] [PATCH 4/8] i965: Use helper function intel_miptree_get_tile_dimensions() in surface setup

On Mon, Aug 17, 2015 at 12:19 PM, Ben Widawsky wrote: > On Fri, Aug 14, 2015 at 04:51:55PM -0700, Anuj Phogat wrote: >> It takes care of using the correct tile width if we later use other tiling >> patterns (e.g. Yf) for aux miptree. >> >> Cc: Ben Widawsky >> Signed-off-by: Anuj Phogat >> --- >>

[Mesa-dev] [PATCH 1/8] nir: Pull nir_lower_io's load_op selection into a helper function.

Makes the function a bit smaller. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_lower_io.c | 39 ++- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c index 71bfd34..f3d11d4 100644 -

[Mesa-dev] [PATCH 5/8] i965/nir: Move IO lowering into helper functions.

I plan to expand these, so moving them into helper functions will keep things cleaner. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 51 ++--- 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 7/8] i965/vs: Map scalar VS input locations properly; avoid tons of MOVs.

Previously, we used nir_lower_io with the scalar type_size function, which mapped VERT_ATTRIB_* locations to...some numbers. Then, in fs_visitor::nir_setup_inputs(), we created temporaries indexed by those numbers, and emitted MOVs from the actual ATTR registers to those temporaries. This patch r

[Mesa-dev] [PATCH 6/8] nir: Allow nir_lower_io() to only lower one type of variable.

We may want to use different type_size functions for (e.g.) inputs vs. uniforms. Passing in -1 for mode ignores this, handling all modes as before. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir.h | 1 + src/glsl/nir/nir_lower_io.c | 21 + src/

[Mesa-dev] [PATCH 2/8] nir: Use nir_builder in nir_lower_io's get_io_offset().

Much more readable. Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_lower_io.c | 42 ++ 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/src/glsl/nir/nir_lower_io.c b/src/glsl/nir/nir_lower_io.c index f3d11d4..d33aefe 100644 --- a/src/gl

[Mesa-dev] [PATCH 8/8] i965/vs: Simplify fs_visitor's ATTR file.

Previously, ATTR was indexed by VERT_ATTRIB_* slots; at the end of compilation, assign_vs_urb_setup() translated those into GRF units, and converted ATTR to HW_REGs. This patch moves the transslation earlier, making ATTR work in terms of GRF units from the beginning. assign_vs_urb_setup() simply

[Mesa-dev] [PATCH 3/8] i965: Move type_size() methods out of visitor classes.

I want to use C function pointers to these, and they don't use anything in the visitor classes anyway. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +- src/mesa/drivers/dri/i965/brw_fs.h | 1 - src/mesa/drivers/dri/i965/brw_fs_nir.cp

[Mesa-dev] [PATCH 4/8] nir: Pass a type_size() function pointer into nir_lower_io().

Previously, there were four type_size() functions in play - the i965 compiler backend defined scalar and vec4 type_size() functions, and nir_lower_io contained its own similar functions. In fact, the i965 driver used nir_lower_io() and then looped over the components using its own type_size - mean

Re: [Mesa-dev] [PATCH 1/4] mesa/formats: only do type and component lookup for uncompressed formats

Cc'ing Brian. I'm planning to make a patch to implement the first (3-step) solution. On Mon, Aug 17, 2015 at 3:45 PM, Nanley Chery wrote: > > On Fri, Aug 14, 2015 at 4:00 PM, Chad Versace > wrote: > >> On Tue 11 Aug 2015, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > Only uncompressed

Re: [Mesa-dev] [PATCH 4/8] nir: Pass a type_size() function pointer into nir_lower_io().

The first four are Reviewed-by: Jason Ekstrand I'll get to the others later. On Mon, Aug 17, 2015 at 4:07 PM, Kenneth Graunke wrote: > Previously, there were four type_size() functions in play - the i965 > compiler backend defined scalar and vec4 type_size() functions, and > nir_lower_io conta

  1   2   >