Hi, This is a new version of the patch that accounts for extensions that allow new combinations of format, type and internal format; where the internal format is in base (unsized) form.
I also moved the check to glformats's _mesa_es3_error_check_format_and_type(), because this is really part of this function, so lets not have the same checks spread around in different funcs and files. This made necessary to move the function _mesa_base_tex_format() to glformats.c, because it is needed there now. And if you think about it, glformats is the right place for it since it concerns GL formats only. That's what the first patch does. I observed no regression in piglit and dEQP GLES2/GLES3 on HSW. Eduardo Eduardo Lima Mitev (2): mesa: Move _mesa_base_tex_format() from teximage to glformats files mesa: Use the effective internal format instead for validation src/mesa/main/glformats.c | 633 ++++++++++++++++++++++++++++++++++++++++++++++ src/mesa/main/glformats.h | 2 + src/mesa/main/teximage.c | 519 +------------------------------------ src/mesa/main/teximage.h | 4 - 4 files changed, 641 insertions(+), 517 deletions(-) -- 2.4.6 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev