Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi;
I believe something more needs to be done here, it may be generic
changes to the memory qualifier parsing. I wrote a Piglit test that
fails with these changes (I tested against
itoral-ARB_shader_storage_buffer_object-v4.1 branch), here:
http://lists.freedesktop.org/archives/piglit/2015-A
---
src/mesa/main/fbobject.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 8418340..07db195 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -2033,6 +2033,16 @@ renderbuffer_storage(struct gl_context
---
src/mesa/main/teximage.c | 2 +-
src/mesa/main/teximage.h | 9 -
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index fc69387..55cbb37 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -5595,7 +55
I've sent a couple of follow-up patches I notice when reviewing this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
> v2: code cleanup
>
> Signed-off-by: Tapani Pälli
> ---
> src/mesa/main/teximage.c | 24
> 1 file changed, 24 insertions(+)
>
> diff --git a/s
Reviewed-by: Timothy Arceri
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
V2: remove the validation from it old location.
---
src/mesa/main/fbobject.c| 10 ++
src/mesa/main/multisample.c | 9 -
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 8418340..07db195 100644
--- a/src/m
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I notice when reviewing this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
v2: code cleanup
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 24
1 file chan
On 08/13/2015 12:14 PM, Tapani Pälli wrote:
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I notice when reviewing this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
v2: code cleanup
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximag
Reviewed-by: Tapani Pälli
On 08/13/2015 11:53 AM, Timothy Arceri wrote:
---
src/mesa/main/teximage.c | 2 +-
src/mesa/main/teximage.h | 9 -
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index fc69387..55cbb37 1006
On Wed, Aug 12, 2015 at 11:23 PM, Thomas Helland
wrote:
> 2015-08-12 18:56 GMT+02:00 Kenneth Graunke :
>> On Wednesday, August 12, 2015 06:32:50 PM Thomas Helland wrote:
>>> 2015-08-12 17:48 GMT+02:00 Ilia Mirkin :
>>> > On Tue, Aug 11, 2015 at 1:48 PM, Thomas Helland
>>> > wrote:
>>> >> Signed-o
On Aug 13, 2015 12:33 PM, "Marek Olšák" wrote:
>
> On Wed, Aug 12, 2015 at 11:23 PM, Thomas Helland
> wrote:
> > 2015-08-12 18:56 GMT+02:00 Kenneth Graunke :
> >> On Wednesday, August 12, 2015 06:32:50 PM Thomas Helland wrote:
> >>> 2015-08-12 17:48 GMT+02:00 Ilia Mirkin :
> >>> > On Tue, Aug 11,
On Thu, 2015-08-13 at 12:28 +0300, Tapani Pälli wrote:
>
> On 08/13/2015 12:14 PM, Tapani Pälli wrote:
> >
> >
> > On 08/13/2015 11:54 AM, Timothy Arceri wrote:
> > > I've sent a couple of follow-up patches I notice when reviewing this.
> > >
> > >
> > > On Thu, 2015-08-13 at 09:30 +0300, Tapa
From: Marta Lofstedt
According to OpenGL specification version 4.5 table 23.46
and OpenGL ES specification version 3.1 table 20.31:
ATOMIC_COUNTER_BUFFER_START and ATOMIC_COUNTER_BUFFER_SIZE
should have the initial value of zero.
Signed-off-by: Marta Lofstedt
---
src/mesa/main/bufferobj.c | 4
> -Original Message-
> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
> Behalf Of Erik Faye-Lund
> Sent: Tuesday, June 23, 2015 3:41 PM
> To: Marta Lofstedt
> Cc: mesa-dev@lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH 5/6] mesa/es31: AtomicBufferBindings
> should
With non-dsa functions we need to do target error checking before
_mesa_get_current_tex_object which would just call _mesa_problem without
raising GL_INVALID_ENUM error. In other places of Mesa, target gets checked
before this call. For dsa functions, we do not need this check. Texture
has been cre
On 13 August 2015 at 11:32, Marek Olšák wrote:
> On Wed, Aug 12, 2015 at 11:23 PM, Thomas Helland
> wrote:
>> 2. GLX_ARB_get_proc_address
>> 4. WGL_ARB_buffer_region
>> 8. WGL_ARB_extensions_string
>> 9. WGL_ARB_pixel_format
>> 10. WGL_ARB_make_current
On 7 August 2015 at 19:22, Matt Turner wrote:
> On Fri, Aug 7, 2015 at 11:05 AM, Emil Velikov
> wrote:
>> On 21 July 2015 at 13:12, Emil Velikov wrote:
>>> On 20/07/15 21:25, Chad Versace wrote:
On Fri 17 Jul 2015, Emil Velikov wrote:
> On 17 July 2015 at 19:11, Ilia Mirkin wrote:
>>>
On Thu, 2015-08-13 at 14:05 +0300, Tapani Pälli wrote:
> With non-dsa functions we need to do target error checking before
> _mesa_get_current_tex_object which would just call _mesa_problem without
> raising GL_INVALID_ENUM error. In other places of Mesa, target gets checked
> before this call. For
On 07/08/15 23:13, Chris Wilson wrote:
intel_update_winsys_renderbuffer_miptree() will release the existing
miptree when wrapping a new DRI2 buffer, so we can remove the early
release and so prevent a NULL mt dereference should importing the new
DRI2 name fail for any reason. (Reusing the old DRI
On 08/13/2015 02:51 PM, Timothy Arceri wrote:
On Thu, 2015-08-13 at 14:05 +0300, Tapani Pälli wrote:
With non-dsa functions we need to do target error checking before
_mesa_get_current_tex_object which would just call _mesa_problem without
raising GL_INVALID_ENUM error. In other places of Mesa
On Thu, Aug 13, 2015 at 12:59 PM, Marta Lofstedt
wrote:
> From: Marta Lofstedt
>
> According to OpenGL specification version 4.5 table 23.46
> and OpenGL ES specification version 3.1 table 20.31:
> ATOMIC_COUNTER_BUFFER_START and ATOMIC_COUNTER_BUFFER_SIZE
> should have the initial value of zero.
From: Marta Lofstedt
According to OpenGL version 4.5 and OpenGL ES 3.1 standards,
section 7.3:
GL_INVALID_VALUE should be generated, if count is less than 0.
V2: Changed title, eased Open GL ES 3.1 restriction
and added comments.
---
src/mesa/main/shaderapi.c | 9 +
1 file changed, 9 in
Martin Peres writes:
> Signed-off-by: Martin Peres
Reviewed-by: Francisco Jerez
> ---
> src/glsl/glcpp/glcpp-parse.y| 3 +++
> src/glsl/glsl_parser_extras.cpp | 1 +
> src/glsl/glsl_parser_extras.h | 2 ++
> src/mesa/main/extensions.c | 1 +
> src/mesa/main/mtypes.h | 1 +
On Thu, 2015-08-13 at 15:01 +0300, Tapani Pälli wrote:
>
> On 08/13/2015 02:51 PM, Timothy Arceri wrote:
> > On Thu, 2015-08-13 at 14:05 +0300, Tapani Pälli wrote:
> > > With non-dsa functions we need to do target error checking before
> > > _mesa_get_current_tex_object which would just call _mesa
Martin Peres writes:
> The code is heavily inspired from Francisco Jerez's code supporting the
> image_load_store extension.
>
> I moved out image_types[] out of builtin_builder::add_image_function to
> share it with the newly-added builtin_builder::add_image_size_functions.
>
> Backends willing
On 13/08/15 15:53, Francisco Jerez wrote:
Martin Peres writes:
The code is heavily inspired from Francisco Jerez's code supporting the
image_load_store extension.
I moved out image_types[] out of builtin_builder::add_image_function to
share it with the newly-added builtin_builder::add_image_s
On Thu, 2015-08-13 at 14:38 +0200, Marta Lofstedt wrote:
> From: Marta Lofstedt
>
> According to OpenGL version 4.5 and OpenGL ES 3.1 standards,
> section 7.3:
> GL_INVALID_VALUE should be generated, if count is less than 0.
>
> V2: Changed title, eased Open GL ES 3.1 restriction
> and added com
Makes sense.
Reviewed-by: Roland Scheidegger
Am 12.08.2015 um 12:45 schrieb Marek Olšák:
> From: Marek Olšák
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74329
>
> v2: add a CAP for half floats
> drivers should not expose the CAPs if they don't support the formats
> ---
> s
On 08/13/2015 03:47 PM, Timothy Arceri wrote:
On Thu, 2015-08-13 at 15:01 +0300, Tapani Pälli wrote:
On 08/13/2015 02:51 PM, Timothy Arceri wrote:
On Thu, 2015-08-13 at 14:05 +0300, Tapani Pälli wrote:
With non-dsa functions we need to do target error checking before
_mesa_get_current_tex_obje
With non-dsa functions we need to do target error checking before
_mesa_get_current_tex_object which would just call _mesa_problem without
raising GL_INVALID_ENUM error. In other places of Mesa, target gets checked
before this call.
Fixes failures in:
ES31-CTS.texture_storage_multisample.APIGLG
On 12.08.2015 14:24, Hans de Goede wrote:
> Scanout buffers on nv30 must always be non-swizzled and have special
> width alignment constraints.
>
> These constrains have been taken from the xf86-video-nouveau
> src/nv_accel_common.c: nouveau_allocate_surface() function.
>
> nouveau_allocate_surfa
Hi,
On ke, 2015-08-12 at 18:34 -0700, Ben Widawsky wrote:
> On Wed, Aug 12, 2015 at 03:09:44PM +0300, Joonas Lahtinen wrote:
> > Add a comment about reinforcing command order so that
> > 3DSTATE_BINDING_TABLE_POINTER_* commands are after
> > 3DSTATE_CONSTANT_* commands for SKL & BXT, otherwise the
On Thu, Aug 13, 2015 at 2:53 AM, Timothy Arceri
wrote:
> ---
> src/mesa/main/teximage.c | 2 +-
> src/mesa/main/teximage.h | 9 -
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index fc69387..55cbb37 100644
> ---
Hi Alex,
On 10 August 2015 at 20:36, Alex Deucher wrote:
> Signed-off-by: Alex Deucher
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> include/pci_ids/radeonsi_pci_ids.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/pci_ids/radeonsi_pci_ids.h
> b/include/pci_ids/radeonsi_pci
On Thu, Aug 13, 2015 at 4:31 AM, Emil Velikov wrote:
> On 7 August 2015 at 19:22, Matt Turner wrote:
>> On Fri, Aug 7, 2015 at 11:05 AM, Emil Velikov
>> wrote:
>>> On 21 July 2015 at 13:12, Emil Velikov wrote:
On 20/07/15 21:25, Chad Versace wrote:
> On Fri 17 Jul 2015, Emil Velikov w
On Thu, Aug 13, 2015 at 11:11 AM, Emil Velikov wrote:
> Hi Alex,
>
> On 10 August 2015 at 20:36, Alex Deucher wrote:
>> Signed-off-by: Alex Deucher
>> Cc: mesa-sta...@lists.freedesktop.org
>> ---
>> include/pci_ids/radeonsi_pci_ids.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/i
On 13 August 2015 at 16:23, Matt Turner wrote:
> On Thu, Aug 13, 2015 at 4:31 AM, Emil Velikov
> wrote:
>> On 7 August 2015 at 19:22, Matt Turner wrote:
>>> On Fri, Aug 7, 2015 at 11:05 AM, Emil Velikov
>>> wrote:
On 21 July 2015 at 13:12, Emil Velikov wrote:
> On 20/07/15 21:25, Ch
On 13 August 2015 at 16:42, Alex Deucher wrote:
> On Thu, Aug 13, 2015 at 11:11 AM, Emil Velikov
> wrote:
>> Hi Alex,
>>
>> On 10 August 2015 at 20:36, Alex Deucher wrote:
>>> Signed-off-by: Alex Deucher
>>> Cc: mesa-sta...@lists.freedesktop.org
>>> ---
>>> include/pci_ids/radeonsi_pci_ids.h
On Thu, Aug 13, 2015 at 10:38:43AM +0300, Joonas Lahtinen wrote:
> Hi,
>
> On ke, 2015-08-12 at 18:34 -0700, Ben Widawsky wrote:
> > On Wed, Aug 12, 2015 at 03:09:44PM +0300, Joonas Lahtinen wrote:
> > > Add a comment about reinforcing command order so that
> > > 3DSTATE_BINDING_TABLE_POINTER_* co
Thanks Tapani, I'll look into this as soon as I get back from holidays.
The implementation has changed slightly since I sent these patches too
btw.
Iago
El 2015-08-13 10:05, Tapani Pälli escribió:
Hi;
I believe something more needs to be done here, it may be generic
changes to the memory qua
On 12 August 2015 at 18:53, Matt Turner wrote:
> On Wed, Aug 12, 2015 at 8:36 AM, Frank Binns wrote:
>> The EGL 1.4 spec states for eglCreateContext:
>>
>> "attribute EGL_CONTEXT_CLIENT_VERSION is only valid when the current
>> rendering API is EGL_OPENGL_ES_API"
>>
>> Additional
The code is heavily inspired from Francisco Jerez's code supporting the
image_load_store extension.
Backends willing to support this builtin should handle
__intrinsic_image_size.
v2: Based on the review of Ilia Mirkin
- Enable the extension for GLES 3.1
- Fix indentation
- Fix the return type (fl
v2, review from Francisco Jerez:
- make the destination variable as large as what the nir instrinsic
defines (4) instead of the size of the return variable of glsl. This
is still safe for the already existing code because all the intrinsics
affected returned the same amount of components
v2, Review from Francisco Jerez:
- avoid the camelCase for the booleans
- init the booleans using the sampler type
- force the initialization of all the components of the output register
Signed-off-by: Martin Peres
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 48 +++
On Thu, Aug 13, 2015 at 1:00 PM, Martin Peres
wrote:
> v2, Review from Francisco Jerez:
> - avoid the camelCase for the booleans
> - init the booleans using the sampler type
> - force the initialization of all the components of the output register
>
> Signed-off-by: Martin Peres
> ---
> src/mesa
On Thu, Aug 13, 2015 at 12:06 PM, Emil Velikov wrote:
> On 13 August 2015 at 16:42, Alex Deucher wrote:
>> On Thu, Aug 13, 2015 at 11:11 AM, Emil Velikov
>> wrote:
>>> Hi Alex,
>>>
>>> On 10 August 2015 at 20:36, Alex Deucher wrote:
Signed-off-by: Alex Deucher
Cc: mesa-sta...@lists.
FLT_TO_INT goes in the vector pipes on evergreen/NI,
not the trans unit as on earlier chips.
Signed-off-by: Glenn Kennard
---
Fixes issue found on nine: https://github.com/iXit/Mesa-3D/issues/119
src/gallium/drivers/r600/r600_isa.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Tested-by: Nick Sarnie
On Thu, Aug 13, 2015 at 2:49 PM, Nick Sarnie
wrote:
> Tested-by: Nick Sarnie
>
> On Thu, Aug 13, 2015 at 2:30 PM, Glenn Kennard
> wrote:
>
>> FLT_TO_INT goes in the vector pipes on evergreen/NI,
>> not the trans unit as on earlier chips.
>>
>> Signed-off-by: Glenn Kenna
Hi Macros,
Looks like it's not parsed in exactly right. It will parse something like
TESS_EVAL
PROPERTY TES_PRIM_MODE 7
PROPERTY TES_SPACING 2
PROPERTY TES_VERTEX_ORDER_CW 0
PROPERTY TES_POINT_MODE 0
DCL IN[][0], GENERIC[0]
DCL IN[][1], GENERIC[1]
as
TESS_EVAL
PROPERTY TES_PRIM_MODE 7
PROPERTY
Signed-off-by: Ilia Mirkin
---
The blending-in-shader piglit test passed even without the flush,
which doesn't inspire me with confidence, but those piglit_draw_rect
things are pretty heavy so perhaps cause a flush on their own anyways.
docs/GL3.txt | 2 +-
docs/
From: Marek Olšák
---
src/gallium/docs/source/screen.rst | 3 +++
src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
src/gallium/drivers/i915/i915_screen.c | 1 +
src/gallium/drivers/ilo/ilo_screen.c | 1 +
src/gallium/drivers/llvmpipe/lp_screen.c
Hi,
This is a simple feature that both Catalyst and NVIDIA support. Of all Radeons,
only GCN can do it, so it's a pretty "new" feature for us.
I had hoped it would increase performance for Doom 3, which uses it, until I
discovered that Doom 3 is CPU-bound.
Marek
___
From: Marek Olšák
zMin and zMax can't use _DepthMaxF, because the test is done in Z32_UNORM.
Probably a useless patch given how popular swrast is nowadays, but it helped
create and validate the piglit test.
---
src/mesa/swrast/s_depth.c | 14 --
1 file changed, 12 insertions(+), 2 d
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
src/gallium/drivers/radeonsi/si_state.c | 10 ++
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index cd22862..9986bde 1
From: Marek Olšák
---
src/mesa/state_tracker/st_atom_depth.c | 15 +++
src/mesa/state_tracker/st_extensions.c | 1 +
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_atom_depth.c
b/src/mesa/state_tracker/st_atom_depth.c
index c4bca8d..d9cc97
Signed-off-by: Ilia Mirkin
---
This and the following patch apply on top of the series that Marek just sent
out.
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-
src/gallium/drivers/nouveau/nvc0/nvc0_state.c| 7 +++
src/gallium/drivers/nouveau/nvc0/nvc0_stateobj.h | 2 +-
3 fil
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/nouveau/nv30/nv30_screen.c | 4 +++-
src/gallium/drivers/nouveau/nv30/nv30_state.c | 8
src/gallium/drivers/nouveau/nv30/nv30_state.h | 4 +++-
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/nouveau
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 +-
src/gallium/drivers/nouveau/nv50/nv50_state.c| 10 ++
src/gallium/drivers/nouveau/nv50/nv50_stateobj.h | 2 +-
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/
One minor nit below.
For 1, 2, 4:
Reviewed-by: Brian Paul
On 08/13/2015 02:32 PM, Marek Olšák wrote:
From: Marek Olšák
zMin and zMax can't use _DepthMaxF, because the test is done in Z32_UNORM.
Probably a useless patch given how popular swrast is nowadays, but it helped
create and validate
I guess the question is if those depth bounds floats should be in the
dsa state or set separately. That would mostly depend on if you expect
frequent changes to the values or not, at least that's the pattern
usually followed. Either way though looks ok to me.
Reviewed-by: Roland Scheidegger
Am 1
On 13/08/15 18:11, Alex Deucher wrote:
> On Thu, Aug 13, 2015 at 12:06 PM, Emil Velikov
> wrote:
>> On 13 August 2015 at 16:42, Alex Deucher wrote:
>>> On Thu, Aug 13, 2015 at 11:11 AM, Emil Velikov
>>> wrote:
Hi Alex,
On 10 August 2015 at 20:36, Alex Deucher wrote:
> Signe
On Mon, Aug 10, 2015 at 8:32 PM, Zoltan Gilian wrote:
> ---
> src/gallium/drivers/r600/evergreen_compute.c | 101
> ---
> src/gallium/drivers/r600/evergreen_state.c | 44 +++-
> src/gallium/drivers/r600/r600_pipe.h | 4 +-
> src/gallium/drivers/radeon
On 13/08/15 22:22, Emil Velikov wrote:
> On 13/08/15 18:11, Alex Deucher wrote:
>> On Thu, Aug 13, 2015 at 12:06 PM, Emil Velikov
>> wrote:
>>> On 13 August 2015 at 16:42, Alex Deucher wrote:
On Thu, Aug 13, 2015 at 11:11 AM, Emil Velikov
wrote:
> Hi Alex,
>
> On 10 Augus
Reviewed-by: Marek Olšák
I can't review the other patch completely, because it contains some
compute stuff I'm not familiar with.
Marek
On Wed, Aug 12, 2015 at 2:19 PM, Zoltan Gilian wrote:
> v2: Add compute mode flag to sampler state setup (Marek).
> Drop branches which avoid reference co
[mesa-dev readded, please don't drop CC's]
I found it by feeding the shader to nouveau_compiler with
NV50_PROG_DEBUG=1 set, which dumps the input tgsi. Those two should
match up.
On Thu, Aug 13, 2015 at 5:39 PM, Marcos Paulo de souza
wrote:
> Hi Ilia,
>
> So, how can I test it? Do I need to espe
We now print out the name of the message instead of its numerical
value, and label the message control and surface numbers.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_disasm.c | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git
If gen9_use_linear_1d_layout() returns true, we discards the align_w
computed earlier and use fixed align_w = 64 in gen9_miptree_layout_1d().
So, avoid computing align_w when not required.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 2 +-
1 file changed, 1 inserti
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index edd7518..6ac4024 100644
--- a/src/mesa/drivers/dri/i
Patch just does some refactoring to make the code look better. No
functional changes in here.
Cc: Ben Widawsky
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 46 ++
1 file changed, 22 insertions(+), 24 deletions(-)
diff --git a/src/mesa/
Vertical alignment is not applicable to 1D textures.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index 4e4
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index 53f7698..9a3c844 100644
--- a/src/mesa/driver
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index 01516d1..f914cf8 100644
--- a/src/mesa/driver
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
index 9a3c844..01516d1 100644
--- a/sr
On Thu, Aug 13, 2015 at 5:29 PM, Emil Velikov wrote:
> On 13/08/15 22:22, Emil Velikov wrote:
>> On 13/08/15 18:11, Alex Deucher wrote:
>>> On Thu, Aug 13, 2015 at 12:06 PM, Emil Velikov
>>> wrote:
On 13 August 2015 at 16:42, Alex Deucher wrote:
> On Thu, Aug 13, 2015 at 11:11 AM, Emil
From: Nanley Chery
The ASTC spec was revised as follows:
Revision 2, April 28, 2015 - added CompressedTex{Sub,}Image3D to
commands accepting ASTC format tokens in the New Tokens section [...].
Support only exists in the HDR submode:
Add a second new column "3D Tex." which is empty for
Ilia Mirkin writes:
> Signed-off-by: Ilia Mirkin
> ---
>
> The blending-in-shader piglit test passed even without the flush,
> which doesn't inspire me with confidence, but those piglit_draw_rect
> things are pretty heavy so perhaps cause a flush on their own anyways.
I think you don't actually
On Thu, Aug 13, 2015 at 7:19 PM, Eric Anholt wrote:
> Ilia Mirkin writes:
>
>> Signed-off-by: Ilia Mirkin
>> ---
>>
>> The blending-in-shader piglit test passed even without the flush,
>> which doesn't inspire me with confidence, but those piglit_draw_rect
>> things are pretty heavy so perhaps c
On Tue, Aug 11, 2015 at 03:04:17PM +0100, Neil Roberts wrote:
> Ben Widawsky writes:
>
> > Either of you opposed to doing it as a follow-on patch? (This failure
> > you speak of was the primary goal for removing it). Initially, I tried
> > to remove it, but we do still seem to use this logic pre-
On 14.08.2015 05:32, Marek Olšák wrote:
> From: Marek Olšák
Reviewed-by: Michel Dänzer
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev
On Thu, Aug 13, 2015 at 11:55 PM, Marcos Souza
wrote:
> Hi Ilia,
>
> So i found the point here it addrs that double brackets, and the following
> patch solves it, but this is a right solution? If someone could guide me
> here, I could fix it :)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump
https://bugs.freedesktop.org/show_bug.cgi?id=91631
Bug ID: 91631
Summary: Clang static analysis of libtess shows undefined
values and use of memory after free
Product: Mesa
Version: git
Hardware: All
OS: All
https://bugs.freedesktop.org/show_bug.cgi?id=91631
Jonathan Liu changed:
What|Removed |Added
CC||a...@freedesktop.org,
|
On Fri, Aug 14, 2015 at 12:25 AM, Marcos Souza
wrote:
> Hi Ilia,
>
> 2015-08-14 1:02 GMT-03:00 Ilia Mirkin :
>>
>> On Thu, Aug 13, 2015 at 11:55 PM, Marcos Souza
>> wrote:
>> > Hi Ilia,
>> >
>> > So i found the point here it addrs that double brackets, and the
>> > following
>> > patch solves it,
On Fri, Aug 14, 2015 at 12:43 AM, Marcos Souza
wrote:
> HI Ilia
>
> 2015-08-14 1:31 GMT-03:00 Ilia Mirkin :
>>
>> On Fri, Aug 14, 2015 at 12:25 AM, Marcos Souza
>> wrote:
>> > Hi Ilia,
>> >
>> > 2015-08-14 1:02 GMT-03:00 Ilia Mirkin :
>> >>
>> >> On Thu, Aug 13, 2015 at 11:55 PM, Marcos Souza
>>
On Fri, Aug 14, 2015 at 12:52 AM, Marcos Paulo de souza
wrote:
> Now I'll take a look about the last problem of LRP and MOV.
That should ideally have solved itself too... if not, do you have the
full shader that demonstrates the problem?
___
mesa-dev ma
On Thursday, August 13, 2015 02:57:20 PM Martin Peres wrote:
> On 07/08/15 23:13, Chris Wilson wrote:
> > intel_update_winsys_renderbuffer_miptree() will release the existing
> > miptree when wrapping a new DRI2 buffer, so we can remove the early
> > release and so prevent a NULL mt dereference sho
On Thursday, August 13, 2015 02:57:20 PM Martin Peres wrote:
> On 07/08/15 23:13, Chris Wilson wrote:
> > intel_update_winsys_renderbuffer_miptree() will release the existing
> > miptree when wrapping a new DRI2 buffer, so we can remove the early
> > release and so prevent a NULL mt dereference sho
On 08/07/2015 12:56 PM, Tapani Pälli wrote:
Super, I've verified that this makes
ES31-CTS.shader_image_load_store.basic-api-barrier-byRegion pass with
one of Curro's branches.
Reviewed-by: Tapani Pälli
Urgh should've tested this before but now I noticed that 'make check'
does not pass with
On 08/14/2015 08:21 AM, Tapani Pälli wrote:
On 08/07/2015 12:56 PM, Tapani Pälli wrote:
Super, I've verified that this makes
ES31-CTS.shader_image_load_store.basic-api-barrier-byRegion pass with
one of Curro's branches.
Reviewed-by: Tapani Pälli
Urgh should've tested this before but now
On Mon, Aug 10, 2015 at 4:29 AM, Lofstedt, Marta
wrote:
>> -Original Message-
>> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On
>> Behalf Of Ilia Mirkin
>> Sent: Friday, August 7, 2015 9:56 PM
>> To: Matt Turner
>> Cc: mesa-dev@lists.freedesktop.org
>> Subject: Re: [Mesa
On Thu, Aug 13, 2015 at 08:00:43PM +0300, Martin Peres wrote:
> v2, Review from Francisco Jerez:
> - avoid the camelCase for the booleans
> - init the booleans using the sampler type
> - force the initialization of all the components of the output register
>
> Signed-off-by: Martin Peres
> ---
>
On Thu, Aug 13, 2015 at 07:58:53PM +0300, Martin Peres wrote:
> The code is heavily inspired from Francisco Jerez's code supporting the
> image_load_store extension.
>
> Backends willing to support this builtin should handle
> __intrinsic_image_size.
>
> v2: Based on the review of Ilia Mirkin
> -
On 08/13/2015 11:54 AM, Timothy Arceri wrote:
I've sent a couple of follow-up patches I notice when reviewing this.
On Thu, 2015-08-13 at 09:30 +0300, Tapani Pälli wrote:
v2: code cleanup
Signed-off-by: Tapani Pälli
---
src/mesa/main/teximage.c | 24
1 file chan
On Thu, Aug 13, 2015 at 02:51:58PM -0700, Anuj Phogat wrote:
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/brw_tex_layout.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
> b/src/mesa/drivers/dri/i965/
From: Michel Dänzer
raw_svector_ostream::flush() is now unnecessary and forbidden:
CXX llvm/libclllvm_la-invocation.lo
../../../../../src/gallium/state_trackers/clover/llvm/invocation.cpp: In
function 'clover::module {anonymous}::build_module_llvm(llvm::Module*, unsigned
int (&)[7])':
.
Reviewed-by: Chris Forbes
On Fri, Aug 14, 2015 at 9:52 AM, Kenneth Graunke wrote:
> We now print out the name of the message instead of its numerical
> value, and label the message control and surface numbers.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_disasm.c |
97 matches
Mail list logo
