Re: Fwd: [Review requested] New DocBook layout parameter

On Tue, 27 Dec 2022 at 05:17, Richard Kimberly Heck wrote: > On 12/26/22 21:27, Thibaut Cuvelier wrote: > > On Tue, 27 Dec 2022 at 03:11, Richard Kimberly Heck > wrote: > >> On 12/26/22 20:01, Thibaut Cuvelier wrote: >> >> Riki, let me know :)! >> >> In another email, I said: >> >> I am planning

Re: Fwd: [Review requested] New DocBook layout parameter

On 12/26/22 21:27, Thibaut Cuvelier wrote: On Tue, 27 Dec 2022 at 03:11, Richard Kimberly Heck wrote: On 12/26/22 20:01, Thibaut Cuvelier wrote: Riki, let me know :)! In another email, I said: I am planning to do the tarball tomorrow, so I guess the question is whether

Re: Fwd: [Review requested] New DocBook layout parameter

On Tue, 27 Dec 2022 at 03:11, Richard Kimberly Heck wrote: > On 12/26/22 20:01, Thibaut Cuvelier wrote: > > Riki, let me know :)! > > In another email, I said: > > I am planning to do the tarball tomorrow, so I guess the question is > whether these changes can be **completed** by then. Since they

Re: Fwd: [Review requested] New DocBook layout parameter

On 12/26/22 20:01, Thibaut Cuvelier wrote: Riki, let me know :)! In another email, I said: I am planning to do the tarball tomorrow, so I guess the question is whether these changes can be *completed* by then. Since they don't affect really core code, I'm not too worried about them being ma

Re: Fwd: [Review requested] New DocBook layout parameter

On 12/26/22 16:57, Scott Kostyshak wrote: I'm fine with whatever Riki prefers since they're handling the beta 2. I am planning to do the tarball tomorrow, so I guess the question is whether these changes can be *completed* by then. Since they don't affect really core code, I'm not too worried

Re: Fwd: [Review requested] New DocBook layout parameter

t; > > > > > As I'm still not very confident with layout changes, and especially as > > LyX > > > master is maturing, I'm requesting some feedback/review before pushing. I > > > believe everything is there (code changes, layout version update, ch

Re: [Review requested] New DocBook layout parameter

t; > > > > > As I'm still not very confident with layout changes, and especially as > > LyX > > > master is maturing, I'm requesting some feedback/review before pushing. I > > > believe everything is there (code changes, layout version update, changes &

Re: Fwd: [Review requested] New DocBook layout parameter

Le 22/12/2022 à 04:45, Thibaut Cuvelier a écrit : Dear list, To solve https://www.lyx.org/trac/ticket/12612 , I needed a new layout parameter for DocBook to generate some content based on paragraph labels. It draws heavily from LyXHTML code: makeEnvironm

Re: Fwd: [Review requested] New DocBook layout parameter

eEnvironment in output_xhtml.cpp, > case on environments, label generation (currently, lines 499 to 511). > > As I'm still not very confident with layout changes, and especially as LyX > master is maturing, I'm requesting some feedback/review before pushing. I > believe everythin

Fwd: [Review requested] New DocBook layout parameter

). As I'm still not very confident with layout changes, and especially as LyX master is maturing, I'm requesting some feedback/review before pushing. I believe everything is there (code changes, layout version update, changes in the layout to use the new feature, documentation), with the ex

Re: #12368: Review Toolbar is not hidden in Fullscreen even when "Hide Toolbars" option is checked under "Editing > Control"

On Wed, 13 Oct 2021 at 09:07, LyX Ticket Tracker wrote: > #12368: Review Toolbar is not hidden in Fullscreen even when "Hide > Toolbars" option > is checked under "Editing > Control" > --+--- > Reporter:

Re: Patch review

On Wed, Sep 29, 2021 at 01:01:42PM +0300, Yuriy Skalko wrote: > >Older gcc will have problem: > > > >make[6]: Entering directory '/root/lyx/src/frontends/qt' > > CXX ColorCache.o > > CXX GuiBibtex.o > >GuiBibtex.cpp: In member function 'void > >lyx::frontend::GuiBibtex::setFileEncodings

Re: Patch review

Older gcc will have problem: make[6]: Entering directory '/root/lyx/src/frontends/qt' CXX ColorCache.o CXX GuiBibtex.o GuiBibtex.cpp: In member function 'void lyx::frontend::GuiBibtex::setFileEncodings(const std::__debug::vector, std::allocator > >&)': GuiBibtex.cpp:529:44: error

Re: Patch review

Le 28/09/2021 à 20:38, Yuriy Skalko a écrit : Hi all, I've recently compiled LyX with latest version of GCC and used several useful diagnostic options. Two simpler patches are already committed, but the third one is bigger and worth additional checkup -- it is in attachment. Besides the pro

Re: Patch review

On Tue, Sep 28, 2021 at 09:38:39PM +0300, Yuriy Skalko wrote: > Hi all, > > I've recently compiled LyX with latest version of GCC and used several > useful diagnostic options. Two simpler patches are already committed, but > the third one is bigger and worth additional checkup -- it is in attachme

Patch review

Hi all, I've recently compiled LyX with latest version of GCC and used several useful diagnostic options. Two simpler patches are already committed, but the third one is bigger and worth additional checkup -- it is in attachment. Best Regards, Yuriy From 6e2fb6f86550186881838f7020a1535e4fdff

Re: [PATCH] Patches to review

Thanks for all for reviewing the patches! Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class. Patch 4 also looks good. I thought it could break Qt 4.8 compilation but that's not the case [1, 2]. Sorry that I don't know enough to look at the others. Scott Yes,

Re: [PATCH] Patches to review

On 1/21/21 10:10 AM, Pavel Sanda wrote: On Thu, Jan 21, 2021 at 09:51:46AM -0500, Scott Kostyshak wrote: On Thu, Jan 21, 2021 at 09:38:08AM +0200, Yuriy Skalko wrote: Please review my recent patches for LyX. Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class. Patch

Re: [PATCH] Patches to review

On Thu, Jan 21, 2021 at 09:38:08AM +0200, Yuriy Skalko wrote: > diff --git a/src/frontends/qt/DockView.h b/src/frontends/qt/DockView.h > index 9c3a9e7460..1e7bd5f2db 100644 > --- a/src/frontends/qt/DockView.h > +++ b/src/frontends/qt/DockView.h > @@ -36,7 +36,7 @@ public: >Qt::DockW

Re: [PATCH] Patches to review

On Thu, Jan 21, 2021 at 09:51:46AM -0500, Scott Kostyshak wrote: > On Thu, Jan 21, 2021 at 09:38:08AM +0200, Yuriy Skalko wrote: > > Please review my recent patches for LyX. > > Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class. > > Patch 4 also

Re: [PATCH] Patches to review

Le 21/01/2021 à 08:38, Yuriy Skalko a écrit : Please review my recent patches for LyX. Concerning patch 1 and 5: what guideline do you use for using vector vs list. The patches look good, I am just wondering. Concerning patch 4: what does the replacement of 0 or nullptr by {} bring? JMarc

Re: [PATCH] Patches to review

On Thu, Jan 21, 2021 at 09:38:08AM +0200, Yuriy Skalko wrote: > Please review my recent patches for LyX. Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class. Patch 4 also looks good. I thought it could break Qt 4.8 compilation but that's not the case [1, 2]. So

[PATCH] Patches to review

Please review my recent patches for LyX. Yuriy From 9c9fd209149b05d6ec879d1792b9628734ce3ed5 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sun, 10 Jan 2021 13:27:40 +0200 Subject: [PATCH 1/5] Update Development.lyx --- lib/doc/Development.lyx | 99

Re: Patches to review

Please review next 2 patches. First one is fine. In second one, can this: @@ -1849,16 +1845,14 @@ docstring const LaTeXFeatures::getTClassPreamble() const -cit = usedInsetLayouts_.begin(); -end = usedInsetLayouts_.end(); +list::const_iterator cit = usedInsetLayouts_.begin

Re: Patches to review

On 12/6/20 6:01 AM, Yuriy Skalko wrote: > Please review next 2 patches. First one is fine. In second one, can this: @@ -1849,16 +1845,14 @@ docstring const LaTeXFeatures::getTClassPreamble() const -    cit = usedInsetLayouts_.begin(); -    end = usedInsetLayouts_.end(); +    l

Patches to review

Please review next 2 patches. Yuriy From 9d7d04d2fc0463bd1aa41acbbe22e95548a46d22 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Wed, 2 Dec 2020 22:34:28 +0200 Subject: [PATCH 1/5] More enums & includes refactoring --- src/Changes.cpp | 1 + src/Chang

Re: Patches to review

Le 05/12/2020 à 18:05, Richard Kimberly Heck a écrit : I just wanted to leave types of the pair as visible. Probably this is not really important and the code should be shortened to your variant. I tend to agree with Yuriy here. The code is a bit longer, but you do get an explicit indication of

Re: Patches to review

On 12/5/20 11:31 AM, Yuriy Skalko wrote: >> I see they are in now, but I have a proposal (of style). I code like >> below, >> -   for (; qq != end; ++qq) { >> -   docstring const style = from_ascii(qq->first); >> -   bool langdef = (style[0] == langqs); >> - 

Re: Patches to review

I see they are in now, but I have a proposal (of style). I code like below, - for (; qq != end; ++qq) { - docstring const style = from_ascii(qq->first); - bool langdef = (style[0] == langqs); - bool globaldef = (style[0] == globalqsc); + map st

Re: Patches to review

Le 02/12/2020 à 16:32, Yuriy Skalko a écrit : Next refactoring patches. I see they are in now, but I have a proposal (of style). I code like below, - for (; qq != end; ++qq) { - docstring const style = from_ascii(qq->first); - bool langdef = (style[0] == langq

Re: Patches to review

On Wed, Dec 02, 2020 at 12:01:15PM -0500, Richard Kimberly Heck wrote: > On 12/2/20 10:32 AM, Yuriy Skalko wrote: > > Next refactoring patches. > > #1 and #3 are fine. I'll leave #4 again to Pavel and others. All patches look fine to me. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org ht

Re: Patches to review

#1 and #3 are fine. I'll leave #4 again to Pavel and others. Thanks Riki. I'll wait to commit all at once. In #2, we have: /// who initiated the action -Origin origin_; +Origin origin_ = INTERNAL; It doesn't look as if there was a default before. It is set as defau

Re: Patches to review

On 12/2/20 10:32 AM, Yuriy Skalko wrote: Next refactoring patches. #1 and #3 are fine. I'll leave #4 again to Pavel and others. In #2, we have:      /// who initiated the action -    Origin origin_; +    Origin origin_ = INTERNAL; It doesn't look as if there was a default before. I often w

Re: Patches to review

Next refactoring patches. From 884c8270bc31208d150b444140b116374e78a479 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Wed, 2 Dec 2020 00:16:55 +0200 Subject: [PATCH 1/4] Fix warnings and use range-based loop --- src/frontends/qt/Menus.cpp | 14 ++ 1 file changed, 6 insertions(+)

Re: Patches to review

They look good. JMarc Thanks, committed. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Patches to review

Le 30/11/2020 à 23:33, Yuriy Skalko a écrit : And here are next 4 patches. They look good. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Patches to review

And here are next 4 patches. Yuriy From e89abcf0654343ec6090ace2bfe243809b64cabc Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Mon, 30 Nov 2020 18:06:12 +0200 Subject: [PATCH 1/4] Remove useless breaks --- src/insets/InsetNewpage.cpp | 8 1 file changed, 8 deletions(-) diff --git

Re: Patches to review

Looks good to me. Pavel Thanks, committed. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Patches to review

On Mon, Nov 30, 2020 at 12:38:36PM +0200, Yuriy Skalko wrote: > Next patches Looks good to me. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Patches to review

Next patches Yuriy From 065bbc50691b50bcc6b608fbcfb362d7f0e654ab Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sat, 28 Nov 2020 01:13:36 +0200 Subject: [PATCH 1/4] Cleanup included headers --- src/KeySequence.cpp | 2 -- src/frontends/qt/GuiErrorList.cpp | 1 - src/frontends/

Re: Patches to review

#1, #4, and #5 are all fine. I think #3 is fine, too, but someone who knows more about that code than I do should have a look, too. I suspect #2 is fine, as well, but Pavel may want to weigh in. 2 looks fine, 3 looks fine in principle :) Pavel Thanks for reviewing, all committed. Yuriy --

Re: Patches to review

On Fri, Nov 27, 2020 at 05:53:00PM -0500, Richard Kimberly Heck wrote: > On 11/27/20 4:43 PM, Yuriy Skalko wrote: > >>If it really isn't used, then go ahead. > >> > >>Riki > > > >Here is patch to remove it + another patches to review. > > #1,

Re: Patches to review

On 11/27/20 4:43 PM, Yuriy Skalko wrote: If it really isn't used, then go ahead. Riki Here is patch to remove it + another patches to review. #1, #4, and #5 are all fine. I think #3 is fine, too, but someone who knows more about that code than I do should have a look, too. I suspe

Re: Patches to review

If it really isn't used, then go ahead. Riki Here is patch to remove it + another patches to review. Yuriy From a164646e24e8271950d51ccc6d889f860cddff5b Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Fri, 27 Nov 2020 11:09:16 +0200 Subject: [PATCH 1/5] Use range-based loops ---

Re: Patches to review

On 11/27/20 5:35 AM, Yuriy Skalko wrote: >> All the patches are fine. I have only one remark concerning >> Counters::copy. I do not understand why this is a Counters method >> _and_ it receives two Counters instances as parameters. This looks >> like a badly specified method. >> >> >> OTOH, it look

Re: Patches to review

All the patches are fine. I have only one remark concerning Counters::copy. I do not understand why this is a Counters method _and_ it receives two Counters instances as parameters. This looks like a badly specified method. OTOH, it looks like it is not used. What about removing it ? JMarc

Re: Patches to review

Le 26/11/2020 à 22:07, Yuriy Skalko a écrit : Here are next 5 patches. All the patches are fine. I have only one remark concerning Counters::copy. I do not understand why this is a Counters method _and_ it receives two Counters instances as parameters. This looks like a badly specified metho

Patches to review

Here are next 5 patches. Yuriy From bdf2a935f79f465e75bafdedc3e50a4a513e24ca Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 26 Nov 2020 00:17:29 +0200 Subject: [PATCH 1/5] Use to_string function --- src/client/client.cpp | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-)

Re: Patches to review

I do not like the removal of debug.h. It's very handy to be able to simply lyxerr while debuging without playing with includes... Pavel OK. I restored debug.h includes in headers and committed the patch. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listi

Re: Patches to review

This one comes from the same place. I'll adopt the same solution there. Riki Thanks for fixes. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Patches to review

On Tue, Nov 24, 2020 at 10:55:41PM +0100, Pavel Sanda wrote: > On Tue, Nov 24, 2020 at 04:49:59PM -0500, Richard Kimberly Heck wrote: > > On 11/24/20 4:29 PM, Yuriy Skalko wrote: > > >As for the patch 5, these null pointer dereferences happen even on opening > > >LyX manuals. It is undefined behavi

Re: Patches to review

On 11/24/20 4:55 PM, Pavel Sanda wrote: On Tue, Nov 24, 2020 at 04:49:59PM -0500, Richard Kimberly Heck wrote: On 11/24/20 4:29 PM, Yuriy Skalko wrote: As for the patch 5, these null pointer dereferences happen even on opening LyX manuals. It is undefined behavior even if it doesn't crash LyX.

Re: Patches to review

On 11/24/20 4:59 PM, Richard Kimberly Heck wrote: On 11/24/20 4:29 PM, Yuriy Skalko wrote: As for the patch 5, these null pointer dereferences happen even on opening LyX manuals. It is undefined behavior even if it doesn't crash LyX. Most likely should be fixed somewhere instead of just checki

Re: Patches to review

On 11/24/20 4:29 PM, Yuriy Skalko wrote: As for the patch 5, these null pointer dereferences happen even on opening LyX manuals. It is undefined behavior even if it doesn't crash LyX. Most likely should be fixed somewhere instead of just checking. From 234bfe70c1e2766d856257aebe7eaad8836f5976 M

Re: Patches to review

On Tue, Nov 24, 2020 at 04:49:59PM -0500, Richard Kimberly Heck wrote: > On 11/24/20 4:29 PM, Yuriy Skalko wrote: > >As for the patch 5, these null pointer dereferences happen even on opening > >LyX manuals. It is undefined behavior even if it doesn't crash LyX. Most > >likely should be fixed somew

Re: Patches to review

On 11/24/20 4:29 PM, Yuriy Skalko wrote: As for the patch 5, these null pointer dereferences happen even on opening LyX manuals. It is undefined behavior even if it doesn't crash LyX. Most likely should be fixed somewhere instead of just checking. 1-4 are fine. I'll have a look at the null poi

Patches to review

As for the patch 5, these null pointer dereferences happen even on opening LyX manuals. It is undefined behavior even if it doesn't crash LyX. Most likely should be fixed somewhere instead of just checking. Yuriy From 761602ef70c60403992255ac2e3c23b112235378 Mon Sep 17 00:00:00 2001 From: Yuriy

Re: [LyX/master] UG: Import and review changes from Phil Netro.

should not end up in the manual. It's not my intention to let these survive after I review those points. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] UG: Import and review changes from Phil Netro.

Am Samstag, den 22.08.2020, 20:45 +0200 schrieb Pavel Sanda: > +\change_inserted 5863208 1598113909 > > +Document Notes and Questions > > +\end_layout I think such notes should not end up in the manual. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel ma

Re: Trivial patch review request

On Thu, Aug 15, 2019 at 07:26:44AM -0600, Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > > > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > > > Hopefully my activity in the credits > > > isn't seen as too vain. > > > > Not at all. I hope my att

Re: Trivial patch review request

On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > Hopefully my activity in the credits > > isn't seen as too vain. > > Not at all. I hope my attempt at humor wasn't what made you think that. > Whenever I attempt to make a

Re: Trivial patch review request

On Wed, Aug 14, 2019 at 07:32:45PM -0400, Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > > > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > > file is generated from generate_contributors.py so this fix (and the others > > I s

Re: Trivial patch review request

On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > Riki took care of this not long after I'd sent it, so I think we're good > but I appreciate you following up! Ah good to know. > Hopefully my activity in the credits > isn't seen as too vain. Not at all. I hope my attempt at humor

Re: Trivial patch review request

On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > file is generated from generate_contributors.py so this fix (and the others > I see you just made) are needed there. Ah good to know. I just ported the cha

Re: Trivial patch review request

On Wed, Aug 14, 2019 at 12:10 PM Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > >> On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: >> > LyX Developers, >> > >> > Can someone please review/incorporate

Re: Trivial patch review request

On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > > LyX Developers, > > > > Can someone please review/incorporate the attached, trivial, patch, which > > corrects a typo in the credits? >

Re: Trivial patch review request

On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > LyX Developers, > > Can someone please review/incorporate the attached, trivial, patch, which > corrects a typo in the credits? > > Please let me know if a tracker issue is warranted. > > Otherwise, pl

Trivial patch review request

LyX Developers, Can someone please review/incorporate the attached, trivial, patch, which corrects a typo in the credits? Please let me know if a tracker issue is warranted. Otherwise, please contact me with any comments, questions, or concerns. Thank you, Joel 0001-Correct-typo-in

Subequations Module Review Request

LyX Developers: ~8 Months ago I posted a (simple) module proposed for inclusion with LyX. Would someone be kind enough to review it, and if found satisfactory, mark it for inclusion in the next appropriate release? The ticket is: https://www.lyx.org/trac/ticket/10029 Thank you, Joel

Re: Ticket 10457 Code Review Request

Am 24.10.2016 um 08:46 schrieb Joel Kulesza: I've implemented the change (selfishly) requested in https://www.lyx.org/trac/ticket/10457. Hello Joel, many thanks! Everyone and every work welcome. What is the best way to get the change reviewed / committed / merged? You should attach your p

Ticket 10457 Code Review Request

LyX Developers: I've implemented the change (selfishly) requested in https://www.lyx.org/trac/ticket/10457. What is the best way to get the change reviewed / committed / merged? Thanks, Joel

Re: #10418: An Exposed Skin Care Acne Cream Review

On 10/04/2016 04:34 PM, Richard Heck wrote: On 10/04/2016 03:46 PM, Jean-Marc Lasgouttes wrote: Actually, telling us that you deleted the ticket by quoting (part of) it makes sure that the spam is archived forever :-p That's why I XXXd out a lot of it. rh So, does closing the ticket mean

Re: #10418: An Exposed Skin Care Acne Cream Review

On 10/04/2016 03:46 PM, Jean-Marc Lasgouttes wrote: > Actually, telling us that you deleted the ticket by quoting (part of) it > makes sure that the spam is archived forever :-p That's why I XXXd out a lot of it. rh

Re: #10418: An Exposed Skin Care Acne Cream Review

Actually, telling us that you deleted the ticket by quoting (part of) it makes sure that the spam is archived forever :-p It is better to delete it silently, since most people did not see it anyway. JMarc Le 4 octobre 2016 20:07:40 GMT+02:00, Richard Heck a écrit : >I deleted this ticket. > >R

Re: #10418: An Exposed Skin Care Acne Cream Review

On 10/04/2016 11:55 AM, LyX Ticket Tracker wrote: > #10418: An EXX Skin CXXX AXXX CXXXX Review > -+- > Reporter: | Owner: rgheck > WilsonScheffler| Status: new >

Re: [LyX/master] autotests: Sort and review patterns for test categorization and labeling.

Am Freitag, 18. Dezember 2015 um 12:37:28, schrieb Guenter Milde > On 2015-12-17, Kornel Benko wrote: > > Am Donnerstag, 17. Dezember 2015 um 12:49:13, schrieb Guenter Milde > > > > ... > > >> Should the now reverted commit be splitted, too or is it OK to re-revert? > > Günter I opt for spl

Re: [LyX/master] autotests: Sort and review patterns for test categorization and labeling.

On 2015-12-17, Kornel Benko wrote: > Am Donnerstag, 17. Dezember 2015 um 12:49:13, schrieb Guenter Milde > ... >> Should the now reverted commit be splitted, too or is it OK to re-revert? Günter

Re: [LyX/master] autotests: Sort and review patterns for test categorization and labeling.

6844659c05d7fc63d73185f5 > >> >> Author: Günter Milde > >> >> Date: Thu Dec 17 00:33:44 2015 +0100 > >> >> autotests: Sort and review patterns for test categorization and > >> >> labeling. > > >> > 1.) Please rev

Re: [LyX/master] autotests: Sort and review patterns for test categorization and labeling.

u Dec 17 00:33:44 2015 +0100 >> >> autotests: Sort and review patterns for test categorization and >> >> labeling. >> > 1.) Please revert. It is impossible to check the changes. >> >I always try to make as little change as possible. >> > 2.

Re: [LyX/master] autotests: Sort and review patterns for test categorization and labeling.

Am Donnerstag, 17. Dezember 2015 um 06:57:10, schrieb Guenter Milde > On 2015-12-17, Kornel Benko wrote: > > >> commit 1e06e83e309585186844659c05d7fc63d73185f5 > >> Author: Günter Milde > >> Date: Thu Dec 17 00:33:44 2015 +0100 > > >>

Re: [LyX/master] autotests: Sort and review patterns for test categorization and labeling.

On 2015-12-17, Kornel Benko wrote: >> commit 1e06e83e309585186844659c05d7fc63d73185f5 >> Author: Günter Milde >> Date: Thu Dec 17 00:33:44 2015 +0100 >> autotests: Sort and review patterns for test categorization and >> labeling. > 1.) Please reve

Re: [LyX/master] autotests: Sort and review patterns for test categorization and labeling.

Am Donnerstag, 17. Dezember 2015 um 00:35:04, schrieb Günter Milde > commit 1e06e83e309585186844659c05d7fc63d73185f5 > Author: Günter Milde > Date: Thu Dec 17 00:33:44 2015 +0100 > > autotests: Sort and review patterns for test categorization and labeling. > 1.) Pl

LyX Layout translations review

Hi Hatim, would you find time and review this list of translations we used for pdf generation? It can be found in the begining of lib/layouttranslations file. Some of the items are even untranslated. Fixes/updates should go into ar.po file, we will generate new version from that, you might want

Tutorial material on Sweaving in LyX. Please review

Hi I've prepared updated Sweave examples, will put into your Wiki after I can get one of two of you to tell me I'm not grossly wrong. http://pj.freefaculty.org/guides/Computing-HOWTO/LatexAndLyx/LyX-sweave-tutorial/ In the directory on LyX articles, I have mostly a salute to your fabulous improv

Re: Re: Re: Re: [LyX/master] * layouttranslations.review - review of all langs.

José Matos wrote: > When one of us is out Sara says something like this "Am alone I". Some kind > of reverse Yoda speak. :-) :) why father screen my looks on me instead of > FWIW with all the graph theory I got another cleaning for the Portuguese > translation that follows attached. its in bdc

Re: Re: Re: Re: [LyX/master] * layouttranslations.review - review of all langs.

On Wednesday 09 April 2014 09:16:51 Pavel Sanda wrote: > Time to ask Susana for the rest of pt.po > P Susana found a substitute. We are using all our skills of translation to understand Sara right now. :-) When one of us is out Sara says something like this "Am alone I". Some kind of reverse Y

Re: Last call for translations and layout translations review for LyX 2.1.0

2014-04-09 22:04 GMT+02:00 Georg Baum: > "Chart" => "Diagramm" > "Graph[[mathematical]]" => "Graph" > Makes sense. Got for it. Jürgen

Re: Last call for translations and layout translations review for LyX 2.1.0

Pavel Sanda schreef op 9-4-2014 5:51: Vincent van Ravesteijn wrote: Dear translators, Vincent, most of the string in nl section seem to be translated, except of Listings - can you check? layouttranslations.review: nl: "Acknowledgement", "Case", "Chart", (same translation as "Graph") "Claim",

Re: Re: Re: [LyX/master] * layouttranslations.review - review of all langs.

José Matos wrote: > On Wednesday 09 April 2014 08:34:29 Pavel Sanda wrote: > > Please check whether 64e2b3608 is correct I changed other math strings > > accordingly. > > > > Pavel > > Yes, it is. Thank you. :-) Time to ask Susana for the rest of pt.po :) P

Re: Re: Re: [LyX/master] * layouttranslations.review - review of all langs.

On Wednesday 09 April 2014 08:34:29 Pavel Sanda wrote: > Please check whether 64e2b3608 is correct I changed other math strings > accordingly. > > Pavel Yes, it is. Thank you. :-) -- José Abílio

Re: Re: [LyX/master] * layouttranslations.review - review of all langs.

José Matos wrote: > With the following patch both Portuguese and Brazilian Portuguese are > reviewed and complete. Please check whether 64e2b3608 is correct I changed other math strings accordingly. Pavel

Re: Re: [LyX/master] * layouttranslations.review - review of all langs.

On Wednesday 09 April 2014 11:14:15 Vincent van Ravesteijn wrote: > On Wed, Apr 9, 2014 at 6:34 AM, Pavel Sanda wrote: > > commit 7b48843c778a8f9c97bc676d01ad549579014060 > > Author: Pavel Sanda > > Date: Tue Apr 8 21:33:13 2014 -0700 > > > > * layouttr

Re: [LyX/master] * layouttranslations.review - review of all langs.

Vincent van Ravesteijn wrote: > Kornel has reviewed Slovak, so this can be removed. Yep, overlook on my side. P

Re: [LyX/master] * layouttranslations.review - review of all langs.

On Wed, Apr 9, 2014 at 6:34 AM, Pavel Sanda wrote: > commit 7b48843c778a8f9c97bc676d01ad549579014060 > Author: Pavel Sanda > Date: Tue Apr 8 21:33:13 2014 -0700 > > * layouttranslations.review - review of all langs. > > This list is hard to get exactly, but tr

Re: Last call for translations and layout translations review for LyX 2.1.0

Vincent van Ravesteijn wrote: > Dear translators, Vincent, most of the string in nl section seem to be translated, except of Listings - can you check? layouttranslations.review: nl: "Acknowledgement", "Case", "Chart", (same translation as "Graph") "Claim", "Condition", "Conjecture", "Corollar

Re: [LyX/master] Update layouttranslation review status

Georg Baum schreef op 13-3-2014 22:07: http://www.mail-archive.com/lyx-docs@lists.lyx.org/msg06489.html http://www.mail-archive.com/lyx-docs@lists.lyx.org/msg06511.html http://www.mail-archive.com/lyx-docs@lists.lyx.org/msg06557.html Thanks. Vincent

Re: [LyX/master] Update layouttranslation review status

ed. Georg PS: The call for review for LyX 2.0.0 is here: http://www.mail-archive.com/lyx-docs@lists.lyx.org/msg06489.html http://www.mail-archive.com/lyx-docs@lists.lyx.org/msg06511.html http://www.mail-archive.com/lyx-docs@lists.lyx.org/msg06557.html

Re: [LyX/master] Update layouttranslation review status

Georg Baum schreef op 13-3-2014 21:29: commit 5833f2609ba53341b869a261e449dc0b4f02b178 Author: Georg Baum Date: Thu Mar 13 21:29:27 2014 +0100 Update layouttranslation review status diff --git a/lib/layouttranslations.review b/lib/layouttranslations.review index 96078f6..0f49cd0 100644

Re: Row by Row sliding (review of 095060cfcaa8f)

Dear Hashini, I did see several copies of your answer. Unfortunately, I am not able to do much more than read the messages on myvphone. It is difficult to me to give useful advice without the source code and a proper keyboard... Tommaso, can ypu help ? JMarc Hashini Senaratne a écrit : >Hel

Re: Row by Row sliding (review of 095060cfcaa8f)

On 08/05/2013 08:38 AM, Hashini Senaratne wrote: Hello Jean-Marc, I continue my backwards visit of history. Although I posted some replies to mailing list last week, they do not seems to appear to the outside yet. So I am re-sending those replies. They did arrive here. It's just that JMarc i

  1   2   3   >