On 2015-12-17, Kornel Benko wrote: >> commit 1e06e83e309585186844659c05d7fc63d73185f5 >> Author: Günter Milde <mi...@lyx.org> >> Date: Thu Dec 17 00:33:44 2015 +0100
>> autotests: Sort and review patterns for test categorization and >> labeling. > 1.) Please revert. It is impossible to check the changes. > I always try to make as little change as possible. > 2.) Why are the Sublabel: commented? They are commented in order to keem the changes as little as possible. The idea is to do the sorting and cleanup first, establishing that there is no change in the matching tests and uncomment the sublabels later. I checked the changes by: 1. checkout of the pre-state: 3b7cd19153a/lyxgit 2. running configure: cmake -DLYX_ENABLE_EXPORT_TESTS=ON ../lyx 3. listing the tests with label: ctest -N -R "\..*_export/" 4. saving the list to labeledtests-1.txt and removing the test numbers with a regexp replace 5. editing the *Tests pattern files 6. repeating steps 2 to 4 (with filename labeledtests-2.txt) 7. examining the diff 8. repeating 5 to 7 to get only desired differences and more sortings. I agree, that putting all changes in one commit was not a good idea. Now I threw away a days work. > The sentence "The following exports worked with TeX Live 2013, but ...." > should be commented Thanks for pointing this out. How could we proceed? Günter
