Le 02/12/2020 à 16:32, Yuriy Skalko a écrit :
Next refactoring patches.


I see they are in now, but I have a proposal (of style). I code like below,
-       for (; qq != end; ++qq) {
-               docstring const style = from_ascii(qq->first);
-               bool langdef = (style[0] == langqs);
-               bool globaldef = (style[0] == globalqsc);
+       map<string, docstring> styles = quoteparams.getTypes();
+       for (auto const & s : styles) {
+               char style_char = (s.first)[0];
+               bool langdef = (style_char == langqs);
+               bool globaldef = (style_char == globalqsc);
+               docstring const style = from_ascii(s.first);
isn't it better to do directly as follows?
+       for (auto const & s : quoteparams.getTypes()) {

Regards,
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to