On Thu, Dec 22, 2022 at 04:45:52AM +0100, Thibaut Cuvelier wrote: > Dear list, > > To solve https://www.lyx.org/trac/ticket/12612, I needed a new layout > parameter for DocBook to generate some content based on paragraph labels. > It draws heavily from LyXHTML code: makeEnvironment in output_xhtml.cpp, > case on environments, label generation (currently, lines 499 to 511). > > As I'm still not very confident with layout changes, and especially as LyX > master is maturing, I'm requesting some feedback/review before pushing. I > believe everything is there (code changes, layout version update, changes > in the layout to use the new feature, documentation), with the exception of > updating the version number of all layouts (to avoid cluttering the patch). > > By the way, I noticed that the documentation on the new DocBook parameters > for the layouts is truly lacking. I'll try to do something about it. > > Thanks in advance! > > Thibaut Cuvelier
Hi Thibaut, Thank you for working on that, and proposing to the list. I don't understand the patch well, but from what I understand the C++ changes are small and your main concern is just making sure you checked all the boxes for what to do with a layout change. Unless anyone else has comments, I would say that after beta2 is tagged go ahead and push it if all of the docbook tests pass. Maybe also run <<ctest -R "layout">>. There are some layout tests that run quickly, although I forget what they do. Scott
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
