On Thu, Jan 21, 2021 at 09:38:08AM +0200, Yuriy Skalko wrote: > Please review my recent patches for LyX.
Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class. Patch 4 also looks good. I thought it could break Qt 4.8 compilation but that's not the case [1, 2]. Sorry that I don't know enough to look at the others. Scott [1] https://doc.qt.io/archives/qt-4.8/qt.html#MouseButton-enum [2] https://code.qt.io/cgit/qt/qtlocation.git/commit/?id=f3a34ce8890c68c04212eafa0ae2c9eeeb60b555
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
