Am Donnerstag, 17. Dezember 2015 um 06:57:10, schrieb Guenter Milde <mi...@users.sf.net> > On 2015-12-17, Kornel Benko wrote: > > >> commit 1e06e83e309585186844659c05d7fc63d73185f5 > >> Author: Günter Milde <mi...@lyx.org> > >> Date: Thu Dec 17 00:33:44 2015 +0100 > > >> autotests: Sort and review patterns for test categorization and > >> labeling. > > > > 1.) Please revert. It is impossible to check the changes. > > I always try to make as little change as possible. > > > 2.) Why are the Sublabel: commented? > > They are commented in order to keem the changes as little as possible. > > The idea is to do the sorting and cleanup first, establishing that there > is no change in the matching tests and uncomment the sublabels later. > > I checked the changes by: > > 1. checkout of the pre-state: 3b7cd19153a/lyxgit > > 2. running configure: cmake -DLYX_ENABLE_EXPORT_TESTS=ON ../lyx > > 3. listing the tests with label: ctest -N -R "\..*_export/" > > 4. saving the list to labeledtests-1.txt > and removing the test numbers with a regexp replace > > 5. editing the *Tests pattern files > > 6. repeating steps 2 to 4 (with filename labeledtests-2.txt) > > 7. examining the diff > > 8. repeating 5 to 7 to get only desired differences and more sortings. > > > I agree, that putting all changes in one commit was not a good idea. > Now I threw away a days work. > > > The sentence "The following exports worked with TeX Live 2013, but ...." > > should be commented > > Thanks for pointing this out. > > > How could we proceed? >
In the meantime I checked too. All tests would be executed as before, so I am
relieved.
I think, it is good idea to collect according to fail-reason.
1.) Changing comments
I have no problems here, because you are the expert.
2.) Sorting
No problem from my side, I appreciate it.
3.) Changing the regular expressions
Again, no problem
The problem I have, is that all 3 tasks are done in 1 step.
I would start with 1.)
next commit 3.)
next commit 2.)
And allow labels again.
> Günter
Kornel
signature.asc
Description: This is a digitally signed message part.
