alamb commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1963481027
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coercion
shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1962564677
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coe
alamb commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961792494
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coercion
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961784030
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961784030
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961784030
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961784030
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961784030
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961771860
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
findepi commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961727057
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coercio
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961634449
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
findepi commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961624797
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coercio
alamb commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1961476992
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coercion
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1960783349
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,186 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+/// Represents type coer
shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1960718930
##
datafusion/functions/src/datetime/date_part.rs:
##
@@ -95,24 +96,29 @@ impl DatePartFunc {
signature: Signature::one_of(
vec
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2661729365
> Side note: Is this logic from the old
[PR](https://github.com/apache/datafusion/pull/14268/files#diff-6e1fb265597317a8256c60670ff3ea7be6896b2df1199a40ca79419ce29b4ce3R610-R626)
goldmedal commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2661228616
> If you can access Signature, no reason you can't access for `Coercion`. I
think you should import `datafuison-expr-common` instead since Signature is
re-exported in `datafusion-e
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2661178188
> Thanks for working on this, @jayzhan211. The new behavior of coercion
signature makes sense to me.
>
> I found I can't access `Coercion` and `ImplicitCoercion` outside the
goldmedal commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1957108526
##
datafusion/expr-common/src/signature.rs:
##
@@ -466,6 +551,133 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone, Eq
alamb commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2660851126
I ran out of time yesterday and I am out next week so I am not likely to be
able to make much progress here.
Sorry about that -- maybe one of you will have a chance to do someth
shehabgamin commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2660643722
@jayzhan211 I will re-review by tomorrow EOD, exciting progress!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alamb commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2659830714
> To support int->string in coercion,
>
> This change is all you need
>
> ```rust
>
Coercion::new_exact(TypeSignatureClass::Native(logical_string())
alamb commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2659829028
> Modifying Signature::Coercible alone won't achieve what @shehabgamin wants
because, regardless of the approach, they would still need to:
>
> 1. Fork the entire function
> 2
alamb commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2659825449
I took the liberty of merging up from main to get the CI to pass again.
I hope to spend a bit longer today messing around with potential changes to
Coercion for your consideratio
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2659275171
To support int->string in coercion,
This change is all you need
```rust
Coercion::new_exact(TypeSignatureClass::Native(logical_string())),
```
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2659202892
> > Enum looks good to me but "adding user defined coercion variant" is not
clear to me since I think the Coercible signature is user-defined builtin, they
can change the type the
alamb commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2659139980
> Enum looks good to me but "adding user defined coercion variant" is not
clear to me since I think the Coercible signature is user-defined builtin, they
can change the type they need
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2658030158
Enum looks good to me but "adding user defined coercion variant" is not
clear to me since I think the Coercible signature is user-defined builtin, they
can change the type they ne
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1955414348
##
datafusion/expr-common/src/signature.rs:
##
@@ -365,7 +365,12 @@ impl TypeSignature {
}
}
-/// get all possible types for the given `Type
alamb commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1954707280
##
datafusion/common/src/types/native.rs:
##
@@ -198,6 +198,11 @@ impl LogicalType for NativeType {
TypeSignature::Native(self)
}
+/// Returns th
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2656253125
> @jayzhan211 is this PR ready for another review?
yes, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
alamb commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2656209082
@jayzhan211 is this PR ready for another review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1953648058
##
datafusion/expr-common/src/signature.rs:
##
@@ -365,7 +365,12 @@ impl TypeSignature {
}
}
-/// get all possible types for the given `Type
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1952259827
##
datafusion/expr-common/src/signature.rs:
##
@@ -460,6 +521,44 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone, Eq
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1952259827
##
datafusion/expr-common/src/signature.rs:
##
@@ -460,6 +521,44 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone, Eq
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1952259827
##
datafusion/expr-common/src/signature.rs:
##
@@ -460,6 +521,44 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone, Eq
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1952259827
##
datafusion/expr-common/src/signature.rs:
##
@@ -460,6 +521,44 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone, Eq
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2652699850
> @jayzhan211 Should we port any relevant tests from the old PR? #14268
or close this then revisit #14268
--
This is an automated message from the Apache Git Service.
To r
shehabgamin commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2652697207
@jayzhan211 Should we port any relevant tests from the old PR?
https://github.com/apache/datafusion/pull/14268
--
This is an automated message from the Apache Git Service.
To
shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1951995420
##
datafusion/expr-common/src/signature.rs:
##
@@ -460,6 +521,44 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone, E
shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1951987611
##
datafusion/expr-common/src/signature.rs:
##
@@ -365,7 +365,12 @@ impl TypeSignature {
}
}
-/// get all possible types for the given `Typ
shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1951987206
##
datafusion/expr-common/src/signature.rs:
##
@@ -431,6 +463,35 @@ impl TypeSignature {
}
}
+fn get_possible_types_from_signature_classes(
Review Com
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2650402809
I revisit the binary to string for ascii but it seems either Postgres and
Duckdb correctly support it.
```
postgres=# select ascii('0xa');
ascii
---
48
shehabgamin commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2649643809
@jayzhan211 I will re-review by tomorrow EOD!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1950091410
##
datafusion/expr/src/type_coercion/functions.rs:
##
@@ -596,75 +594,93 @@ fn get_valid_types(
vec![vec![target_type; *num]]
}
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2646195392
> but it would also be useful to be able to use the wildcard in the
return_type function as well.
Using TypeSignatureClass:Timestamp can represent wildcard of timestamp.
De
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948062578
##
datafusion/expr-common/src/signature.rs:
##
@@ -209,14 +210,13 @@ impl TypeSignature {
#[derive(Debug, Clone, Eq, PartialEq, PartialOrd, Hash)]
pub enum Ty
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948058156
##
datafusion/expr-common/src/signature.rs:
##
@@ -460,6 +521,44 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone, Eq
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948051074
##
datafusion/expr-common/src/signature.rs:
##
@@ -431,6 +463,35 @@ impl TypeSignature {
}
}
+fn get_possible_types_from_signature_classes(
Review Comm
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948051074
##
datafusion/expr-common/src/signature.rs:
##
@@ -431,6 +463,35 @@ impl TypeSignature {
}
}
+fn get_possible_types_from_signature_classes(
Review Comm
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948051074
##
datafusion/expr-common/src/signature.rs:
##
@@ -431,6 +463,35 @@ impl TypeSignature {
}
}
+fn get_possible_types_from_signature_classes(
Review Comm
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948037292
##
datafusion/expr-common/src/signature.rs:
##
@@ -431,6 +463,35 @@ impl TypeSignature {
}
}
+fn get_possible_types_from_signature_classes(
+signatu
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948036125
##
datafusion/common/src/types/builtin.rs:
##
@@ -47,3 +49,11 @@ singleton!(LOGICAL_FLOAT64, logical_float64, Float64);
singleton!(LOGICAL_DATE, logical_date,
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948036125
##
datafusion/common/src/types/builtin.rs:
##
@@ -47,3 +49,11 @@ singleton!(LOGICAL_FLOAT64, logical_float64, Float64);
singleton!(LOGICAL_DATE, logical_date,
shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948008922
##
datafusion/expr-common/src/signature.rs:
##
@@ -225,6 +229,45 @@ impl Display for TypeSignatureClass {
}
}
+impl TypeSignatureClass {
+/// Retur
alamb commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1947837053
##
datafusion/expr-common/src/signature.rs:
##
@@ -127,12 +132,11 @@ pub enum TypeSignature {
Exact(Vec),
/// One or more arguments belonging to the [`Type
shehabgamin commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2644720408
> I will try and review this carefully over the weekend
>
> Maybe @shehabgamin has some time to take a look too
I will review over the weekend as well!
--
This is
alamb commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2643815648
I will try and review this carefully over the weekend
Maybe @shehabgamin has some time to take a look too
--
This is an automated message from the Apache Git Service.
To respo
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1945920988
##
datafusion/expr-common/src/signature.rs:
##
@@ -455,6 +461,46 @@ fn get_data_types(native_type: &NativeType) ->
Vec {
}
}
+#[derive(Debug, Clone)]
+
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1945857598
##
datafusion/functions/src/string/ascii.rs:
##
@@ -61,7 +63,13 @@ impl Default for AsciiFunc {
impl AsciiFunc {
pub fn new() -> Self {
Self {
-
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1945854733
##
datafusion/functions/src/string/repeat.rs:
##
@@ -65,10 +65,17 @@ impl Default for RepeatFunc {
impl RepeatFunc {
pub fn new() -> Self {
Self
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1945854931
##
datafusion/functions/src/string/repeat.rs:
##
@@ -65,10 +65,17 @@ impl Default for RepeatFunc {
impl RepeatFunc {
pub fn new() -> Self {
Self
77 matches
Mail list logo
