jayzhan211 commented on code in PR #14440: URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948036125
########## datafusion/common/src/types/builtin.rs: ########## @@ -47,3 +49,11 @@ singleton!(LOGICAL_FLOAT64, logical_float64, Float64); singleton!(LOGICAL_DATE, logical_date, Date); singleton!(LOGICAL_BINARY, logical_binary, Binary); singleton!(LOGICAL_STRING, logical_string, String); + +// TODO: Extend macro +// TODO: Should we use LOGICAL_TIMESTAMP_NANO to distinguish unit and timzeone? Review Comment: TypeSignatureClass::Timestamp acts as a wildcard, covering all possible units and timezones. If you're considering introducing a similar concept in NativeType, we should also discuss whether we need to include Numeric, Integer, or Float as part of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
