alamb commented on PR #14440: URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2659139980
> Enum looks good to me but "adding user defined coercion variant" is not clear to me since I think the Coercible signature is user-defined builtin, they can change the type they need and set it into their own function 🤔 That is true that `TypeSignature::Coercable` allows users to define whatever they want. I was thinking for @shehabgamin 's usecase where he wanted to implement coercsion that had a slightly different rules about when to cast Integer --> String. He could implement that with an entirely custom coercion, but it might be nice to just adjust the rules somehow (and leave all the rest of the logic the same) 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
