shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1951987206
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -431,6 +463,35 @@ impl TypeSignature {
}
}
+fn get_possible_types_from_signature_classes(
Review Comment:
> I think it is "simplified" because of some reasons, if we add all possible
types, the combination will be huge. This function is used in
information.schema that shows the possible signatures a function has. Is
listing all possible DataType combination helpful?
@jayzhan211 I'm moving the conversation to this thread to consolidate.
I totally understand your concern, here are my thoughts:
- I think we should rename this function and add a comment for clarity.
- `information.schema` is not reporting accurate information if we only list
a subset of possible types. I like your idea of using other output that isn't
`Vec<DataType>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
