goldmedal commented on PR #14440: URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2661228616
> If you can access Signature, no reason you can't access for `Coercion`. I think you should import `datafuison-expr-common` instead since Signature is re-exported in `datafusion-expr` for backward compatibility, but not for `Coercion` and `ImplicitCoercion` I see. I tried to use `Coercion` in the example crate that only uses the `datafusion` dependency. So, I can access `Siganture` by `use datafusion::logical_expr::Signature` because `logical_expr` is exported from `datafusion-expr`. I found `datafuison-expr-common` hasn't been re-exported in `datafusion`. Maybe we can re-export it. Just like what we did for `datafusion_physical_expr_common`. https://github.com/apache/datafusion/blob/587277fddae2c04c24fd9bbd8defc096ab6e58dc/datafusion/core/src/lib.rs#L751 ```rust pub mod logical_expr_common { pub use datafusion_expr_common::*; } ``` Then, user can only uses `datafusion` dependency without `datafusion-expr-common`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
