jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1948051074
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -431,6 +463,35 @@ impl TypeSignature {
}
}
+fn get_possible_types_from_signature_classes(
Review Comment:
This function is used in `information.schema` to list all possible signature
combination, but it is too granular than necessary, sometimes we can use
`NativeType` or a new struct that represent a set of `DataType` and it should
be enough.
@goldmedal
If there is function requires `Integer`, we don't need to list all possible
i8, i16, i32 or i64 but `integer` instead. I think we need a output other than
`Vec<DataType>` but something that could combines both `DataType` or a set of
type similar to `NativeType`. Otherwise we will generate tons of `DataType`
combination for `Coercible` signature and I guess it is not readable for
`information.schema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
