Re: [PR] Signature::Coercible with user defined implicit casting [datafusion]

[via GitHub]

shehabgamin commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1960715986


##########
datafusion/functions/src/datetime/date_part.rs:
##########
@@ -95,24 +96,29 @@ impl DatePartFunc {
             signature: Signature::one_of(
                 vec![
                     TypeSignature::Coercible(vec![
-                        TypeSignatureClass::Native(logical_string()),
-                        TypeSignatureClass::Timestamp,
+                        
Coercion::new_exact(TypeSignatureClass::Native(logical_string())),

Review Comment:
   > See https://github.com/apache/datafusion/pull/14268 for what is happening
   
   Is https://github.com/apache/datafusion/pull/14268 still relevant? I'm not 
sure what I should be doing with that PR after this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org