jayzhan211 commented on PR #14440: URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2661178188
> Thanks for working on this, @jayzhan211. The new behavior of coercion signature makes sense to me. > > I found I can't access `Coercion` and `ImplicitCoercion` outside the crate. I believe we need to publicly use them in `datafusion/expr/src/lib.rs`. Maybe we can just set it as below for all struct in `signature`. > > ``` > pub use datafusion_expr_common::signature::*; > ``` If you can access Signature, no reason you can't access for `Coercion`. I think you should import `datafuison-expr-common` instead since Signature is re-exported in `datafusion-expr` for backward compatibility, but not for `Coercion` and `ImplicitCoercion` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
