jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1953648058
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -365,7 +365,12 @@ impl TypeSignature {
}
}
- /// get all possible types for the given `TypeSignature`
+ /// This function is used specifically internally for `information_schema`
+ /// We suggest not to rely on this function
+ ///
+ /// Get all possible types for `information_schema` from the given
`TypeSignature`
+ //
+ // TODO: Make this function private
pub fn get_possible_types(&self) -> Vec<Vec<DataType>> {
Review Comment:
This is public function 😮
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
