[GitHub] rmatharu commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
rmatharu commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#discussion_r257439739 ## File path: samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubS

[GitHub] rmatharu commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
rmatharu commented on a change in pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#discussion_r257439733 ## File path: samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubS

[GitHub] asfgit closed pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-15 Thread GitBox
asfgit closed pull request #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923 This is an automated message from the Apache Git Service. To respond to the

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257072998 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257523115 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemC

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257523065 ## File path: samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemC

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257074119 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257522508 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257523191 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257523873 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-17 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257524023 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258141427 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33 @

[GitHub] lhaiesp commented on issue #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers

2019-02-19 Thread GitBox
lhaiesp commented on issue #923: Adding a bound on EventHubSystemConsumer's initalizeEventHubsManagers URL: https://github.com/apache/samza/pull/923#issuecomment-465251446 Looks good This is an automated message from the Apac

[GitHub] dxichen opened a new pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-19 Thread GitBox
dxichen opened a new pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924 @vjagadish @rmatharu Added check in the ContainerAllocator to check the host-affinity config before using the preferred

[GitHub] shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r257523191 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsu

[GitHub] rmatharu commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-19 Thread GitBox
rmatharu commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924#discussion_r258203228 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/Abstra

[GitHub] vjagadish1989 opened a new pull request #925: SAMZA-2109: Reduce per-partition default buffer sizes

2019-02-19 Thread GitBox
vjagadish1989 opened a new pull request #925: SAMZA-2109: Reduce per-partition default buffer sizes URL: https://github.com/apache/samza/pull/925 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] rmatharu commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-19 Thread GitBox
rmatharu commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924#discussion_r258203228 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/Abstra

[GitHub] shanthoosh commented on issue #925: SAMZA-2109: Reduce per-partition default buffer sizes

2019-02-19 Thread GitBox
shanthoosh commented on issue #925: SAMZA-2109: Reduce per-partition default buffer sizes URL: https://github.com/apache/samza/pull/925#issuecomment-465307020 Is it possible to back-port this patch to samza internal releases done at linkedin? --

[GitHub] vjagadish1989 commented on issue #925: SAMZA-2109: Reduce per-partition default buffer sizes

2019-02-19 Thread GitBox
vjagadish1989 commented on issue #925: SAMZA-2109: Reduce per-partition default buffer sizes URL: https://github.com/apache/samza/pull/925#issuecomment-465323526 Since, hot-fixes are reserved for critical bug fixes - probably not worth back-porting new features/enhancements. I'd wait for 1

[GitHub] asfgit closed pull request #925: SAMZA-2109: Reduce per-partition default buffer sizes

2019-02-19 Thread GitBox
asfgit closed pull request #925: SAMZA-2109: Reduce per-partition default buffer sizes URL: https://github.com/apache/samza/pull/925 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258138159 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258147011 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258142667 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258171369 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258231454 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258169902 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258228794 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258167734 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258248810 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258148518 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258224159 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258149441 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258221771 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-19 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258161946 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258288145 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33 @@ f

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-19 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258295838 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-19 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258286825 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-19 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258281900 ## File path: samza-core/src/main/java/org/apache/samza/system/SystemAdmins.java ##

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-19 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258283701 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-19 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258284619 ## File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemCo

[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

2019-02-19 Thread GitBox
cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer. URL: https://github.com/apache/samza/pull/918#discussion_r258302217 ## File path: samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.sca

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258307896 ## File path: samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java ## @@ -104,7 +10

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258308009 ## File path: samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java ## @@ -

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258306761 ## File path: samza-core/src/main/scala/org/apache/samza/coordinator/stream/CoordinatorStreamWriterCommandLine.sc

[GitHub] shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-19 Thread GitBox
shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258307442 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33 @

[GitHub] srinipunuru opened a new pull request #926: Records with all null values are transformed to null records

2019-02-20 Thread GitBox
srinipunuru opened a new pull request #926: Records with all null values are transformed to null records URL: https://github.com/apache/samza/pull/926 Right now Samza SQL AvroRelConverter transforms the records with null values into null records. I think this was added to support `select *

[GitHub] vjagadish1989 commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-20 Thread GitBox
vjagadish1989 commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924#discussion_r258627681 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/A

[GitHub] atoomula commented on issue #926: Records with all null values are transformed to null records

2019-02-20 Thread GitBox
atoomula commented on issue #926: Records with all null values are transformed to null records URL: https://github.com/apache/samza/pull/926#issuecomment-465715721 > Right now Samza SQL AvroRelConverter transforms the records with null values into null records. I think this was added to su

[GitHub] srinipunuru commented on issue #926: Records with all null values are transformed to null records

2019-02-20 Thread GitBox
srinipunuru commented on issue #926: Records with all null values are transformed to null records URL: https://github.com/apache/samza/pull/926#issuecomment-465718425 > > Right now Samza SQL AvroRelConverter transforms the records with null values into null records. I think this was added

[GitHub] dxichen commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-20 Thread GitBox
dxichen commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924#discussion_r258675192 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/Abstrac

[GitHub] dxichen commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-20 Thread GitBox
dxichen commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924#discussion_r258675192 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/Abstrac

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676142 ## File path: samza-core/src/main/scala/org/apache/samza/coordinator/stream/CoordinatorStreamWriterCommandLine.scala

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676267 ## File path: samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java ## @@ -104,7 +105,7

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676212 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -155,4 +158,33 @@ f

[GitHub] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

2019-02-20 Thread GitBox
Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258676318 ## File path: samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java ## @@ -75,

[GitHub] srinipunuru merged pull request #926: Records with all null values are transformed to null records

2019-02-20 Thread GitBox
srinipunuru merged pull request #926: Records with all null values are transformed to null records URL: https://github.com/apache/samza/pull/926 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-20 Thread GitBox
rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r258741092 ## File path: samza-core/src/main/java/org/apache/samza/clusterma

[GitHub] rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-20 Thread GitBox
rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r258741050 ## File path: samza-core/src/main/java/org/apache/samza/clusterma

[GitHub] rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-20 Thread GitBox
rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r258741216 ## File path: samza-core/src/main/java/org/apache/samza/clusterma

[GitHub] rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover

2019-02-20 Thread GitBox
rmatharu commented on a change in pull request #903: SEP-19: Allocator changes for standby-aware container allocation, and active container failover URL: https://github.com/apache/samza/pull/903#discussion_r258741189 ## File path: samza-core/src/main/java/org/apache/samza/clusterma

[GitHub] PawasChhokra opened a new pull request #49: Doc changes: Update to new GitBox links

2019-02-20 Thread GitBox
PawasChhokra opened a new pull request #49: Doc changes: Update to new GitBox links URL: https://github.com/apache/samza-hello-samza/pull/49 Updated the documentation with new GitBox links to hello-samza. This is an

[GitHub] atoomula opened a new pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code

2019-02-20 Thread GitBox
atoomula opened a new pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code URL: https://github.com/apache/samza/pull/927 Adding invokeApplicationRunner public static API in preparation for fast sql where this API will be called directly within the same process. --

[GitHub] jmakes merged pull request #49: Doc changes: Update to new GitBox links

2019-02-21 Thread GitBox
jmakes merged pull request #49: Doc changes: Update to new GitBox links URL: https://github.com/apache/samza-hello-samza/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code

2019-02-21 Thread GitBox
prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code URL: https://github.com/apache/samza/pull/927#discussion_r259036992 ## File path: samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java ## @@ -50

[GitHub] prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code

2019-02-21 Thread GitBox
prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code URL: https://github.com/apache/samza/pull/927#discussion_r259036757 ## File path: samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java ## @@ -50

[GitHub] vjagadish1989 commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-21 Thread GitBox
vjagadish1989 commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924#discussion_r259050451 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/A

[GitHub] dxichen commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching

2019-02-21 Thread GitBox
dxichen commented on a change in pull request #924: SAMZA-2108: Check for host affinity config before resolving preferred host matching URL: https://github.com/apache/samza/pull/924#discussion_r259063396 ## File path: samza-core/src/main/java/org/apache/samza/clustermanager/Abstrac

[GitHub] atoomula commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code

2019-02-21 Thread GitBox
atoomula commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code URL: https://github.com/apache/samza/pull/927#discussion_r259139729 ## File path: samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java ## @@ -50

[GitHub] dnishimura opened a new pull request #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output.

2019-02-21 Thread GitBox
dnishimura opened a new pull request #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output. URL: https://github.com/apache/samza/pull/928 **Symptom:** An `IllegalArgumentException` is thrown when the same `streamId` is referred from multiple inp

[GitHub] prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code

2019-02-21 Thread GitBox
prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code URL: https://github.com/apache/samza/pull/927#discussion_r259167288 ## File path: samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java ## @@ -51

[GitHub] mynameborat opened a new pull request #929: [Cleanup] Rename scalaVersion to scalaSuffix and scalaLibVersion to scalaVersion

2019-02-21 Thread GitBox
mynameborat opened a new pull request #929: [Cleanup] Rename scalaVersion to scalaSuffix and scalaLibVersion to scalaVersion URL: https://github.com/apache/samza/pull/929 Currently we have scala suffix being interchangeably used for `scalaVersion` and `scalaLibVersion` for scala version.

[GitHub] mynameborat opened a new pull request #930: [Cleanup] Remove deprecated kafka systems and related code

2019-02-21 Thread GitBox
mynameborat opened a new pull request #930: [Cleanup] Remove deprecated kafka systems and related code URL: https://github.com/apache/samza/pull/930 It is prerequisite PR for migrating to Kafka 2.0 since these deprecated code no longer compiles with Kafka 2.0 -

[GitHub] mynameborat commented on issue #930: [Cleanup] Remove deprecated kafka systems and related code

2019-02-21 Thread GitBox
mynameborat commented on issue #930: [Cleanup] Remove deprecated kafka systems and related code URL: https://github.com/apache/samza/pull/930#issuecomment-466235080 @sborya please take a look at it This is an automated messag

[GitHub] atoomula commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code

2019-02-21 Thread GitBox
atoomula commented on a change in pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code URL: https://github.com/apache/samza/pull/927#discussion_r259190861 ## File path: samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java ## @@ -50

[GitHub] asfgit closed pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code

2019-02-21 Thread GitBox
asfgit closed pull request #927: SAMZA-2111: Refactoring ApplicationRunnerMain code URL: https://github.com/apache/samza/pull/927 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-21 Thread GitBox
rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259205102 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageM

[GitHub] rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-21 Thread GitBox
rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259205224 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageM

[GitHub] rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-21 Thread GitBox
rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259205102 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageM

[GitHub] rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-21 Thread GitBox
rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259208017 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageM

[GitHub] rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-21 Thread GitBox
rmatharu commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259208405 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageM

[GitHub] rmatharu commented on issue #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-21 Thread GitBox
rmatharu commented on issue #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#issuecomment-466268272 Addressed all comments. Thumbsup => the comment has been applied. --

[GitHub] prateekm commented on issue #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output.

2019-02-22 Thread GitBox
prateekm commented on issue #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output. URL: https://github.com/apache/samza/pull/928#issuecomment-466497259 @dnishimura the equality check was intentional, because for some serdes (e.g. LI's AvroSpecif

[GitHub] dnishimura commented on issue #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output.

2019-02-22 Thread GitBox
dnishimura commented on issue #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output. URL: https://github.com/apache/samza/pull/928#issuecomment-466500208 Thanks for the review @prateekm ! In case you're waiting for the Travis-CI build to compl

[GitHub] asfgit closed pull request #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output.

2019-02-23 Thread GitBox
asfgit closed pull request #928: SAMZA-1990: Samza framework should let using the same system stream as both input and output. URL: https://github.com/apache/samza/pull/928 This is an automated message from the Apache Git Se

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259942012 ## File path: samza-core/src/main/java/org/apache/samza/storage/StorageManagerU

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259963070 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259952050 ## File path: samza-core/src/main/scala/org/apache/samza/container/SamzaContain

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259969766 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259967789 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259967191 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259968264 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259958242 ## File path: samza-core/src/main/scala/org/apache/samza/container/SamzaContain

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259945715 ## File path: samza-core/src/main/scala/org/apache/samza/container/SamzaContain

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259966131 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259970867 ## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStora

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259942267 ## File path: samza-core/src/main/java/org/apache/samza/storage/StorageManagerU

[GitHub] mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager

2019-02-25 Thread GitBox
mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259947595 ## File path: samza-core/src/main/scala/org/apache/samza/container/SamzaContain

[GitHub] rmatharu opened a new pull request #931: Ignoring standby tasks when grouping

2019-02-25 Thread GitBox
rmatharu opened a new pull request #931: Ignoring standby tasks when grouping URL: https://github.com/apache/samza/pull/931 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] asfgit closed pull request #931: Ignoring standby tasks when grouping

2019-02-25 Thread GitBox
asfgit closed pull request #931: Ignoring standby tasks when grouping URL: https://github.com/apache/samza/pull/931 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

<    1   2   3   4   5   6   7   8   9   10   >