shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app
and job config refactor
URL: https://github.com/apache/samza/pull/920#discussion_r258306761
##########
File path:
samza-core/src/main/scala/org/apache/samza/coordinator/stream/CoordinatorStreamWriterCommandLine.scala
##########
@@ -68,4 +72,27 @@ class CoordinatorStreamWriterCommandLine extends
CommandLine {
value
}
+
+ def genJobConfigs(config: MapConfig): MapConfig = {
Review comment:
Rather than duplicating this code at two places, could you please extract
them into a util method and move the duplicated code there. Invoke the util
method at all the places where you're calling this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
