mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259942012
########## File path: samza-core/src/main/java/org/apache/samza/storage/StorageManagerUtil.java ########## @@ -207,9 +208,11 @@ public static boolean storeExists(File storeDir) { * @param storeBaseDir the base directory to use * @param storeName the store name to use * @param taskName the task name which is referencing the store + * @param taskMode Review comment: nit: add documentation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services