mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258149441
########## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ########## @@ -101,6 +118,21 @@ private final JobContext jobContext; private final ContainerContext containerContext; + /* Sideinput related parameters */ + private final Map<String, List<SystemStream>> sideInputSystemStreams; // Map of side input system-streams indexed by store name + private final Map<TaskName, Map<String, Set<SystemStreamPartition>>> sideInputSSPs; + private final Map<TaskName, Map<String, SideInputsProcessor>> sideInputStoresToProcessor; + private final Map<SystemStreamPartition, TaskSideInputStorageManager> sideInputStorageManagers; // Map of sideInput storageManagers indexed by ssp, for simpler lookup for process() + private final Map<String, SystemConsumer> sideInputConsumers; // Mapping from storeSystemNames to SystemConsumers Review comment: Can we roll this into storeConsumers above? Store restoration and side inputs restoration happens sequentially, so not sure what is the purpose behind separating out the consumers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
