mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258138159
########## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ########## @@ -101,6 +118,21 @@ private final JobContext jobContext; private final ContainerContext containerContext; + /* Sideinput related parameters */ + private final Map<String, List<SystemStream>> sideInputSystemStreams; // Map of side input system-streams indexed by store name Review comment: What happens when there are duplicate system stream associated with a store? Can this be `Map<String, Set<SystemStram>>` instead? By that, you explicitly disallow duplicates and be consistent with the semantics of `sideInputSSps` which has a `task -> store -> set of ssps` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
