shanthoosh commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r258308009
########## File path: samza-core/src/test/java/org/apache/samza/runtime/TestLocalApplicationRunner.java ########## @@ -75,8 +75,8 @@ public void setUp() { public void testRunStreamTask() { final Map<String, String> cfgs = new HashMap<>(); cfgs.put(ApplicationConfig.APP_PROCESSOR_ID_GENERATOR_CLASS, UUIDGenerator.class.getName()); - cfgs.put(JobConfig.JOB_NAME(), "test-task-job"); - cfgs.put(JobConfig.JOB_ID(), "jobId"); + cfgs.put(ApplicationConfig.APP_NAME, "test-task-job"); + cfgs.put(ApplicationConfig.APP_ID, "jobId"); Review comment: s/jobId/testAppId s/test-task-job/testAppName ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services