prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring
ApplicationRunnerMain code
URL: https://github.com/apache/samza/pull/927#discussion_r259167288
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java
##########
@@ -51,28 +50,6 @@ public static void main(String[] args) throws Exception {
OptionSet options = cmdLine.parser().parse(args);
Config orgConfig = cmdLine.loadConfig(options);
ApplicationRunnerOperation op = cmdLine.getOperation(options);
- invokeApplicationRunner(orgConfig, op);
- }
-
- public static ApplicationRunner invokeApplicationRunner(Config orgConfig,
ApplicationRunnerOperation op) {
- Config config = Util.rewriteConfig(orgConfig);
-
- ApplicationRunner appRunner =
-
ApplicationRunners.getApplicationRunner(ApplicationUtil.fromConfig(config),
config);
-
- switch (op) {
- case RUN:
- appRunner.run(null);
- break;
- case KILL:
- appRunner.kill();
- break;
- case STATUS:
- System.out.println(appRunner.status());
- break;
- default:
- throw new IllegalArgumentException("Unrecognized operation: " + op);
- }
- return appRunner;
+ ApplicationRunnerUtil.invokeApplicationRunner(orgConfig, op);
Review comment:
Minor: s/invokeApplicationRunner/invoke
Minor: s/orgConfig/originalConfig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
