mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r259970867
########## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ########## @@ -407,14 +781,33 @@ public void stopStores() { } public void shutdown() { - this.taskRestoreManagers.forEach((taskInstance, taskRestoreManager) -> { - if (taskRestoreManager != null) { - LOG.debug("Shutting down task storage manager for taskName: {} ", taskInstance); - taskRestoreManager.stop(); - } else { - LOG.debug("Skipping task storage manager shutdown for taskName: {}", taskInstance); - } - }); + // stop all nonsideinputstores including persistent and non-persistent stores + this.containerModel.getTasks().forEach((taskName, taskModel) -> + getNonSideInputStores(taskName).forEach((storeName, store) -> store.stop()) + ); + + // stop reading sideInputs + this.shutDownSideInputRead = true; + + // stop all sideinput consumers and stores + if (sideInputSystemConsumers != null) { + this.sideInputSystemConsumers.stop(); Review comment: Should this go higher before shutting down the read? Wondering if the consumers have buffer which also needs to emptied before stopping the read. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services