mynameborat commented on a change in pull request #912: SEP-19 : Refactoring
sideInputs from SamzaContainer to ContainerStorageManager
URL: https://github.com/apache/samza/pull/912#discussion_r258161946
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -81,17 +96,19 @@
public class ContainerStorageManager {
private static final Logger LOG =
LoggerFactory.getLogger(ContainerStorageManager.class);
private static final String RESTORE_THREAD_NAME = "Samza Restore Thread-%d";
+ private static final String SIDEINPUTS_FLUSH_THREAD_NAME = "SideInputs Flush
Thread";
Review comment:
Documentation: Can you add a top level comment on the semantics of side
input restoration? Just to be explicit, call it out to be same as the
bootstrapping chooser semantics and when do we unblock the main thread.
Also, it seems with the new refactor, the side input store flushes are no
longer in sync with the task commit. The semantics of TaskCoordinator.commit()
have changed with this where the user explicitly requests a commit, we will not
respect it for side inputs store alone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
