mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r258231454
########## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ########## @@ -112,15 +144,49 @@ public ContainerStorageManager(ContainerModel containerModel, StreamMetadataCache streamMetadataCache, Review comment: Cosmetics: Can we break down constructor functions? Logically group some of the initialization and separate them out to make it more readable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
