Groups are not supported by OpenFlow 1.0
Signed-off-by: Simon Horman
---
* This is a follow up to "ovs-ofctl: Only allow usable protocols for group
commands" requested by Ben Pfaff.
* A further possible follow up is to test that group bucket commands
fail for OpenFlow < 1.5 once support for
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
* It is not clear to me what if any order the entries of NEWS are in
for each release
v3
* First post
---
NEWS | 1 +
1 file changed, 1 insertion(+)
diff --git a/NEWS b/NEWS
index 5ba8f4d..1d03e8c 100644
--- a/NEWS
+++ b/NEWS
@@ -22,6 +22,7 @
(Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the
buckets of existing groups. This patch add support to ovs-ofctl for these
commands. It also adds documentation and tests for them.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v3
* As suggested by Ben Pfaff
- Correc
(Draft) OpenFlow 1.5 adds bucket commands to group mod.
This patch allows parsing of them as a step towards supporting them.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v3
* No change
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
lib/ofp-parse.c | 60
Handle (draft) OpenFlow 1.5 insert and remove group commands
of group mod messages.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v3
* No change
v2
* As suggested by Ben Pfaff
- Use ONF-JIRA: EXT-350 annotation in changelog
---
ofproto/ofproto.c | 110 +
This is in preparation for supporting the bucket commands of
(draft) Open Flow 1.5 group mod messages.
Also document ofputil_bucket_check_duplicate_id() for good measure.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v3
* As suggested by Ben Pfaff
- Provide function-level comments
v2
* As
In preparation for supporting (draft) OpenFlow 1.5
group mod commands enhance the error logging of them.
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v3
* As suggested by Ben Pfaff
- Use case statement rather than blind array dereference for cmd_str
v2
* As suggested by Ben Pfaff
- Use
ONF-JIRA: EXT-350
Signed-off-by: Simon Horman
---
v3
* First Post
* Moved from handle_group_mod() as suggested by Ben Pfaff
(previously part of a different patch)
---
lib/ofp-util.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 496dc
Hi,
this series is intended to complete a full implementation of
EXT-350, draft OpenFlow 1.5 groups including. It provides the missing
compoents of that implementation by adding support for bucket actions.
Other portions of support for OpenFlow 1.5 groups has already been merged
(thanks Ben :).
K
On Tue, Nov 11, 2014 at 07:28:50PM -0800, Scott Mann wrote:
> Let me know what you want me to change, if you want me to do it. I'm still
> paying attention :)
I folded in the following change to improve the Autoconf quoting (see, I
said it was minor) and update AUTHORS, and applied this to master.
I'm decided to adopt the series you sent months ago that adds support
for multipart requests that actually have multiple parts. I'll probably
send out a reworked this week or next. (This is just a public service
announcement to avoid duplicating work; no need to reply.)
__
On Wed, Nov 12, 2014 at 01:52:57PM +0900, Simon Horman wrote:
> On Tue, Nov 11, 2014 at 08:44:29PM -0800, Ben Pfaff wrote:
> > On Wed, Nov 12, 2014 at 12:46:08PM +0900, Simon Horman wrote:
> > > On Tue, Nov 11, 2014 at 09:21:36AM -0800, Ben Pfaff wrote:
> > > > Using a blind array dereference into
On Wed, Nov 12, 2014 at 01:48:57PM +0900, Simon Horman wrote:
> On Tue, Nov 11, 2014 at 09:24:10AM -0800, Ben Pfaff wrote:
> > On Tue, Nov 11, 2014 at 12:39:26PM +0900, Simon Horman wrote:
> > > This is in preparation for supporting the bucket commands of
> > > (draft) Open Flow 1.5 group mod messa
On Tue, Nov 11, 2014 at 08:44:29PM -0800, Ben Pfaff wrote:
> On Wed, Nov 12, 2014 at 12:46:08PM +0900, Simon Horman wrote:
> > On Tue, Nov 11, 2014 at 09:21:36AM -0800, Ben Pfaff wrote:
> > > Using a blind array dereference into cmd_str[] in bad_group_cmd() seems
> > > like it could easily be overl
On Tue, Nov 11, 2014 at 09:24:10AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:26PM +0900, Simon Horman wrote:
> > This is in preparation for supporting the bucket commands of
> > (draft) Open Flow 1.5 group mod messages.
> >
> > ONF-JIRA: EXT-350
> > Signed-off-by: Simon Horman
> >
On Tue, Nov 11, 2014 at 08:45:59PM -0800, Ben Pfaff wrote:
> On Wed, Nov 12, 2014 at 01:33:50PM +0900, Simon Horman wrote:
> > On Tue, Nov 11, 2014 at 09:27:56AM -0800, Ben Pfaff wrote:
> > > On Tue, Nov 11, 2014 at 12:39:27PM +0900, Simon Horman wrote:
> > > > Handle (draft) OpenFlow 1.5 insert an
On Wed, Nov 12, 2014 at 01:33:50PM +0900, Simon Horman wrote:
> On Tue, Nov 11, 2014 at 09:27:56AM -0800, Ben Pfaff wrote:
> > On Tue, Nov 11, 2014 at 12:39:27PM +0900, Simon Horman wrote:
> > > Handle (draft) OpenFlow 1.5 insert and remove group commands
> > > of group mod messages.
> > >
> > > O
On Wed, Nov 12, 2014 at 01:07:26PM +0900, Simon Horman wrote:
> On Tue, Nov 11, 2014 at 09:33:08AM -0800, Ben Pfaff wrote:
> > On Tue, Nov 11, 2014 at 12:39:29PM +0900, Simon Horman wrote:
> > > (Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the
> > > buckets of existing grou
On Wed, Nov 12, 2014 at 12:46:08PM +0900, Simon Horman wrote:
> On Tue, Nov 11, 2014 at 09:21:36AM -0800, Ben Pfaff wrote:
> > Using a blind array dereference into cmd_str[] in bad_group_cmd() seems
> > like it could easily be overlooked if new commands get added later. I
> > would use a switch st
On Tue, Nov 11, 2014 at 09:27:56AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:27PM +0900, Simon Horman wrote:
> > Handle (draft) OpenFlow 1.5 insert and remove group commands
> > of group mod messages.
> >
> > ONF-JIRA: EXT-350
> > Signed-off-by: Simon Horman
> >
> > ---
> > v2
> >
On Tue, Nov 11, 2014 at 09:33:08AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:29PM +0900, Simon Horman wrote:
> > (Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the
> > buckets of existing groups. This patch add support to ovs-ofctl for these
> > commands. It als
On Tue, Nov 11, 2014 at 09:21:36AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:25PM +0900, Simon Horman wrote:
> > In preparation for supporting (draft) OpenFlow 1.5
> > group mod commands enhance the error logging of them.
> >
> > ONF-JIRA: EXT-350
> > Signed-off-by: Simon Horman
> >
On Tue, Nov 11, 2014 at 09:15:51AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:22PM +0900, Simon Horman wrote:
> > This is part of support for (draft) OpenFlow 1.5 flow mod messages.
> >
> > This adds support for specifying the bucket_id of buckets of groups in
> > ovs-ofctl and docume
On Tue, Nov 11, 2014 at 08:49:56AM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 12:39:19PM +0900, Simon Horman wrote:
> > This provides the bulk of the ofproto side of support for
> > OpenFlow 1.5 group messages. It provides for encoding and decoding
> > of updated group mod and group desc rep
Ben,
Let me know what you want me to change, if you want me to do it. I'm still
paying attention :)
-Scott
On Tue, Nov 11, 2014 at 6:04 PM, Gurucharan Shetty
wrote:
> On Tue, Nov 11, 2014 at 3:07 PM, Ben Pfaff wrote:
> > On Fri, Nov 07, 2014 at 07:02:09PM -0800, Scott Mann wrote:
> >> From: Sco
In this patch, we update HvCreatePort() to be able to re-add a Hyper-V
port. Specifically, we handle the case where the port had also been
added by OVS userspace, so that when the port was previously deleted
from Hyper-V, we did not deallocate the port.
The key to a vport is its name. We lookup th
In this patch, we update the documentation for 'portIdHashArray' to
indicate that a vport would exist in this hash table if and only if it
also exists on the Hyper-V switch.
This functionality to implement this semantic will follow in subsequent
patches.
Signed-off-by: Nithin Raju
---
datapath-
In this patch, we add changes to OvsRemoveAndDeleteVport() to allow the
caller to specify if a vport is being deleted because it got deleted on
Hyper-V or if it got deleted from OVS userspace.
The reason we need to make the distinction is to be able to delete the
vport from the relevant hash table
OvsInitVxlanTunnel() need not return a NL_ERROR. In this patch, we
change it to NTSTATUS, and also update the mapping function that maps a
NTSTATUS to NL_ERROR.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |3 ++-
datapath-windows/ovsext/Netlink/NetlinkError.
In this patch, we rename the existing OvsFindVportByHvName() to
OvsFindVportByHvNameA() to indicate that the input string is an ASCII
string. We also define a OvsFindVportByHvNameW() that takes as input a
WCHAR string.
This will be used later in HvCreatPort() to check for ports with
duplicate name
In this series of patches we make a bunch of changes to be able to
re-add a Hyper-V port to OVS. Known caveats are this code does not
work if a internal or external port is deleted and re-added, since
we over-write the friendly name. The code works for VIF ports.
Nithin Raju (7):
datapath-window
If a Hyper-V port (for which there exists an OVS port), gets deleted and
re-added, we'll call into InitOvsVportCommon() for the port to insert
the port into the 'portIdHashArray' as well as do a few other
initialization in the switch ocntext.
We should not be incrementing 'numHvPorts' at this poin
A few fixes around locking.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 16 ++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index a46d49f..ff105b7 100644
--- a/datapath-windo
On Tue, Nov 11, 2014 at 6:50 PM, Jesse Gross wrote:
> On Tue, Nov 11, 2014 at 1:13 PM, Pravin Shelar wrote:
>> On Mon, Nov 10, 2014 at 4:00 AM, Lori Jakab wrote:
>>>
>>> On 11/7/14 8:50 AM, Pravin Shelar wrote:
On Thu, Nov 6, 2014 at 12:21 PM, Lori Jakab wrote:
>
> On 11/6/14
RHEL 6.6 kernel percpu APIs are broken, so following patch is using OVS
backported version.
Reported-by: Wang Sheng-Hui
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/include/linux/percpu.h |6 ++
datapath/linux/compat/include/linux/skbuff.h |2 +-
2 files changed, 7 inser
On Tue, Nov 11, 2014 at 1:13 PM, Pravin Shelar wrote:
> On Mon, Nov 10, 2014 at 4:00 AM, Lori Jakab wrote:
>>
>> On 11/7/14 8:50 AM, Pravin Shelar wrote:
>>>
>>> On Thu, Nov 6, 2014 at 12:21 PM, Lori Jakab wrote:
On 11/6/14 4:06 AM, Pravin Shelar wrote:
>>>
>>> Have you tried r
Hi,
According to the documentation here, only physical NICs are supported.
https://github.com/openvswitch/ovs/blob/master/INSTALL.DPDK.md
Regards
Zefang
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
[1] The NDIS port state should always reflect the port state maintained by
NDIS so it should never be directly updated.
[2] Remove the "port name" field as we use the "friendly name" instead.
Signed-off-by: Eitan Eliahu
---
datapath-windows/ovsext/Vport.c | 17 -
datapath-win
On Tue, Nov 11, 2014 at 3:07 PM, Ben Pfaff wrote:
> On Fri, Nov 07, 2014 at 07:02:09PM -0800, Scott Mann wrote:
>> From: Scott Mann
>>
>> These changes allow for the building of shared libraries by providing
>> the --enable-shared option to configure. In particular, lib/libopenvwitch.so,
>> lib/l
On Nov 12, 2014, at 1:31 AM, Eitan Eliahu
wrote:
> Update Hyper-V port properties on NDIS property port set callback.
> Driver update the port friendly name in its internal table.
> Since the NIC Create callback won't be called after we need to maintain the
> NIC and THE OVS states of the Vport.
Update Hyper-V port properties on NDIS property port set callback.
Driver update the port friendly name in its internal table.
Since the NIC Create callback won't be called after we need to maintain the
NIC and THE OVS states of the Vport.
Setting a new friendly name was tested in the following st
On Tue, Nov 11, 2014 at 12:00:59PM -0800, Jarno Rajahalme wrote:
> This patch integrates insert_rule() to the sole caller
> classifier_replace(). This makes classifer_replace() more symmetric
> with classifier_remove(), and makes it easier to change the following:
>
> - Rules invisible to the loo
Signed-off-by: Ben Pfaff
---
include/openflow/openflow-1.1.h |4 ++--
lib/ofp-util.c | 10 +-
lib/ofp-util.h |4 ++--
ofproto/bond.c |2 +-
ofproto/ofproto-dpif.h |4 ++--
tests/ofproto.at|2
On Mon, Nov 10, 2014 at 12:46:15PM -0800, Pravin B Shelar wrote:
> Following patch adds support for userspace tunneling. Tunneling
> needs three more component first is routing table which is configured by
> caching kernel routes and second is ARP cache which build automatically
> by snooping arp.
On Tue, Nov 11, 2014 at 03:41:15PM -0800, Pravin Shelar wrote:
> On Tue, Nov 11, 2014 at 3:37 PM, Jarno Rajahalme
> wrote:
> > Shifting a 32-bit entity by 32 bits is undefined behavior. As we have 3
> > cases where we may hit this, it is a time to introduce a helper for
> > this.
> >
> > VMware-
Thanks for a quick review!
Applied to master and backported to branch-2.3.
Jarno
On Nov 11, 2014, at 3:41 PM, Pravin Shelar wrote:
> On Tue, Nov 11, 2014 at 3:37 PM, Jarno Rajahalme
> wrote:
>> Shifting a 32-bit entity by 32 bits is undefined behavior. As we have 3
>> cases where we may h
On Tue, Nov 11, 2014 at 3:37 PM, Jarno Rajahalme wrote:
> Shifting a 32-bit entity by 32 bits is undefined behavior. As we have 3
> cases where we may hit this, it is a time to introduce a helper for
> this.
>
> VMware-BZ: #1355026
> Signed-off-by: Jarno Rajahalme
LGTM
Acked-by: Pravin B Shelar
On Mon, Nov 10, 2014 at 12:46:15PM -0800, Pravin B Shelar wrote:
> Following patch adds support for userspace tunneling. Tunneling
> needs three more component first is routing table which is configured by
> caching kernel routes and second is ARP cache which build automatically
> by snooping arp.
Shifting a 32-bit entity by 32 bits is undefined behavior. As we have 3
cases where we may hit this, it is a time to introduce a helper for
this.
VMware-BZ: #1355026
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c |2 +-
lib/meta-flow.c |8 +++-
lib/ovs-router.c |2 +-
lib/
On Fri, Nov 7, 2014 at 5:51 PM, Alex Wang wrote:
> There is a portion of the 'struct dp_netdev_port' initialization
> that is placed after the reload of pmd threads. This means in
> theory, there could be a race where pmd threads access half-
> initialized struct. Although such race has not been
On Mon, Nov 10, 2014 at 4:00 AM, Lori Jakab wrote:
>
> On 11/7/14 8:50 AM, Pravin Shelar wrote:
>>
>> On Thu, Nov 6, 2014 at 12:21 PM, Lori Jakab wrote:
>>>
>>> On 11/6/14 4:06 AM, Pravin Shelar wrote:
>>
>> Have you tried running GSO traffic over lisp using OVS compat GSO code
>> and
>
> I would like to keep the option to share the same zones because I
> can see a lot of value to match on CTs which have been created by
> netfilter or vice versa.
Is it sufficient if both ip_defrag and conntrack actions uses the same
zone as their
parameters?
>
>> Technically this cleaner. OVS IP
On Fri, Nov 07, 2014 at 07:02:09PM -0800, Scott Mann wrote:
> From: Scott Mann
>
> These changes allow for the building of shared libraries by providing
> the --enable-shared option to configure. In particular, lib/libopenvwitch.so,
> lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so
On Fri, Nov 07, 2014 at 02:51:42PM -0800, Alex Wang wrote:
> Before this commit, the ofproto-dpif-xlate module uses ovs-rcu to
> postpone the destroy of previous configuration. However, the delayed
> close of object like 'struct netdev' could cause failure in immediate
> re-add or reconfigure of t
On 11/11/14 at 12:03pm, Andy Zhou wrote:
> On Tue, Nov 11, 2014 at 2:48 AM, Thomas Graf wrote:
> > Don't you need to pull off the ethernet header first? ip_defrag()
> > expects an IP header at skb->data.
> I could be wrong on this, but It looks to me ip_defrag uses ip_hdr()
> to get the IP header
Thanks, applied to master.
On Tue, Nov 11, 2014 at 01:43:20PM -0800, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Nov 11, 2014, at 8:20 AM, Ben Pfaff wrote:
>
> > On my Debian "jessie" system, provided by GCC 4.9 is busted
> > when Clang 3.5 tries to use it. Even a trivial progr
Acked-by: Jarno Rajahalme
On Nov 11, 2014, at 8:20 AM, Ben Pfaff wrote:
> On my Debian "jessie" system, provided by GCC 4.9 is busted
> when Clang 3.5 tries to use it. Even a trivial program like this:
>
>#include
>
>void
>foo(void)
>{
> _Atomic(int) x;
> at
On Tue, Nov 11, 2014 at 2:48 AM, Thomas Graf wrote:
> On 11/10/14 at 02:52pm, Andy Zhou wrote:
>> Implements ip_defrag action in Linux kenrel using ip_defrag kernel APIs.
>>
>> Signed-off-by: Andy Zhou
>> ---
>> datapath/actions.c | 39 ++-
>> datapath/fl
classifier_remove() was recently changed to take a const struct
cls_rule *. Make the corresponding change to classifier_replace() and
classifier_insert(). This simplifies existing calling sites in
ofproto.
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c | 14 --
lib/classifi
Previously, accurate iteration required writers to be excluded during
iteration. This patch adds an rculist to struct cls_subtable, and a
corresponding list node to struct cls_rule, which makes iteration more
straightforward, and allows the iterators to remain ignorant of the
internals of the cls_
This patch adds a new 'defer' parameter to the classifier modification
API, and a new function classifier_publish(), that can be used to make
deferred modifications visible to classifier lookups. Calling any of
the modification functions (classifier_insert(), classifier_replace(),
and classifier_r
Almost all classifier users already exclude concurrent modifications,
or are single-threaded, hence the classifier internal mutex can be
removed. Due to this change, ovs-router.c needs a new mutex, which is
added.
Suggested-by: Ben Pfaff
Signed-off-by: Jarno Rajahalme
---
lib/classifier-privat
This patch integrates insert_rule() to the sole caller
classifier_replace(). This makes classifer_replace() more symmetric
with classifier_remove(), and makes it easier to change the following:
- Rules invisible to the lookups are no longer inserted to any of the
index cmaps or tries.
- subtabl
On Fri, Nov 07, 2014 at 12:31:16PM +0530, Saloni Jain wrote:
> Also attaching the patch for your reference.
Thank you for the patch. I have some comments.
"sparse" reported these warnings:
../lib/ofp-util.c:77:17: warning: non-ANSI function declaration of function
'get_ovsprop_map'
../lib/ofp-
This commit adds functionality to return the ElementName of all the VNIC of a
given virtual machine name.
The function returns all the allocated ports including the ones which the OVS
port name was not set.
The default OVS port name that is set is the following:
"ElementName : Dynamic
On Tue, Nov 11, 2014 at 12:39:23PM +0900, Simon Horman wrote:
> This is to exercise OpenFlow 1.3 group stats replies
> messages which include a duration.
>
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 annotation in chang
On Tue, Nov 11, 2014 at 12:39:29PM +0900, Simon Horman wrote:
> (Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the
> buckets of existing groups. This patch add support to ovs-ofctl for these
> commands. It also adds documentation and tests for them.
>
> ONF-JIRA: EXT-350
> S
On Tue, Nov 11, 2014 at 12:39:28PM +0900, Simon Horman wrote:
> (Draft) OpenFlow 1.5 adds bucket commands to group mod.
> This patch allows parsing of them as a step towards supporting them.
>
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use
On Tue, Nov 11, 2014 at 12:39:27PM +0900, Simon Horman wrote:
> Handle (draft) OpenFlow 1.5 insert and remove group commands
> of group mod messages.
>
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 annotation in changelog
On Tue, Nov 11, 2014 at 12:39:26PM +0900, Simon Horman wrote:
> This is in preparation for supporting the bucket commands of
> (draft) Open Flow 1.5 group mod messages.
>
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 anno
On Tue, Nov 11, 2014 at 12:39:25PM +0900, Simon Horman wrote:
> In preparation for supporting (draft) OpenFlow 1.5
> group mod commands enhance the error logging of them.
>
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 an
On Tue, Nov 11, 2014 at 12:39:24PM +0900, Simon Horman wrote:
> This motivation for this change is to exercise
> (draft) OpenFlow 1.5 group messages.
>
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 annotation in changelog
On Tue, Nov 11, 2014 at 12:39:22PM +0900, Simon Horman wrote:
> This is part of support for (draft) OpenFlow 1.5 flow mod messages.
>
> This adds support for specifying the bucket_id of buckets of groups in
> ovs-ofctl and documents that accordingly.
>
> ONF-JIRA: EXT-350
> Signed-off-by: Simon H
On Tue, Nov 11, 2014 at 12:39:21PM +0900, Simon Horman wrote:
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 annotation in changelog
Thanks, applied.
___
dev mailing list
dev@ope
On Tue, Nov 11, 2014 at 12:39:20PM +0900, Simon Horman wrote:
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 annotation in changelog
Thanks.
I changed ofp_print_bucket_id() to better suit my ideas of
maintainability:
sta
On Tue, Nov 11, 2014 at 08:47:26AM -0800, Pravin Shelar wrote:
> On Tue, Nov 11, 2014 at 7:51 AM, Ben Pfaff wrote:
> > On Mon, Nov 10, 2014 at 12:46:11PM -0800, Pravin B Shelar wrote:
> >> This is similar to ovs_scan but takes int pointer as extra
> >> parameter, this pointer point to starting ind
On Tue, Nov 11, 2014 at 12:39:19PM +0900, Simon Horman wrote:
> This provides the bulk of the ofproto side of support for
> OpenFlow 1.5 group messages. It provides for encoding and decoding
> of updated group mod and group desc reply messages. This includes
> a new bucket format and their properti
On Tue, Nov 11, 2014 at 7:51 AM, Ben Pfaff wrote:
> On Mon, Nov 10, 2014 at 12:46:11PM -0800, Pravin B Shelar wrote:
>> This is similar to ovs_scan but takes int pointer as extra
>> parameter, this pointer point to starting index of the string.
>> On successful scan this API stores number of chara
On Tue, Nov 11, 2014 at 7:58 AM, Ben Pfaff wrote:
> On Mon, Nov 10, 2014 at 12:45:57PM -0800, Pravin B Shelar wrote:
>> Tunnel lookup is done in slow path but DPDK tunneling
>> slow path is called in PMD context. Therefore it is
>> better to convert rwlock to fat rwlock.
>>
>> Signed-off-by: Pravi
On Tue, Nov 11, 2014 at 12:39:18PM +0900, Simon Horman wrote:
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman
>
> ---
> v2
> * As suggested by Ben Pfaff
> + Use ONF-JIRA: EXT-350 annotation in changelog
> + Correct spelling: s/FLow/Flow/
> + Removed the following which seem unnecessary in
On my Debian "jessie" system, provided by GCC 4.9 is busted
when Clang 3.5 tries to use it. Even a trivial program like this:
#include
void
foo(void)
{
_Atomic(int) x;
atomic_fetch_add(&x, 1);
}
yields:
atomic.c:7:5: error: address argument to atomic op
On Mon, Nov 10, 2014 at 12:45:57PM -0800, Pravin B Shelar wrote:
> Tunnel lookup is done in slow path but DPDK tunneling
> slow path is called in PMD context. Therefore it is
> better to convert rwlock to fat rwlock.
>
> Signed-off-by: Pravin B Shelar
Would you mind using ovsthread_once (or pthr
On Mon, Nov 10, 2014 at 12:46:11PM -0800, Pravin B Shelar wrote:
> This is similar to ovs_scan but takes int pointer as extra
> parameter, this pointer point to starting index of the string.
> On successful scan this API stores number of characters
> scanned. This API is useful for parsing complex
On Tue, Nov 11, 2014 at 02:51:46PM +0100, Thomas Graf wrote:
> A new option -Wsparse-error has been introduced to sparse in the
> commits:
>
> 4d8811 sparse: Make -Werror turn warnigns into errors
> fe57af rename -Werror to -Wsparse-error
>
> which makes sparse fail on warnings. Start
A new option -Wsparse-error has been introduced to sparse in the
commits:
4d8811 sparse: Make -Werror turn warnigns into errors
fe57af rename -Werror to -Wsparse-error
which makes sparse fail on warnings. Start using the sparse git tree
for verification and make use of the new fla
On 11/10/14 at 12:46pm, Pravin B Shelar wrote:
> Following patch adds support for userspace tunneling. Tunneling
> needs three more component first is routing table which is configured by
> caching kernel routes and second is ARP cache which build automatically
> by snooping arp. And third is tunne
On 11/10/14 at 12:46pm, Pravin B Shelar wrote:
> This is similar to ovs_scan but takes int pointer as extra
> parameter, this pointer point to starting index of the string.
> On successful scan this API stores number of characters
> scanned. This API is useful for parsing complex odp actions
> e.g
On 11/10/14 at 12:45pm, Pravin B Shelar wrote:
> Tunnel lookup is done in slow path but DPDK tunneling
> slow path is called in PMD context. Therefore it is
> better to convert rwlock to fat rwlock.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Thomas Graf
___
On 11/10/14 at 02:52pm, Andy Zhou wrote:
> Implements ip_defrag action in Linux kenrel using ip_defrag kernel APIs.
>
> Signed-off-by: Andy Zhou
> ---
> datapath/actions.c | 39 ++-
> datapath/flow_netlink.c | 6 +-
> 2 files changed, 43 insertions(+
Hi Ben,
> > This patch enables a user to set importance for a new rule via
> > add-flow
> > OF1.4+ in the OVS and display the same via dump-flows command
> > OF1.4+ .
> > The changes are made in accordance with OpenFlow 1.4 specs to
> > implement
> > Eviction on the basis of "importance".This patc
On Mon, Nov 10, 2014 at 08:34:30PM -0800, Ben Pfaff wrote:
> On Tue, Nov 11, 2014 at 10:01:03AM +0900, Simon Horman wrote:
> > On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote:
> > > On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote:
> > > > EXT-350
> > > > Signed-off-by: Simon
91 matches
Mail list logo
