On Tue, Nov 11, 2014 at 03:41:15PM -0800, Pravin Shelar wrote:
> On Tue, Nov 11, 2014 at 3:37 PM, Jarno Rajahalme <jrajaha...@nicira.com> 
> wrote:
> > Shifting a 32-bit entity by 32 bits is undefined behavior.  As we have 3
> > cases where we may hit this, it is a time to introduce a helper for
> > this.
> >
> > VMware-BZ: #1355026
> > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
> 
> LGTM
> Acked-by: Pravin B Shelar <pshe...@nicira.com>

Pravin, your "userspace tunneling" patch has at least one place it
should use this, in netdev_dummy_ip4addr().

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to